Only disable infarch rules on erase if the package was in lock-step

[thirdparty/libsolv.git] / src / rules.c

/*
 * Copyright (c) 2007-2017, SUSE Inc.
 *
 * This program is licensed under the BSD license, read LICENSE.BSD
 * for further information
 */

/*
 * rules.c
 *
 * SAT based dependency solver
 */

#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <string.h>
#include <assert.h>

#include "solver.h"
#include "solver_private.h"
#include "bitmap.h"
#include "pool.h"
#include "poolarch.h"
#include "util.h"
#include "evr.h"
#include "policy.h"
#include "solverdebug.h"
#include "linkedpkg.h"
#include "cplxdeps.h"

#define RULES_BLOCK 63

static void addpkgruleinfo(Solver *solv, Id p, Id p2, Id d, int type, Id dep);

static inline int
is_otherproviders_dep(Pool *pool, Id dep)
{
  if (ISRELDEP(dep))
    {
      Reldep *rd = GETRELDEP(pool, dep);
      if (rd->flags == REL_NAMESPACE && rd->name == NAMESPACE_OTHERPROVIDERS)
        return 1;
    }
  return 0;
}

/********************************************************************
 *
 * Rule handling
 *
 * - unify rules, remove duplicates
 */

/*-------------------------------------------------------------------
 *
 * compare rules for unification sort
 *
 */

static int
unifyrules_sortcmp(const void *ap, const void *bp, void *dp)
{
  Pool *pool = dp;
  Rule *a = (Rule *)ap;
  Rule *b = (Rule *)bp;
  Id *ad, *bd;
  int x;

  x = a->p - b->p;
  if (x)
    return x;                           /* p differs */

  /* identical p */
  if (a->d == 0 && b->d == 0)           /* both assertions or binary */
    return a->w2 - b->w2;

  if (a->d == 0)                        /* a is assertion or binary, b not */
    {
      x = a->w2 - pool->whatprovidesdata[b->d];
      return x ? x : -1;
    }

  if (b->d == 0)                        /* b is assertion or binary, a not */
    {
      x = pool->whatprovidesdata[a->d] - b->w2;
      return x ? x : 1;
    }

  if (a->d == b->d)
    return 0;

  /* compare whatprovidesdata */
  ad = pool->whatprovidesdata + a->d;
  bd = pool->whatprovidesdata + b->d;
  while (*bd)
    if ((x = *ad++ - *bd++) != 0)
      return x;
  return *ad;
}

int
solver_rulecmp(Solver *solv, Rule *r1, Rule *r2)
{
  return unifyrules_sortcmp(r1, r2, solv->pool);
}


/*-------------------------------------------------------------------
 *
 * unify rules
 * go over all rules and remove duplicates
 */

void
solver_unifyrules(Solver *solv)
{
  Pool *pool = solv->pool;
  int i, j;
  Rule *ir, *jr;

  if (solv->nrules <= 2)                /* nothing to unify */
    return;

  if (solv->recommendsruleq)
    {
      /* mis-use n2 as recommends rule marker */
      for (i = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
        ir->n2 = 0;
      for (i = 0; i < solv->recommendsruleq->count; i++)
        solv->rules[solv->recommendsruleq->elements[i]].n2 = 1;
    }

  /* sort rules first */
  solv_sort(solv->rules + 1, solv->nrules - 1, sizeof(Rule), unifyrules_sortcmp, solv->pool);

  /* prune rules */
  jr = 0;
  for (i = j = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
    {
      if (jr && !unifyrules_sortcmp(ir, jr, pool))
        {
          jr->n2 &= ir->n2;             /* bitwise-and recommends marker */
          continue;                     /* prune! */
        }
      jr = solv->rules + j++;           /* keep! */
      if (ir != jr)
        *jr = *ir;
    }

  /* reduced count from nrules to j rules */
  POOL_DEBUG(SOLV_DEBUG_STATS, "pruned rules from %d to %d\n", solv->nrules, j);

  /* adapt rule buffer */
  solver_shrinkrules(solv, j);

  if (solv->recommendsruleq)
    {
      /* rebuild recommendsruleq */
      queue_empty(solv->recommendsruleq);
      for (i = 1, ir = solv->rules + i; i < solv->nrules; i++, ir++)
        if (ir->n2)
          {
            ir->n2 = 0;
            queue_push(solv->recommendsruleq, i);
          }
    }

  /*
   * debug: log rule statistics
   */
  IF_POOLDEBUG (SOLV_DEBUG_STATS)
    {
      int binr = 0;
      int lits = 0;
      Id *dp;
      Rule *r;

      for (i = 1; i < solv->nrules; i++)
        {
          r = solv->rules + i;
          if (r->d == 0)
            binr++;
          else
            {
              dp = pool->whatprovidesdata + r->d;
              while (*dp++)
                lits++;
            }
        }
      POOL_DEBUG(SOLV_DEBUG_STATS, "  binary: %d\n", binr);
      POOL_DEBUG(SOLV_DEBUG_STATS, "  normal: %d, %d literals\n", solv->nrules - 1 - binr, lits);
    }
}

#if 0

/*
 * hash rule
 */

static Hashval
hashrule(Solver *solv, Id p, Id d, int n)
{
  unsigned int x = (unsigned int)p;
  int *dp;

  if (n <= 1)
    return (x * 37) ^ (unsigned int)d;
  dp = solv->pool->whatprovidesdata + d;
  while (*dp)
    x = (x * 37) ^ (unsigned int)*dp++;
  return x;
}
#endif


/*-------------------------------------------------------------------
 *
 */

/*
 * add rule
 *
 * A requires b, b provided by B1,B2,B3 => (-A|B1|B2|B3)
 *
 * p < 0  : pkg id of A
 * d > 0  : Offset in whatprovidesdata (list of providers of b)
 *
 * A conflicts b, b provided by B1,B2,B3 => (-A|-B1), (-A|-B2), (-A|-B3)
 * p < 0  : pkg id of A
 * p2 < 0 : Id of solvable (e.g. B1)
 *
 * d == 0, p2 == 0: unary rule, assertion => (A) or (-A)
 *
 *   Install:    p > 0, d = 0   (A)             user requested install
 *   Remove:     p < 0, d = 0   (-A)            user requested remove (also: uninstallable)
 *   Requires:   p < 0, d > 0   (-A|B1|B2|...)  d: <list of providers for requirement of p>
 *   Updates:    p > 0, d > 0   (A|B1|B2|...)   d: <list of updates for solvable p>
 *   Conflicts:  p < 0, p2 < 0  (-A|-B)         either p (conflict issuer) or d (conflict provider) (binary rule)
 *                                              also used for obsoletes
 *   No-op ?:    p = 0, d = 0   (null)          (used as placeholder in update/feature rules)
 *
 *   resulting watches:
 *   ------------------
 *   Direct assertion (no watch needed) --> d = 0, w1 = p, w2 = 0
 *   Binary rule: p = first literal, d = 0, w2 = second literal, w1 = p
 *   every other : w1 = p, w2 = whatprovidesdata[d];
 *
 *   always returns a rule for non-pkg rules
 */

Rule *
solver_addrule(Solver *solv, Id p, Id p2, Id d)
{
  Pool *pool = solv->pool;
  Rule *r;

  if (d)
    {
      assert(!p2 && d > 0);
      if (!pool->whatprovidesdata[d])
        d = 0;
      else if (!pool->whatprovidesdata[d + 1])
        {
          p2 = pool->whatprovidesdata[d];
          d = 0;
        }
    }

  /* now we have two cases:
   * 1 or 2 literals:    d = 0, p, p2 contain the literals
   * 3 or more literals: d > 0, p2 == 0, d is offset into whatprovidesdata
   */

  /* it often happenes that requires lead to adding the same pkg rule
   * multiple times, so we prune those duplicates right away to make
   * the work for unifyrules a bit easier */
  if (!solv->pkgrules_end)              /* we add pkg rules */
    {
      r = solv->rules + solv->lastpkgrule;
      if (d)
        {
          Id *dp;
          /* check if rule is identical */
          if (r->p == p)
            {
              Id *dp2;
              if (r->d == d)
                return r;
              dp2 = pool->whatprovidesdata + r->d;
              for (dp = pool->whatprovidesdata + d; *dp; dp++, dp2++)
                if (*dp != *dp2)
                  break;
              if (*dp == *dp2)
                return r;
            }
          /* check if rule is self-fulfilling */
          for (dp = pool->whatprovidesdata + d; *dp; dp++)
            if (*dp == -p)
              return 0;                 /* rule is self-fulfilling */
        }
      else
        {
          if (p2 && p > p2)
            {
              Id o = p;                 /* switch p1 and p2 */
              p = p2;
              p2 = o;
            }
          if (r->p == p && !r->d && r->w2 == p2)
            return r;
          if (p == -p2)
            return 0;                   /* rule is self-fulfilling */
        }
      solv->lastpkgrule = solv->nrules;
    }

  solv->rules = solv_extend(solv->rules, solv->nrules, 1, sizeof(Rule), RULES_BLOCK);
  r = solv->rules + solv->nrules++;    /* point to rule space */
  r->p = p;
  r->d = d;
  r->w1 = p;
  r->w2 = d ? pool->whatprovidesdata[d] : p2;
  r->n1 = 0;
  r->n2 = 0;
  IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
    {
      POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "  Add rule: ");
      solver_printrule(solv, SOLV_DEBUG_RULE_CREATION, r);
    }
  return r;
}


void
solver_shrinkrules(Solver *solv, int nrules)
{
  solv->nrules = nrules;
  solv->rules = solv_extend_resize(solv->rules, solv->nrules, sizeof(Rule), RULES_BLOCK);
  solv->lastpkgrule = 0;
}

/******************************************************************************
 ***
 *** pkg rule part: create rules representing the package dependencies
 ***
 ***/

/*
 *  special multiversion patch conflict handling:
 *  a patch conflict is also satisfied if some other
 *  version with the same name/arch that doesn't conflict
 *  gets installed. The generated rule is thus:
 *  -patch|-cpack|opack1|opack2|...
 */
static Id
makemultiversionconflict(Solver *solv, Id n, Id con)
{
  Pool *pool = solv->pool;
  Solvable *s, *sn;
  Queue q;
  Id p, pp, qbuf[64];

  sn = pool->solvables + n;
  queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
  queue_push(&q, -n);
  FOR_PROVIDES(p, pp, sn->name)
    {
      s = pool->solvables + p;
      if (s->name != sn->name || s->arch != sn->arch)
        continue;
      if (!MAPTST(&solv->multiversion, p))
        continue;
      if (pool_match_nevr(pool, pool->solvables + p, con))
        continue;
      /* here we have a multiversion solvable that doesn't conflict */
      /* thus we're not in conflict if it is installed */
      queue_push(&q, p);
    }
  if (q.count == 1)
    n = 0;      /* no other package found, normal conflict handling */
  else
    n = pool_queuetowhatprovides(pool, &q);
  queue_free(&q);
  return n;
}

static inline void
addpkgrule(Solver *solv, Id p, Id p2, Id d, int type, Id dep)
{
  if (!solv->ruleinfoq)
    solver_addrule(solv, p, p2, d);
  else
    addpkgruleinfo(solv, p, p2, d, type, dep);
}

#ifdef ENABLE_LINKED_PKGS

static int
addlinks_cmp(const void *ap, const void *bp, void *dp)
{
  Pool *pool = dp;
  Id a = *(Id *)ap;
  Id b = *(Id *)bp;
  Solvable *sa = pool->solvables + a;
  Solvable *sb = pool->solvables + b;
  if (sa->name != sb->name)
    return sa->name - sb->name;
  return sa - sb;
}

static void
addlinks(Solver *solv, Solvable *s, Id req, Queue *qr, Id prv, Queue *qp, Map *m, Queue *workq)
{
  Pool *pool = solv->pool;
  int i;
  if (!qr->count)
    return;
  if (qp->count > 1)
    solv_sort(qp->elements, qp->count, sizeof(Id), addlinks_cmp, pool);
#if 0
  printf("ADDLINKS %s\n -> %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
  for (i = 0; i < qr->count; i++)
    printf("    - %s\n", pool_solvid2str(pool, qr->elements[i]));
  printf(" <- %s\n", pool_dep2str(pool, prv));
  for (i = 0; i < qp->count; i++)
    printf("    - %s\n", pool_solvid2str(pool, qp->elements[i]));
#endif

  if (qr->count == 1)
    addpkgrule(solv, -(s - pool->solvables), qr->elements[0], 0, SOLVER_RULE_PKG_REQUIRES, req);
  else
    addpkgrule(solv, -(s - pool->solvables), 0, pool_queuetowhatprovides(pool, qr), SOLVER_RULE_PKG_REQUIRES, req);
  if (qp->count > 1)
    {
      int j;
      for (i = j = 0; i < qp->count; i = j)
        {
          Id d = pool->solvables[qp->elements[i]].name;
          for (j = i + 1; j < qp->count; j++)
            if (d != pool->solvables[qp->elements[j]].name)
              break;
          d = pool_ids2whatprovides(pool, qp->elements + i, j - i);
          for (i = 0; i < qr->count; i++)
            addpkgrule(solv, -qr->elements[i], 0, d, SOLVER_RULE_PKG_REQUIRES, prv);
        }
    }
  else if (qp->count)
    {
      for (i = 0; i < qr->count; i++)
        addpkgrule(solv, -qr->elements[i], qp->elements[0], 0, SOLVER_RULE_PKG_REQUIRES, prv);
    }
  if (!m)
    return;     /* nothing more to do if called from getpkgruleinfos() */
  for (i = 0; i < qr->count; i++)
    if (!MAPTST(m, qr->elements[i]))
      queue_push(workq, qr->elements[i]);
  for (i = 0; i < qp->count; i++)
    if (!MAPTST(m, qp->elements[i]))
      queue_push(workq, qp->elements[i]);
  if (solv->installed && s->repo == solv->installed)
    {
      Repo *installed = solv->installed;
      /* record installed buddies */
      if (!solv->instbuddy)
        solv->instbuddy = solv_calloc(installed->end - installed->start, sizeof(Id));
      if (qr->count == 1)
        solv->instbuddy[s - pool->solvables - installed->start] = qr->elements[0];
      for (i = 0; i < qr->count; i++)
        {
          Id p = qr->elements[i];
          if (pool->solvables[p].repo != installed)
            continue;   /* huh? */
          if (qp->count > 1 || (solv->instbuddy[p - installed->start] != 0 && solv->instbuddy[p - installed->start] != s - pool->solvables))
            solv->instbuddy[p - installed->start] = 1;  /* 1: ambiguous buddy */
          else
            solv->instbuddy[p - installed->start] = s - pool->solvables;
        }
    }
}

static void
add_package_link(Solver *solv, Solvable *s, Map *m, Queue *workq)
{
  Queue qr, qp;
  Id req = 0, prv = 0;
  queue_init(&qr);
  queue_init(&qp);
  find_package_link(solv->pool, s, &req, &qr, &prv, &qp);
  if (qr.count)
    addlinks(solv, s, req, &qr, prv, &qp, m, workq);
  queue_free(&qr);
  queue_free(&qp);
}

#endif

#ifdef ENABLE_COMPLEX_DEPS

#ifdef SUSE
static inline int
suse_isptf(Pool *pool, Solvable *s)
{
  if (!strncmp("ptf-", pool_id2str(pool, s->name), 4))
    return 1;
  return 0;
}
#endif

static void
add_complex_deprules(Solver *solv, Id p, Id dep, int type, int dontfix, Queue *workq, Map *m)
{
  Pool *pool = solv->pool;
  Repo *installed = solv->installed;
  int i, j, flags;
  Queue bq;

  queue_init(&bq);
  flags = dontfix ? CPLXDEPS_DONTFIX : 0;
  /* CNF expansion for requires, DNF + INVERT expansion for conflicts */
  if (type == SOLVER_RULE_PKG_CONFLICTS)
    flags |= CPLXDEPS_TODNF | CPLXDEPS_EXPAND | CPLXDEPS_INVERT;
#ifdef SUSE
  if (type == SOLVER_RULE_PKG_REQUIRES && suse_isptf(pool, pool->solvables + p))
    flags |= CPLXDEPS_NAME;     /* do not match provides */
#endif

  i = pool_normalize_complex_dep(pool, dep, &bq, flags);
  /* handle special cases */
  if (i == 0)
    {
      if (dontfix)
        {
          POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken dependency %s of installed package %s\n", pool_dep2str(pool, dep), pool_solvid2str(pool, p));
        }
      else
        {
          POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvid2str(pool, p), p, pool_dep2str(pool, dep));
          addpkgrule(solv, -p, 0, 0, type == SOLVER_RULE_PKG_REQUIRES ? SOLVER_RULE_PKG_NOTHING_PROVIDES_DEP : type, dep);
        }
      queue_free(&bq);
      return;
    }
  if (i == 1)
    {
      queue_free(&bq);
      return;
    }

  /* go through all blocks and add a rule for each block */
  for (i = 0; i < bq.count; i++)
    {
      if (!bq.elements[i])
        continue;       /* huh? */
      if (bq.elements[i] == pool->nsolvables)
        {
          /* conventional requires (cannot be a conflicts as they have been expanded) */
          Id *dp = pool->whatprovidesdata + bq.elements[i + 1];
          i += 2;
          if (dontfix)
            {
              for (j = 0; dp[j] != 0; j++)
                if (pool->solvables[dp[j]].repo == installed)
                  break;                /* provider was installed */
              if (!dp[j])
                continue;
            }
          if (type == SOLVER_RULE_PKG_RECOMMENDS && !*dp)
            continue;
          /* check if the rule contains both p and -p */
          for (j = 0; dp[j] != 0; j++)
            if (dp[j] == p)
              break;
          if (dp[j])
            continue;
          addpkgrule(solv, -p, 0, dp - pool->whatprovidesdata, type, dep);
          /* push all non-visited providers on the work queue */
          if (m)
            for (; *dp; dp++)
              if (!MAPTST(m, *dp))
                queue_push(workq, *dp);
          continue;
        }
      if (!bq.elements[i + 1])
        {
          Id p2 = bq.elements[i++];
          /* simple rule with just two literals, we'll add a (-p, p2) rule */
          if (dontfix)
            {
              if (p2 < 0 && pool->solvables[-p2].repo == installed)
                continue;
              if (p2 > 0 && pool->solvables[p2].repo != installed)
                continue;
            }
          if (-p == p2)
            {
              if (type == SOLVER_RULE_PKG_CONFLICTS)
                {
                  if (pool->forbidselfconflicts && !is_otherproviders_dep(pool, dep))
                    addpkgrule(solv, -p, 0, 0, SOLVER_RULE_PKG_SELF_CONFLICT, dep);
                  continue;
                }
              addpkgrule(solv, -p, 0, 0, type, dep);
              continue;
            }
          /* check if the rule contains both p and -p */
          if (p == p2)
            continue;
          addpkgrule(solv, -p, p2, 0, type, dep);
          if (m && p2 > 0 && !MAPTST(m, p2))
            queue_push(workq, p2);
        }
      else
        {
          Id *qele, d;
          int qcnt;

          qele = bq.elements + i;
          qcnt = i;
          while (bq.elements[i])
             i++;
          qcnt = i - qcnt;
          if (dontfix)
            {
              for (j = 0; j < qcnt; j++)
                {
                  if (qele[j] > 0 && pool->solvables[qele[j]].repo == installed)
                    break;
                  if (qele[j] < 0 && pool->solvables[-qele[j]].repo != installed)
                    break;
                }
              if (j == qcnt)
                continue;
            }
          /* add -p to (ordered) rule (overwriting the trailing zero) */
          for (j = 0; ; j++)
            {
              if (j == qcnt || qele[j] > -p)
                {
                  if (j < qcnt)
                    memmove(qele + j + 1, qele + j, (qcnt - j) * sizeof(Id));
                  qele[j] = -p;
                  qcnt++;
                  break;
                }
              if (qele[j] == -p)
                break;
            }
          /* check if the rule contains both p and -p */
          for (j = 0; j < qcnt; j++)
            if (qele[j] == p)
              break;
          if (j < qcnt)
            continue;
          d = pool_ids2whatprovides(pool, qele + 1, qcnt - 1);
          if (solv->ruleinfoq && qele[0] != p)
            {
              int oldcount = solv->ruleinfoq->count;
              addpkgrule(solv, qele[0], 0, d, type, dep);
              /* fixup from element of ruleinfo */
              if (solv->ruleinfoq->count > oldcount && solv->ruleinfoq->elements[oldcount + 1] != p)
                {
                  if (solv->ruleinfoq->elements[oldcount + 2])
                    solv->ruleinfoq->elements[oldcount + 2] = solv->ruleinfoq->elements[oldcount + 1];
                  solv->ruleinfoq->elements[oldcount + 1] = p;
                }
            }
          else
            addpkgrule(solv, qele[0], 0, d, type, dep);
          if (m)
            for (j = 0; j < qcnt; j++)
              if (qele[j] > 0 && !MAPTST(m, qele[j]))
                queue_push(workq, qele[j]);
        }
    }
  queue_free(&bq);
}

#endif

#ifdef ENABLE_CONDA
void
add_conda_constrains_rule(Solver *solv, Id n, Id dep, int dontfix)
{
  Pool *pool = solv->pool;
  Reldep *rd;
  Id p, pp, pdep;
  if (!ISRELDEP(dep))
    return;
  rd = GETRELDEP(pool, dep);
  pdep = pool_whatprovides(pool, dep);
  FOR_PROVIDES(p, pp, rd->name)
    {
      Id p2;
      if (p == n)
        continue;
      if (dontfix && pool->solvables[p].repo == solv->installed)
        continue;
      while ((p2 = pool->whatprovidesdata[pdep]) != 0 && p2 < p)
        pdep++;
      if (p == p2)
        pdep++;
      else
        addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_CONSTRAINS, dep);
    }
}
#endif

/*-------------------------------------------------------------------
 *
 * add dependency rules for solvable
 *
 * s: Solvable for which to add rules
 * m: m[s] = 1 for solvables which have rules, prevent rule duplication
 *
 * Algorithm: 'visit all nodes of a graph'. The graph nodes are
 *  solvables, the edges their dependencies.
 *  Starting from an installed solvable, this will create all rules
 *  representing the graph created by the solvables dependencies.
 *
 * for unfulfilled requirements, conflicts, obsoletes,....
 * add a negative assertion for solvables that are not installable
 *
 * It will also create rules for all solvables referenced by 's'
 *  i.e. descend to all providers of requirements of 's'
 *
 */

void
solver_addpkgrulesforsolvable(Solver *solv, Solvable *s, Map *m)
{
  Pool *pool = solv->pool;
  Repo *installed = solv->installed;

  Queue workq;  /* list of solvables we still have to work on */
  Id workqbuf[64];
  Queue depq;   /* list of pre-req ids to ignore */
  Id depqbuf[16];

  int i;
  int dontfix;          /* ignore dependency errors for installed solvables */
  Id req, *reqp;
  Id con, *conp;
  Id obs, *obsp;
  Id rec, *recp;
  Id sug, *sugp;
  Id p, pp;             /* whatprovides loops */
  Id *dp;               /* ptr to 'whatprovides' */
  Id n;                 /* Id for current solvable 's' */

  queue_init_buffer(&workq, workqbuf, sizeof(workqbuf)/sizeof(*workqbuf));
  queue_push(&workq, s - pool->solvables);      /* push solvable Id to work queue */

  queue_init_buffer(&depq, depqbuf, sizeof(depqbuf)/sizeof(*depqbuf));

  /* loop until there's no more work left */
  while (workq.count)
    {
      /*
       * n: Id of solvable
       * s: Pointer to solvable
       */

      n = queue_shift(&workq);          /* 'pop' next solvable to work on from queue */
      if (m)
        {
          if (MAPTST(m, n))             /* continue if already visited */
            continue;
          MAPSET(m, n);                 /* mark as visited */
        }

      s = pool->solvables + n;

      dontfix = 0;
      if (installed                     /* Installed system available */
          && s->repo == installed       /* solvable is installed */
          && !solv->fixmap_all          /* NOT repair errors in dependency graph */
          && !(solv->fixmap.size && MAPTST(&solv->fixmap, n - installed->start)))
        {
          dontfix = 1;                  /* dont care about broken deps */
        }

      if (!dontfix)
        {
          if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC
                ? pool_disabled_solvable(pool, s)
                : !pool_installable(pool, s))
            {
              POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable\n", pool_solvid2str(pool, n), n);
              addpkgrule(solv, -n, 0, 0, SOLVER_RULE_PKG_NOT_INSTALLABLE, 0);
            }
        }

#ifdef ENABLE_LINKED_PKGS
      /* add pseudo-package <-> real-package links */
      if (has_package_link(pool, s))
        add_package_link(solv, s, m, &workq);
#endif

      /*-----------------------------------------
       * check requires of s
       */

      if (s->requires)
        {
          int filterpre = 0;
          reqp = s->repo->idarraydata + s->requires;
          while ((req = *reqp++) != 0)            /* go through all requires */
            {
              if (req == SOLVABLE_PREREQMARKER)   /* skip the marker */
                {
                  if (installed && s->repo == installed)
                    {
                      solvable_lookup_idarray(s, SOLVABLE_PREREQ_IGNOREINST, &depq);
                      filterpre = depq.count;
                    }
                  continue;
                }
              if (filterpre)
                {
                  /* check if this id is filtered. assumes that depq.count is small */
                  for (i = 0; i < depq.count; i++)
                    if (req == depq.elements[i])
                      break;
                  if (i < depq.count)
                    {
                      POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s: ignoring filtered pre-req dependency %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
                      continue;
                    }
                }

#ifdef ENABLE_COMPLEX_DEPS
              if (pool_is_complex_dep(pool, req))
                {
                  /* we have AND/COND deps, normalize */
                  add_complex_deprules(solv, n, req, SOLVER_RULE_PKG_REQUIRES, dontfix, &workq, m);
                  continue;
                }
#endif

              /* find list of solvables providing 'req' */
              dp = pool_whatprovides_ptr(pool, req);

              if (*dp == SYSTEMSOLVABLE)          /* always installed */
                continue;

              if (dontfix)
                {
                  /* the strategy here is to not insist on dependencies
                   * that are already broken. so if we find one provider
                   * that was already installed, we know that the
                   * dependency was not broken before so we enforce it */
                  for (i = 0; (p = dp[i]) != 0; i++)
                    if (pool->solvables[p].repo == installed)
                      break;            /* found installed provider */
                  if (!p)
                    {
                      /* didn't find an installed provider: previously broken dependency */
                      POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "ignoring broken requires %s of installed package %s\n", pool_dep2str(pool, req), pool_solvable2str(pool, s));
                      continue;
                    }
                }

              if (!*dp)
                {
                  POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "package %s [%d] is not installable (%s)\n", pool_solvid2str(pool, n), n, pool_dep2str(pool, req));
                  addpkgrule(solv, -n, 0, 0, SOLVER_RULE_PKG_NOTHING_PROVIDES_DEP, req);
                  continue;
                }

              for (i = 0; dp[i] != 0; i++)
                if (n == dp[i])
                  break;
              if (dp[i])
                continue;               /* provided by itself, no need to add rule */

              IF_POOLDEBUG (SOLV_DEBUG_RULE_CREATION)
                {
                  POOL_DEBUG(SOLV_DEBUG_RULE_CREATION,"  %s requires %s\n", pool_solvable2str(pool, s), pool_dep2str(pool, req));
                  for (i = 0; dp[i]; i++)
                    POOL_DEBUG(SOLV_DEBUG_RULE_CREATION, "   provided by %s\n", pool_solvid2str(pool, dp[i]));
                }

              /* add 'requires' dependency */
              /* rule: (-requestor|provider1|provider2|...|providerN) */
              addpkgrule(solv, -n, 0, dp - pool->whatprovidesdata, SOLVER_RULE_PKG_REQUIRES, req);

              /* push all non-visited providers on the work queue */
              if (m)
                for (; *dp; dp++)
                  if (!MAPTST(m, *dp))
                    queue_push(&workq, *dp);
            }
        }

      if (s->recommends && solv->strongrecommends)
        {
          int start = solv->nrules;
          solv->lastpkgrule = 0;
          reqp = s->repo->idarraydata + s->recommends;
          while ((req = *reqp++) != 0)            /* go through all recommends */
            {
#ifdef ENABLE_COMPLEX_DEPS
              if (pool_is_complex_dep(pool, req))
                {
                  /* we have AND/COND deps, normalize */
                  add_complex_deprules(solv, n, req, SOLVER_RULE_PKG_RECOMMENDS, dontfix, &workq, m);
                  continue;
                }
#endif
              dp = pool_whatprovides_ptr(pool, req);
              if (*dp == SYSTEMSOLVABLE || !*dp)          /* always installed or not installable */
                continue;
              for (i = 0; dp[i] != 0; i++)
                if (n == dp[i])
                  break;
              if (dp[i])
                continue;               /* provided by itself, no need to add rule */
              addpkgrule(solv, -n, 0, dp - pool->whatprovidesdata, SOLVER_RULE_PKG_RECOMMENDS, req);
              if (m)
                for (; *dp; dp++)
                  if (!MAPTST(m, *dp))
                    queue_push(&workq, *dp);
            }
          if (!solv->ruleinfoq && start < solv->nrules)
            {
              if (!solv->recommendsruleq)
                {
                  solv->recommendsruleq = solv_calloc(1, sizeof(Queue));
                  queue_init(solv->recommendsruleq);
                }
              for (i = start; i < solv->nrules; i++)
                queue_push(solv->recommendsruleq, i);
              solv->lastpkgrule = 0;
            }
        }

#ifdef ENABLE_CONDA
      if (pool->disttype == DISTTYPE_CONDA)
        {
          solvable_lookup_idarray(s, SOLVABLE_CONSTRAINS, &depq);
          for (i = 0; i < depq.count; i++)
            add_conda_constrains_rule(solv, n, depq.elements[i], dontfix);
        }
#endif

      /* that's all we check for src packages */
      if (s->arch == ARCH_SRC || s->arch == ARCH_NOSRC)
        continue;

      /*-----------------------------------------
       * check conflicts of s
       */

      if (s->conflicts)
        {
          int ispatch = 0;

          /* we treat conflicts in patches a bit differen:
           * - nevr matching
           * - multiversion handling
           * XXX: we should really handle this different, looking
           * at the name is a bad hack
           */
          if (!strncmp("patch:", pool_id2str(pool, s->name), 6))
            ispatch = 1;
          conp = s->repo->idarraydata + s->conflicts;
          /* foreach conflicts of 's' */
          while ((con = *conp++) != 0)
            {
#ifdef ENABLE_COMPLEX_DEPS
              if (!ispatch && pool_is_complex_dep(pool, con))
                {
                  /* we have AND/COND deps, normalize */
                  add_complex_deprules(solv, n, con, SOLVER_RULE_PKG_CONFLICTS, dontfix, &workq, m);
                  continue;
                }
#endif
              /* foreach providers of a conflict of 's' */
              FOR_PROVIDES(p, pp, con)
                {
                  if (ispatch && !pool_match_nevr(pool, pool->solvables + p, con))
                    continue;
                  /* dontfix: dont care about conflicts with already installed packs */
                  if (dontfix && pool->solvables[p].repo == installed)
                    continue;
                  if (p == n)           /* p == n: self conflict */
                    {
                      if (!pool->forbidselfconflicts || is_otherproviders_dep(pool, con))
                        continue;
                      addpkgrule(solv, -n, 0, 0, SOLVER_RULE_PKG_SELF_CONFLICT, con);
                      continue;
                    }
                  if (ispatch && solv->multiversion.size && MAPTST(&solv->multiversion, p) && ISRELDEP(con))
                    {
                      /* our patch conflicts with a multiversion package */
                      Id d = makemultiversionconflict(solv, p, con);
                      if (d)
                        {
                          addpkgrule(solv, -n, 0, d, SOLVER_RULE_PKG_CONFLICTS, con);
                          continue;
                        }
                    }
                  if (p == SYSTEMSOLVABLE)
                    p = 0;
                  /* rule: -n|-p: either solvable _or_ provider of conflict */
                  addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_CONFLICTS, con);
                }
            }
        }

      /*-----------------------------------------
       * check obsoletes and implicit obsoletes of a package
       * if ignoreinstalledsobsoletes is not set, we're also checking
       * obsoletes of installed packages (like newer rpm versions)
       */
      if ((!installed || s->repo != installed) || !pool->noinstalledobsoletes)
        {
          int multi = solv->multiversion.size && MAPTST(&solv->multiversion, n);
          int isinstalled = (installed && s->repo == installed);
          if (s->obsoletes && (!multi || solv->keepexplicitobsoletes))
            {
              obsp = s->repo->idarraydata + s->obsoletes;
              /* foreach obsoletes */
              while ((obs = *obsp++) != 0)
                {
                  /* foreach provider of an obsoletes of 's' */
                  FOR_PROVIDES(p, pp, obs)
                    {
                      Solvable *ps = pool->solvables + p;
                      if (p == n)
                        continue;
                      if (isinstalled && dontfix && ps->repo == installed)
                        continue;       /* don't repair installed/installed problems */
                      if (!pool->obsoleteusesprovides /* obsoletes are matched names, not provides */
                          && !pool_match_nevr(pool, ps, obs))
                        continue;
                      if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
                        continue;
                      if (p == SYSTEMSOLVABLE)
                        p = 0;
                      if (!isinstalled)
                        addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_OBSOLETES, obs);
                      else
                        addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_INSTALLED_OBSOLETES, obs);
                    }
                }
            }
          /* check implicit obsoletes
           * for installed packages we only need to check installed/installed problems (and
           * only when dontfix is not set), as the others are picked up when looking at the
           * uninstalled package.
           */
          if (!isinstalled || !dontfix)
            {
              FOR_PROVIDES(p, pp, s->name)
                {
                  Solvable *ps = pool->solvables + p;
                  if (p == n)
                    continue;
                  if (isinstalled && ps->repo != installed)
                    continue;
                  /* we still obsolete packages with same nevra, like rpm does */
                  /* (actually, rpm mixes those packages. yuck...) */
                  if (multi && (s->name != ps->name || s->evr != ps->evr || s->arch != ps->arch))
                    {
                      if (isinstalled || ps->repo != installed)
                        continue;
                      /* also check the installed package for multi-ness */
                      if (MAPTST(&solv->multiversion, p))
                        continue;
                    }
                  if (!pool->implicitobsoleteusesprovides && s->name != ps->name)
                    continue;
                  if (pool->implicitobsoleteusescolors && !pool_colormatch(pool, s, ps))
                    continue;
                  if (p == SYSTEMSOLVABLE)
                    p = 0;
                  if (s->name == ps->name)
                    {
                      /* optimization: do not add the same-name conflict rule if it was
                       * already added when we looked at the other package.
                       * (this assumes pool_colormatch is symmetric) */
                      if (p && m && ps->repo != installed && MAPTST(m, p) &&
                          (ps->arch != ARCH_SRC && ps->arch != ARCH_NOSRC) &&
                          !(solv->multiversion.size && MAPTST(&solv->multiversion, p)))
                        continue;
                      addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_SAME_NAME, 0);
                    }
                  else
                    addpkgrule(solv, -n, -p, 0, SOLVER_RULE_PKG_IMPLICIT_OBSOLETES, s->name);
                }
            }
        }

      if (m && pool->implicitobsoleteusescolors && pool_arch2score(pool, s->arch) > 1)
        {
          unsigned int pa, a = pool_arch2score(pool, s->arch);
          /* check lock-step candidates */
          FOR_PROVIDES(p, pp, s->name)
            {
              Solvable *ps = pool->solvables + p;
              if (s->name != ps->name || s->evr != ps->evr || MAPTST(m, p))
                continue;
              pa = pool_arch2score(pool, ps->arch);
              if (!pa || pa == 1 || pa >= a)
                continue;
              queue_push(&workq, p);
            }
        }

      /*-----------------------------------------
       * add recommends/suggests to the work queue
       */
      if (s->recommends && m)
        {
          recp = s->repo->idarraydata + s->recommends;
          while ((rec = *recp++) != 0)
            {
#ifdef ENABLE_COMPLEX_DEPS
              if (pool_is_complex_dep(pool, rec))
                {
                  pool_add_pos_literals_complex_dep(pool, rec, &workq, m, 0);
                  continue;
                }
#endif
              FOR_PROVIDES(p, pp, rec)
                if (!MAPTST(m, p))
                  queue_push(&workq, p);
            }
        }
      if (s->suggests && m)
        {
          sugp = s->repo->idarraydata + s->suggests;
          while ((sug = *sugp++) != 0)
            {
#ifdef ENABLE_COMPLEX_DEPS
              if (pool_is_complex_dep(pool, sug))
                {
                  pool_add_pos_literals_complex_dep(pool, sug, &workq, m, 0);
                  continue;
                }
#endif
              FOR_PROVIDES(p, pp, sug)
                if (!MAPTST(m, p))
                  queue_push(&workq, p);
            }
        }
    }
  queue_free(&depq);
  queue_free(&workq);
}

#ifdef ENABLE_LINKED_PKGS
void
solver_addpkgrulesforlinked(Solver *solv, Map *m)
{
  Pool *pool = solv->pool;
  Solvable *s;
  int i, j;
  Queue qr;

  queue_init(&qr);
  for (i = 1; i < pool->nsolvables; i++)
    {
      if (MAPTST(m, i))
        continue;
      s = pool->solvables + i;
      if (!s->repo || s->repo == solv->installed)
        continue;
      if (!strchr(pool_id2str(pool, s->name), ':'))
        continue;
      if (!pool_installable(pool, s))
        continue;
      find_package_link(pool, s, 0, &qr, 0, 0);
      if (qr.count)
        {
          for (j = 0; j < qr.count; j++)
            if (MAPTST(m, qr.elements[j]))
              {
                solver_addpkgrulesforsolvable(solv, s, m);
                break;
              }
          queue_empty(&qr);
        }
    }
  queue_free(&qr);
}
#endif

/*-------------------------------------------------------------------
 *
 * Add rules for packages possibly selected in by weak dependencies
 *
 * m: already added solvables
 */

void
solver_addpkgrulesforweak(Solver *solv, Map *m)
{
  Pool *pool = solv->pool;
  Solvable *s;
  Id sup, *supp;
  int i, n;

  /* foreach solvable in pool */
  for (i = n = 1; n < pool->nsolvables; i++, n++)
    {
      if (i == pool->nsolvables)                /* wrap i */
        i = 1;
      if (MAPTST(m, i))                         /* already added that one */
        continue;

      s = pool->solvables + i;
      if (!s->repo)
        continue;
      if (s->repo != pool->installed && !pool_installable(pool, s))
        continue;       /* only look at installable ones */

      sup = 0;
      if (s->supplements)
        {
          /* find possible supplements */
          supp = s->repo->idarraydata + s->supplements;
          while ((sup = *supp++) != 0)
            if (solver_dep_possible(solv, sup, m))
              break;
        }

      /* if nothing found, check for enhances */
      if (!sup && s->enhances)
        {
          supp = s->repo->idarraydata + s->enhances;
          while ((sup = *supp++) != 0)
            if (solver_dep_possible(solv, sup, m))
              break;
        }
      /* if nothing found, goto next solvables */
      if (!sup)
        continue;
      solver_addpkgrulesforsolvable(solv, s, m);
      n = 0;                    /* check all solvables again because we added solvables to m */
    }
}


/*-------------------------------------------------------------------
 *
 * add package rules for possible updates
 *
 * s: solvable
 * m: map of already visited solvables
 * allow_all: 0 = dont allow downgrades, 1 = allow all candidates
 */

void
solver_addpkgrulesforupdaters(Solver *solv, Solvable *s, Map *m, int allow_all)
{
  Pool *pool = solv->pool;
  int i;
    /* queue and buffer for it */
  Queue qs;
  Id qsbuf[64];

  queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
    /* find update candidates for 's' */
  policy_findupdatepackages(solv, s, &qs, allow_all);
    /* add rule for 's' if not already done */
  if (!MAPTST(m, s - pool->solvables))
    solver_addpkgrulesforsolvable(solv, s, m);
    /* foreach update candidate, add rule if not already done */
  for (i = 0; i < qs.count; i++)
    if (!MAPTST(m, qs.elements[i]))
      solver_addpkgrulesforsolvable(solv, pool->solvables + qs.elements[i], m);
  queue_free(&qs);
}


/***********************************************************************
 ***
 ***  Update/Feature rule part
 ***
 ***  Those rules make sure an installed package isn't silently deleted
 ***
 ***/

static int
dup_maykeepinstalled(Solver *solv, Solvable *s)
{
  Pool *pool = solv->pool;
  Id ip, pp;

  if (solv->dupmap.size && MAPTST(&solv->dupmap,  s - pool->solvables))
    return 1;
  /* is installed identical to a good one? */
  FOR_PROVIDES(ip, pp, s->name)
    {
      Solvable *is = pool->solvables + ip;
      if (is->evr != s->evr)
        continue;
      if (solv->dupmap.size)
        {
          if (!MAPTST(&solv->dupmap, ip))
            continue;
        }
      else if (is->repo == pool->installed)
        continue;
      if (solvable_identical(s, is))
        return 1;
    }
  return 0;
}


/* stash away the original updaters for multiversion packages. We do this so that
 * we can update the package later */
static inline void
set_specialupdaters(Solver *solv, Solvable *s, Id d)
{
  Repo *installed = solv->installed;
  if (!solv->specialupdaters)
    solv->specialupdaters = solv_calloc(installed->end - installed->start, sizeof(Id));
  solv->specialupdaters[s - solv->pool->solvables - installed->start] = d;
}

#ifdef ENABLE_LINKED_PKGS
/* Check if this is a linked pseudo package. As it is linked, we do not need an update/feature rule */
static inline int
is_linked_pseudo_package(Solver *solv, Solvable *s)
{
  Pool *pool = solv->pool;
  if (solv->instbuddy && solv->instbuddy[s - pool->solvables - solv->installed->start])
    {
      const char *name = pool_id2str(pool, s->name);
      if (strncmp(name, "pattern:", 8) == 0 || strncmp(name, "application:", 12) == 0)
        return 1;
    }
  return 0;
}
#endif

void
solver_addfeaturerule(Solver *solv, Solvable *s)
{
  Pool *pool = solv->pool;
  int i;
  Id p;
  Queue qs;
  Id qsbuf[64];

#ifdef ENABLE_LINKED_PKGS
  if (is_linked_pseudo_package(solv, s))
    {
      solver_addrule(solv, 0, 0, 0);    /* no feature rules for those */
      return;
    }
#endif
  queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
  p = s - pool->solvables;
  policy_findupdatepackages(solv, s, &qs, 1);
  if (solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
    {
      if (!dup_maykeepinstalled(solv, s))
        {
          for (i = 0; i < qs.count; i++)
            {
              Solvable *ns = pool->solvables + qs.elements[i];
              if (ns->repo != pool->installed || dup_maykeepinstalled(solv, ns))
                break;
            }
          if (i == qs.count)
            {
              solver_addrule(solv, 0, 0, 0);    /* this is an orphan */
              queue_free(&qs);
              return;
            }
        }
    }
  if (qs.count > 1)
    {
      Id d = pool_queuetowhatprovides(pool, &qs);
      queue_free(&qs);
      solver_addrule(solv, p, 0, d);    /* allow update of s */
    }
  else
    {
      Id d = qs.count ? qs.elements[0] : 0;
      queue_free(&qs);
      solver_addrule(solv, p, d, 0);    /* allow update of s */
    }
}

/* check if multiversion solvable s2 has an obsoletes for installed solvable s */
static int
is_multiversion_obsoleteed(Pool *pool, Solvable *s, Solvable *s2)
{
  Id *wp, obs, *obsp;

  if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
    return 0;
  obsp = s2->repo->idarraydata + s2->obsoletes;
  if (!pool->obsoleteusesprovides)
    {
      while ((obs = *obsp++) != 0)
        if (pool_match_nevr(pool, s, obs))
          return 1;
    }
  else
    {
      while ((obs = *obsp++) != 0)
        for (wp = pool_whatprovides_ptr(pool, obs); *wp; wp++)
          if (pool->solvables + *wp == s)
            return 1;
    }
  return 0;
}

/*-------------------------------------------------------------------
 *
 * add rule for update
 *   (A|A1|A2|A3...)  An = update candidates for A
 *
 * s = (installed) solvable
 */

void
solver_addupdaterule(Solver *solv, Solvable *s)
{
  /* installed packages get a special upgrade allowed rule */
  Pool *pool = solv->pool;
  Id p, d;
  Queue qs;
  Id qsbuf[64];
  Rule *r;
  int dupinvolved = 0;

  p = s - pool->solvables;

  if (pool->considered && pool_disabled_solvable(pool, s))
    {
      /* disabled installed solvables must stay installed */
      solver_addrule(solv, p, 0, 0);
      return;
    }

  /* Orphan detection. We cheat by looking at the feature rule, which
   * we already calculated */
  r = solv->rules + solv->featurerules + (p - solv->installed->start);
  if (!r->p)
    {
#ifdef ENABLE_LINKED_PKGS
      if (is_linked_pseudo_package(solv, s))
        {
          solver_addrule(solv, 0, 0, 0);
          return;
        }
#endif
      p = 0;
      queue_push(&solv->orphaned, s - pool->solvables);         /* an orphaned package */
      if (solv->keep_orphans && !(solv->droporphanedmap_all || (solv->droporphanedmap.size && MAPTST(&solv->droporphanedmap, s - pool->solvables - solv->installed->start))))
        p = s - pool->solvables;        /* keep this orphaned package installed */
      solver_addrule(solv, p, 0, 0);
      return;
    }

  /* find update candidates for 's' */
  queue_init_buffer(&qs, qsbuf, sizeof(qsbuf)/sizeof(*qsbuf));
  dupinvolved = solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p));
  policy_findupdatepackages(solv, s, &qs, dupinvolved ? 2 : 0);

  if (qs.count && solv->multiversion.size)
    {
      int i, j;

      for (i = 0; i < qs.count; i++)
        if (MAPTST(&solv->multiversion, qs.elements[i]))
          break;
      if (i < qs.count)
        {
          /* filter out all multiversion packages as they don't update */
          d = pool_queuetowhatprovides(pool, &qs);      /* save qs away */
          for (j = i; i < qs.count; i++)
             {
              if (MAPTST(&solv->multiversion, qs.elements[i]))
                {
                  Solvable *ps = pool->solvables + qs.elements[i];
                  /* check if there is an explicit obsoletes */
                  if (solv->keepexplicitobsoletes && ps->obsoletes && is_multiversion_obsoleteed(pool, s, ps))
                    {
                      qs.elements[j++] = qs.elements[i];
                      continue;
                    }
                  /* it's ok if they have same nevra */
                  if (ps->name != s->name || ps->evr != s->evr || ps->arch != s->arch)
                    continue;
                }
              qs.elements[j++] = qs.elements[i];
            }

          if (j == 0 && dupinvolved && !dup_maykeepinstalled(solv, s))
            {
              /* this is a multiversion orphan */
              queue_push(&solv->orphaned, p);
              set_specialupdaters(solv, s, d);
              if (solv->keep_orphans && !(solv->droporphanedmap_all || (solv->droporphanedmap.size && MAPTST(&solv->droporphanedmap, p - solv->installed->start))))
                {
                  /* we need to keep the orphan */
                  queue_free(&qs);
                  solver_addrule(solv, p, 0, 0);
                  return;
                }
              /* we can drop it as long as we update */
              j = qs.count;
            }

          if (j < qs.count)             /* filtered at least one package? */
            {
              if (d && (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, p - solv->installed->start))))
                {
                  /* non-orphan multiversion package, set special updaters if we want an update */
                  set_specialupdaters(solv, s, d);
                }
              qs.count = j;
            }
          else
            {
              /* could fallthrough, but then we would do pool_queuetowhatprovides twice */
              queue_free(&qs);
              solver_addrule(solv, p, 0, d);    /* allow update of s */
              return;
            }
        }
    }
  if (qs.count > 1)
    {
      d = pool_queuetowhatprovides(pool, &qs);
      queue_free(&qs);
      solver_addrule(solv, p, 0, d);    /* allow update of s */
    }
  else
    {
      d = qs.count ? qs.elements[0] : 0;
      queue_free(&qs);
      solver_addrule(solv, p, d, 0);    /* allow update of s */
    }
}

static inline void
disableupdaterule(Solver *solv, Id p)
{
  Rule *r;

  MAPSET(&solv->noupdate, p - solv->installed->start);
  r = solv->rules + solv->updaterules + (p - solv->installed->start);
  if (r->p && r->d >= 0)
    solver_disablerule(solv, r);
  r = solv->rules + solv->featurerules + (p - solv->installed->start);
  if (r->p && r->d >= 0)
    solver_disablerule(solv, r);
  if (solv->bestrules_info)
    {
      int i, ni;
      ni = solv->bestrules_end - solv->bestrules;
      for (i = solv->bestrules_up - solv->bestrules; i < ni; i++)
        if (solv->bestrules_info[i] == p)
          solver_disablerule(solv, solv->rules + solv->bestrules + i);
    }
}

static inline void
reenableupdaterule(Solver *solv, Id p)
{
  Pool *pool = solv->pool;
  Rule *r;

  MAPCLR(&solv->noupdate, p - solv->installed->start);
  r = solv->rules + solv->updaterules + (p - solv->installed->start);
  if (r->p)
    {
      if (r->d < 0)
        {
          solver_enablerule(solv, r);
          IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
            {
              POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
              solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
            }
        }
    }
  else
    {
      r = solv->rules + solv->featurerules + (p - solv->installed->start);
      if (r->p && r->d < 0)
        {
          solver_enablerule(solv, r);
          IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
            {
              POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
              solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
            }
        }
    }
  if (solv->bestrules_info)
    {
      int i, ni;
      ni = solv->bestrules_end - solv->bestrules;
      for (i = solv->bestrules_up - solv->bestrules; i < ni; i++)
        if (solv->bestrules_info[i] == p)
          solver_enablerule(solv, solv->rules + solv->bestrules + i);
    }
}


/***********************************************************************
 ***
 ***  Infarch rule part
 ***
 ***  Infarch rules make sure the solver uses the best architecture of
 ***  a package if multiple archetectures are available
 ***
 ***/

void
solver_addinfarchrules(Solver *solv, Map *addedmap)
{
  Pool *pool = solv->pool;
  Repo *installed = pool->installed;
  int first, i, j;
  Id p, pp, aa;
  unsigned int a, bestscore;
  Solvable *s, *ps, *bests;
  Queue badq, allowedarchs;
  Queue lsq;

  queue_init(&badq);
  queue_init(&allowedarchs);
  queue_init(&lsq);
  solv->infarchrules = solv->nrules;
  for (i = 1; i < pool->nsolvables; i++)
    {
      if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
        continue;
      s = pool->solvables + i;
      first = i;
      bestscore = 0;
      bests = 0;
      queue_empty(&allowedarchs);
      FOR_PROVIDES(p, pp, s->name)
        {
          ps = pool->solvables + p;
          if (ps->name != s->name || !MAPTST(addedmap, p))
            continue;
          if (p == i)
            first = 0;
          if (first)
            break;
          a = pool_arch2score(pool, ps->arch);
          if (a != 1 && installed && ps->repo == installed)
            {
              if (solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
                continue;
              queue_pushunique(&allowedarchs, ps->arch);        /* also ok to keep this architecture */
              continue;         /* but ignore installed solvables when calculating the best arch */
            }
          if (a && a != 1 && (!bestscore || a < bestscore))
            {
              bestscore = a;
              bests = ps;
            }
        }
      if (first)
        continue;               /* not the first in the group */

      if (!bestscore && allowedarchs.count > 1 && pool->implicitobsoleteusescolors)
        {
          for (j = 0; j < allowedarchs.count; j++)
            {
              a = pool_arch2score(pool, allowedarchs.elements[j]);
              if (a && a != 1 && (!bestscore || a < bestscore))
                bestscore = a;
            }
        }

      if (!bestscore)
        continue;               /* did not find a score for this group */

      /* speed up common case where installed package already has best arch */
      if (allowedarchs.count == 1 && bests && allowedarchs.elements[0] == bests->arch)
        allowedarchs.count--;   /* installed arch is best */

      if (allowedarchs.count && pool->implicitobsoleteusescolors && installed)
        {
          /* need an extra pass for lockstep checking: we only allow to keep an inferior arch
           * if the corresponding installed package is not lock-stepped */
          queue_empty(&allowedarchs);
          FOR_PROVIDES(p, pp, s->name)
            {
              Id p2, pp2;
              ps = pool->solvables + p;
              if (ps->name != s->name || ps->repo != installed || !MAPTST(addedmap, p))
                continue;
              if (solv->dupinvolvedmap_all || (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p)))
                continue;
              a = pool_arch2score(pool, ps->arch);
              if (!a)
                {
                  queue_pushunique(&allowedarchs, ps->arch);    /* strange arch, allow */
                  continue;
                }
              if (a == 1 || ((a ^ bestscore) & 0xffff0000) == 0)
                continue;
              /* have installed package with inferior arch, check if lock-stepped */
              FOR_PROVIDES(p2, pp2, s->name)
                {
                  Solvable *s2 = pool->solvables + p2;
                  unsigned int a2;
                  if (p2 == p || s2->name != s->name || s2->evr != pool->solvables[p].evr || s2->arch == pool->solvables[p].arch)
                    continue;
                  a2 = pool_arch2score(pool, s2->arch);
                  if (a2 && (a2 == 1 || ((a2 ^ bestscore) & 0xffff0000) == 0))
                    break;
                }
              if (!p2)
                queue_pushunique(&allowedarchs, ps->arch);
            }
        }

      /* find all bad packages */
      queue_empty(&badq);
      FOR_PROVIDES(p, pp, s->name)
        {
          ps = pool->solvables + p;
          if (ps->name != s->name || !MAPTST(addedmap, p))
            continue;
          a = pool_arch2score(pool, ps->arch);
          if (a != 1 && ((a ^ bestscore) & 0xffff0000) != 0)
            {
              if (installed && ps->repo == installed)
                {
                  if (pool->implicitobsoleteusescolors)
                    queue_push(&badq, p);               /* special lock-step handling, see below */
                  continue;     /* always ok to keep an installed package */
                }
              for (j = 0; j < allowedarchs.count; j++)
                {
                  unsigned int aas;
                  aa = allowedarchs.elements[j];
                  if (ps->arch == aa)
                    break;
                  aas = pool_arch2score(pool, aa);
                  if (aas && ((a ^ aas) & 0xffff0000) == 0)
                    break;      /* compatible */
                }
              if (j == allowedarchs.count)
                queue_push(&badq, p);
            }
        }

      /* block all solvables in the badq! */
      for (j = 0; j < badq.count; j++)
        {
          p = badq.elements[j];
          /* special lock-step handling */
          if (pool->implicitobsoleteusescolors)
            {
              Id p2;
              int haveinstalled = 0;
              queue_empty(&lsq);
              FOR_PROVIDES(p2, pp, s->name)
                {
                  Solvable *s2 = pool->solvables + p2;
                  if (p2 == p || s2->name != s->name || s2->evr != pool->solvables[p].evr || s2->arch == pool->solvables[p].arch)
                    continue;
                  a = pool_arch2score(pool, s2->arch);
                  if (a && (a == 1 || ((a ^ bestscore) & 0xffff000) == 0))
                    {
                      queue_push(&lsq, p2);
                      if (installed && s2->repo == installed)
                        haveinstalled = 1;
                    }
                }
              if (installed && pool->solvables[p].repo == installed && !haveinstalled)
                continue;       /* installed package not in lock-step */
              if (lsq.count < 2)
                solver_addrule(solv, -p, lsq.count ? lsq.elements[0] : 0, 0);
              else
                solver_addrule(solv, -p, 0, pool_queuetowhatprovides(pool, &lsq));
            }
          else
            {
              solver_addrule(solv, -p, 0, 0);
            }
        }
    }
  queue_free(&lsq);
  queue_free(&badq);
  queue_free(&allowedarchs);
  solv->infarchrules_end = solv->nrules;
}

static inline void
disableinfarchrule(Solver *solv, Id name)
{
  Pool *pool = solv->pool;
  Rule *r;
  int i;
  for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
    {
      if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
        solver_disablerule(solv, r);
    }
}

static inline void
reenableinfarchrule(Solver *solv, Id name)
{
  Pool *pool = solv->pool;
  Rule *r;
  int i;
  for (i = solv->infarchrules, r = solv->rules + i; i < solv->infarchrules_end; i++, r++)
    {
      if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
        {
          solver_enablerule(solv, r);
          IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
            {
              POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
              solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
            }
        }
    }
}


/***********************************************************************
 ***
 ***  Dup rule part
 ***
 ***  Dup rules make sure a package is selected from the specified dup
 ***  repositories if an update candidate is included in one of them.
 ***
 ***/

static inline void
add_cleandeps_updatepkg(Solver *solv, Id p)
{
  if (!solv->cleandeps_updatepkgs)
    {
      solv->cleandeps_updatepkgs = solv_calloc(1, sizeof(Queue));
      queue_init(solv->cleandeps_updatepkgs);
    }
  queue_pushunique(solv->cleandeps_updatepkgs, p);
}

static void
solver_addtodupmaps(Solver *solv, Id p, Id how, int targeted)
{
  Pool *pool = solv->pool;
  Solvable *ps, *s = pool->solvables + p;
  Repo *installed = solv->installed;
  Id pi, pip, obs, *obsp;

  if (!solv->dupinvolvedmap.size)
    map_grow(&solv->dupinvolvedmap, pool->nsolvables);

  MAPSET(&solv->dupinvolvedmap, p);
  if (targeted)
    MAPSET(&solv->dupmap, p);
  FOR_PROVIDES(pi, pip, s->name)
    {
      ps = pool->solvables + pi;
      if (ps->name != s->name)
        continue;
      MAPSET(&solv->dupinvolvedmap, pi);
      if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
        {
          Id *opp, pi2;
          for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
            if (pool->solvables[pi2].repo != installed)
              MAPSET(&solv->dupinvolvedmap, pi2);
        }
      if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0 && !solv->bestupdatemap_all)
        {
          if (!solv->bestupdatemap.size)
            map_grow(&solv->bestupdatemap, installed->end - installed->start);
          MAPSET(&solv->bestupdatemap, pi - installed->start);
        }
      if (ps->repo == installed && (how & SOLVER_CLEANDEPS) != 0)
        add_cleandeps_updatepkg(solv, pi);
      if (!targeted && ps->repo != installed)
        MAPSET(&solv->dupmap, pi);
    }
  if (s->repo == installed && solv->obsoletes && solv->obsoletes[p - installed->start])
    {
      Id *opp;
      for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (pi = *opp++) != 0;)
        {
          ps = pool->solvables + pi;
          if (ps->repo == installed)
            continue;
          MAPSET(&solv->dupinvolvedmap, pi);
          if (!targeted)
            MAPSET(&solv->dupmap, pi);
        }
    }
  if (targeted && s->repo != installed && s->obsoletes)
    {
      /* XXX: check obsoletes/provides combination */
      obsp = s->repo->idarraydata + s->obsoletes;
      while ((obs = *obsp++) != 0)
        {
          FOR_PROVIDES(pi, pip, obs)
            {
              Solvable *ps = pool->solvables + pi;
              if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, ps, obs))
                continue;
              if (pool->obsoleteusescolors && !pool_colormatch(pool, s, ps))
                continue;
              MAPSET(&solv->dupinvolvedmap, pi);
              if (targeted && ps->repo == installed && solv->obsoletes && solv->obsoletes[pi - installed->start])
                {
                  Id *opp, pi2;
                  for (opp = solv->obsoletes_data + solv->obsoletes[pi - installed->start]; (pi2 = *opp++) != 0;)
                    if (pool->solvables[pi2].repo != installed)
                      MAPSET(&solv->dupinvolvedmap, pi2);
                }
              if (ps->repo == installed && (how & SOLVER_FORCEBEST) != 0 && !solv->bestupdatemap_all)
                {
                  if (!solv->bestupdatemap.size)
                    map_grow(&solv->bestupdatemap, installed->end - installed->start);
                  MAPSET(&solv->bestupdatemap, pi - installed->start);
                }
              if (ps->repo == installed && (how & SOLVER_CLEANDEPS) != 0)
                add_cleandeps_updatepkg(solv, pi);
            }
        }
    }
}

/* create the two dupmaps:
 * - dupmap: packages in that map are good to install/keep
 * - dupinvolvedmap: packages are subject to dup mode
 */
void
solver_createdupmaps(Solver *solv)
{
  Pool *pool = solv->pool;
  Queue *job = &solv->job;
  Repo *installed = solv->installed;
  Id select, how, what, p, pp;
  Solvable *s;
  int i, targeted;

  map_init(&solv->dupmap, pool->nsolvables);
  solv->dupinvolvedmap_all = 0;
  map_init(&solv->dupinvolvedmap, 0);
  for (i = 0; i < job->count; i += 2)
    {
      how = job->elements[i];
      select = job->elements[i] & SOLVER_SELECTMASK;
      what = job->elements[i + 1];
      switch (how & SOLVER_JOBMASK)
        {
        case SOLVER_DISTUPGRADE:
          if (select == SOLVER_SOLVABLE_REPO)
            {
              Repo *repo;
              if (what <= 0 || what > pool->nrepos)
                break;
              repo = pool_id2repo(pool, what);
              if (!repo)
                break;
              if (repo != installed && !(how & SOLVER_TARGETED) && solv->noautotarget)
                break;
              targeted = repo != installed || (how & SOLVER_TARGETED) != 0;
              FOR_REPO_SOLVABLES(repo, p, s)
                {
                  if (repo != installed && !pool_installable(pool, s))
                    continue;
                  solver_addtodupmaps(solv, p, how, targeted);
                }
            }
          else if (select == SOLVER_SOLVABLE_ALL)
            {
              solv->dupinvolvedmap_all = 1;
              FOR_POOL_SOLVABLES(p)
                {
                  Solvable *s = pool->solvables + p;
                  if (!s->repo || s->repo == installed)
                    continue;
                  if (!pool_installable(pool, s))
                    continue;
                  MAPSET(&solv->dupmap, p);
                }
              if ((how & SOLVER_FORCEBEST) != 0)
                solv->bestupdatemap_all = 1;
              if ((how & SOLVER_CLEANDEPS) != 0 && installed)
                {
                  FOR_REPO_SOLVABLES(installed, p, s)
                    add_cleandeps_updatepkg(solv, p);
                }
            }
          else
            {
              targeted = how & SOLVER_TARGETED ? 1 : 0;
              if (installed && !targeted && !solv->noautotarget)
                {
                  FOR_JOB_SELECT(p, pp, select, what)
                    if (pool->solvables[p].repo == installed)
                      break;
                  targeted = p == 0;
                }
              else if (!installed && !solv->noautotarget)
                targeted = 1;
              FOR_JOB_SELECT(p, pp, select, what)
                {
                  Solvable *s = pool->solvables + p;
                  if (!s->repo)
                    continue;
                  if (s->repo != installed && !targeted)
                    continue;
                  if (s->repo != installed && !pool_installable(pool, s))
                    continue;
                  solver_addtodupmaps(solv, p, how, targeted);
                }
            }
          break;
        default:
          break;
        }
    }
  if (solv->dupinvolvedmap.size)
    MAPCLR(&solv->dupinvolvedmap, SYSTEMSOLVABLE);
  /* set update for all involved installed packages. We need to do
   * this before creating the update rules */
  if (solv->dupinvolvedmap_all)
    solv->updatemap_all = 1;
  else if (installed && !solv->updatemap_all && solv->dupinvolvedmap.size)
    {
      FOR_REPO_SOLVABLES(installed, p, s)
        {
          if (!MAPTST(&solv->dupinvolvedmap, p))
            continue;
          if (!solv->updatemap.size)
            map_grow(&solv->updatemap, installed->end - installed->start);
          MAPSET(&solv->updatemap, p - installed->start);
        }
    }
}

void
solver_freedupmaps(Solver *solv)
{
  map_free(&solv->dupmap);
  /* we no longer free solv->dupinvolvedmap as we need it in
   * policy's priority pruning code. sigh. */
}

void
solver_addduprules(Solver *solv, Map *addedmap)
{
  Pool *pool = solv->pool;
  Repo *installed = solv->installed;
  Id p, pp;
  Solvable *s, *ps;
  int first, i;
  Rule *r;

  solv->duprules = solv->nrules;
  for (i = 1; i < pool->nsolvables; i++)
    {
      if (i == SYSTEMSOLVABLE || !MAPTST(addedmap, i))
        continue;
      s = pool->solvables + i;
      first = i;
      FOR_PROVIDES(p, pp, s->name)
        {
          ps = pool->solvables + p;
          if (ps->name != s->name || !MAPTST(addedmap, p))
            continue;
          if (p == i)
            first = 0;
          if (first)
            break;
          if (!solv->dupinvolvedmap_all && !MAPTST(&solv->dupinvolvedmap, p))
            continue;
          if (installed && ps->repo == installed)
            {
              if (pool->considered && pool_disabled_solvable(pool, ps))
                continue;               /* always keep disabled installed packages */
              if (!MAPTST(&solv->dupmap, p))
                {
                  Id ip, ipp;
                  /* is installed identical to a good one? */
                  FOR_PROVIDES(ip, ipp, ps->name)
                    {
                      Solvable *is = pool->solvables + ip;
                      if (!MAPTST(&solv->dupmap, ip))
                        continue;
                      if (is->evr == ps->evr && solvable_identical(ps, is))
                        break;
                    }
                  if (ip)
                    {
                      /* ok, identical to a good one. we may keep this package. */
                      MAPSET(&solv->dupmap, p);         /* for best rules processing */
                      continue;
                    }
                  /* check if it's orphaned. If yes, we may keep it */
                  r = solv->rules + solv->updaterules + (p - installed->start);
                  if (!r->p)
                    r = solv->rules + solv->featurerules + (p - installed->start);
                  if (!r->p)
                    {
                      /* no update/feature rule, this is an orphan */
                      MAPSET(&solv->dupmap, p);         /* for best rules processing */
                      continue;
                    }
                  if (solv->specialupdaters && solv->specialupdaters[p - installed->start])
                    {
                      /* this is a multiversion orphan, we're good if an update is installed */
                      solver_addrule(solv, -p, 0, solv->specialupdaters[p - installed->start]);
                      continue;
                    }
                  if (r->p == p && !r->d && !r->w2)
                    {
                      r = solv->rules + solv->featurerules + (p - installed->start);
                      if (!r->p || (!r->d && !r->w2))
                        {
                          /* this is an orphan */
                          MAPSET(&solv->dupmap, p);             /* for best rules processing */
                          continue;
                        }
                    }
                  solver_addrule(solv, -p, 0, 0);       /* no match, sorry */
                }
            }
          else if (!MAPTST(&solv->dupmap, p))
            solver_addrule(solv, -p, 0, 0);
        }
    }
  solv->duprules_end = solv->nrules;
}


static inline void
disableduprule(Solver *solv, Id name)
{
  Pool *pool = solv->pool;
  Rule *r;
  int i;
  for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
    {
      if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
        solver_disablerule(solv, r);
    }
}

static inline void
reenableduprule(Solver *solv, Id name)
{
  Pool *pool = solv->pool;
  Rule *r;
  int i;
  for (i = solv->duprules, r = solv->rules + i; i < solv->duprules_end; i++, r++)
    {
      if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
        {
          solver_enablerule(solv, r);
          IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
            {
              POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
              solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
            }
        }
    }
}

/***********************************************************************
 ***
 ***  Black rule part
 ***/

static inline void
disableblackrule(Solver *solv, Id p)
{
  Rule *r;
  int i;
  for (i = solv->blackrules, r = solv->rules + i; i < solv->blackrules_end; i++, r++)
    if (r->p == -p)
      solver_disablerule(solv, r);
}

static inline void
reenableblackrule(Solver *solv, Id p)
{
  Pool *pool = solv->pool;
  Rule *r;
  int i;
  for (i = solv->blackrules, r = solv->rules + i; i < solv->blackrules_end; i++, r++)
    if (r->p == -p)
      {
        solver_enablerule(solv, r);
        IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
          {
            POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
            solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
          }
      }
}

void
solver_addblackrules(Solver *solv)
{
  Pool *pool = solv->pool;
  Repo *installed = solv->installed;
  Id how, select, what, p, pp;
  Queue *job = &solv->job;
  Map updatemap;
  int i;

  map_init(&updatemap, 0);
  solv->blackrules = solv->nrules;
  if (installed)
    {
      for (i = 0; i < job->count; i += 2)
        {
          how = job->elements[i];
          select = job->elements[i] & SOLVER_SELECTMASK;
          what = job->elements[i + 1];
          switch (how & SOLVER_JOBMASK)
            {
            case SOLVER_BLACKLIST:
              FOR_JOB_SELECT(p, pp, select, what)
                {
                  Solvable *s = pool->solvables + p;
                  if (s->repo != installed)
                    continue;
                  if (!updatemap.size)
                    map_grow(&updatemap, pool->ss.nstrings);
                  if (s->name > 0 && s->name < pool->ss.nstrings)
                    MAPSET(&updatemap, s->name);
                }
            }
        }
    }
  for (i = 0; i < job->count; i += 2)
    {
      how = job->elements[i];
      select = job->elements[i] & SOLVER_SELECTMASK;
      what = job->elements[i + 1];
      switch (how & SOLVER_JOBMASK)
        {
        case SOLVER_BLACKLIST:
          FOR_JOB_SELECT(p, pp, select, what)
            {
              Solvable *s = pool->solvables + p;
              if (s->repo == installed)
                continue;
              if (updatemap.size && s->name > 0 && s->name < pool->ss.nstrings && MAPTST(&updatemap, s->name))
                continue;       /* installed package with same name is already blacklisted */
              solver_addrule(solv, -p, 0, 0);
            }
          break;
        }
    }
  map_free(&updatemap);
  solv->blackrules_end = solv->nrules;
}

/***********************************************************************
 ***
 ***  Strict repo prio rule part
 ***/

/* add rules to exclude solvables provided by lower
 * precedence repositories */
void solver_addstrictrepopriorules(struct s_Solver *solv, Map *addedmap)
{
  Pool *pool = solv->pool;
  Solvable *s;
  Id p, p2, pp2;
  Map priomap;
  int max_prio;

  map_init_clone(&priomap, addedmap);
  solv->strictrepopriorules = solv->nrules;

  FOR_POOL_SOLVABLES(p)
  {
    if (!MAPTST(&priomap, p))
      continue;

    s = pool->solvables + p;
    max_prio = s->repo->priority;
    FOR_PROVIDES(p2, pp2, s->name)
      {
        Solvable *s2 = pool->solvables + p2;
        if (s->name != s2->name)
          continue;
        if (s2->repo->priority > max_prio)
          max_prio = s2->repo->priority;
      }
          
    FOR_PROVIDES(p2, pp2, s->name)
      {
        Solvable *s2 = pool->solvables + p2;
        if (s->name != s2->name || !MAPTST(&priomap, p2))
          continue;
        MAPCLR(&priomap, p2);
        if (pool->installed && s2->repo == pool->installed)
          continue;
        if (s2->repo->priority < max_prio)
          solver_addrule(solv, -p2, 0, 0);
      }
  }
  solv->strictrepopriorules_end = solv->nrules;
  map_free(&priomap);
}

static inline void
disablerepopriorule(Solver *solv, Id name)
{
  Pool *pool = solv->pool;
  Rule *r;
  int i;
  for (i = solv->strictrepopriorules, r = solv->rules + i; i < solv->strictrepopriorules_end; i++, r++)
    {
      if (r->p < 0 && r->d >= 0 && pool->solvables[-r->p].name == name)
        solver_disablerule(solv, r);
    }
}

static inline void
reenablerepopriorule(Solver *solv, Id name)
{
  Pool *pool = solv->pool;
  Rule *r;
  int i;
  for (i = solv->strictrepopriorules, r = solv->rules + i; i < solv->strictrepopriorules_end; i++, r++)
    {
      if (r->p < 0 && r->d < 0 && pool->solvables[-r->p].name == name)
        {
          solver_enablerule(solv, r);
          IF_POOLDEBUG (SOLV_DEBUG_SOLUTIONS)
            {
              POOL_DEBUG(SOLV_DEBUG_SOLUTIONS, "@@@ re-enabling ");
              solver_printruleclass(solv, SOLV_DEBUG_SOLUTIONS, r);
            }
        }
    }
}

/***********************************************************************
 ***
 ***  Policy rule disabling/reenabling
 ***
 ***  Disable all policy rules that conflict with our jobs. If a job
 ***  gets disabled later on, reenable the involved policy rules again.
 ***
 ***/

#define DISABLE_UPDATE   1
#define DISABLE_INFARCH  2
#define DISABLE_DUP      3
#define DISABLE_BLACK    4
#define DISABLE_REPOPRIO 5

/* check if installed package p is in lock-step with another installed package */
static int
installed_is_in_lockstep(Solver *solv, Id p)
{
  Pool *pool = solv->pool;
  Repo *installed = solv->installed;
  int rid;
  Id pp, l;
  Rule *r;

  if (!installed)
    return 0;
  for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
    {
      if (r->p >= 0)
        continue;
      if (pool->solvables[-r->p].repo != installed)
        continue;
      FOR_RULELITERALS(l, pp, r)
        if (l == p)
          return 1;
    }
  return 0;
}

static void
jobtodisablelist(Solver *solv, Id how, Id what, Queue *q)
{
  Pool *pool = solv->pool;
  Id select, p, pp;
  Repo *installed;
  Solvable *s;
  int i, j, set, qstart;
  Map omap;

  installed = solv->installed;
  select = how & SOLVER_SELECTMASK;
  switch (how & SOLVER_JOBMASK)
    {
    case SOLVER_INSTALL:
      set = how & SOLVER_SETMASK;
      if (!(set & SOLVER_NOAUTOSET))
        {
          /* automatically add set bits by analysing the job */
          if (select == SOLVER_SOLVABLE_NAME)
            set |= SOLVER_SETNAME;
          if (select == SOLVER_SOLVABLE)
            set |= SOLVER_SETNAME | SOLVER_SETARCH | SOLVER_SETVENDOR | SOLVER_SETREPO | SOLVER_SETEVR;
          else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
            {
              Reldep *rd = GETRELDEP(pool, what);
              if (rd->flags == REL_EQ && select == SOLVER_SOLVABLE_NAME)
                {
                  if (pool->disttype != DISTTYPE_DEB)
                    {
                      const char *rel = strrchr(pool_id2str(pool, rd->evr), '-');
                      set |= rel ? SOLVER_SETEVR : SOLVER_SETEV;
                    }
                  else
                    set |= SOLVER_SETEVR;
                }
              if (rd->flags <= 7 && ISRELDEP(rd->name))
                rd = GETRELDEP(pool, rd->name);
              if (rd->flags == REL_ARCH)
                set |= SOLVER_SETARCH;
            }
        }
      else
        set &= ~SOLVER_NOAUTOSET;
      if (!set)
        return;
      if ((set & SOLVER_SETARCH) != 0 && solv->infarchrules != solv->infarchrules_end)
        {
          if (select == SOLVER_SOLVABLE)
            {
              for (i = solv->infarchrules; i < solv->infarchrules_end; i++)
                if (solv->rules[i].p == -what)
                  break;
              if (i < solv->infarchrules_end)
                queue_push2(q, DISABLE_INFARCH, pool->solvables[what].name);
            }
          else
            {
              int qcnt = q->count;
              /* does not work for SOLVER_SOLVABLE_ALL and SOLVER_SOLVABLE_REPO, but
                 they are not useful for SOLVER_INSTALL jobs anyway */
              FOR_JOB_SELECT(p, pp, select, what)
                {
                  s = pool->solvables + p;
                  /* unify names */
                  for (i = qcnt; i < q->count; i += 2)
                    if (q->elements[i + 1] == s->name)
                      break;
                  if (i < q->count)
                    continue;           /* already have that DISABLE_INFARCH element */
                  for (i = solv->infarchrules; i < solv->infarchrules_end; i++)
                    if (solv->rules[i].p == -p)
                      break;
                  if (i < solv->infarchrules_end)
                    queue_push2(q, DISABLE_INFARCH, s->name);
                }
            }
        }
      if ((set & SOLVER_SETREPO) != 0 && solv->duprules != solv->duprules_end)
        {
          if (select == SOLVER_SOLVABLE)
            queue_push2(q, DISABLE_DUP, pool->solvables[what].name);
          else
            {
              int qcnt = q->count;
              FOR_JOB_SELECT(p, pp, select, what)
                {
                  s = pool->solvables + p;
                  /* unify names */
                  for (i = qcnt; i < q->count; i += 2)
                    if (q->elements[i + 1] == s->name)
                      break;
                  if (i < q->count)
                    continue;
                  queue_push2(q, DISABLE_DUP, s->name);
                }
            }
        }
      if ((set & SOLVER_SETREPO) != 0 && solv->strictrepopriorules != solv->strictrepopriorules_end)
        {
          if (select == SOLVER_SOLVABLE)
            queue_push2(q, DISABLE_REPOPRIO, pool->solvables[what].name);
          else
            {
              int qcnt = q->count;
              FOR_JOB_SELECT(p, pp, select, what)
                {
                  s = pool->solvables + p;
                  /* unify names */
                  for (i = qcnt; i < q->count; i += 2)
                    if (q->elements[i + 1] == s->name)
                      break;
                  if (i < q->count)
                    continue;
                  queue_push2(q, DISABLE_REPOPRIO, s->name);
                }
            }
        }
      if ((set & SOLVER_SETEVR) != 0 && solv->blackrules != solv->blackrules_end)
        {
          if (select == SOLVER_SOLVABLE)
            queue_push2(q, DISABLE_BLACK, what);
          else
            {
              FOR_JOB_SELECT(p, pp, select, what)
                queue_push2(q, DISABLE_BLACK, p);
            }
        }
      if (!installed || installed->end == installed->start)
        return;
      /* now the hard part: disable some update rules */

      /* if the job asks for a single solvable to stay, disable the update rule */
      if (select == SOLVER_SOLVABLE && pool->solvables[what].repo == installed && solv->bestrules_info)
        if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
          {
            int ni = solv->bestrules_end - solv->bestrules;
            for (i = solv->bestrules_up - solv->bestrules; i < ni; i++)
              if (solv->bestrules_info[i] == what)
                {
                  queue_push2(q, DISABLE_UPDATE, what);         /* will also disable the best rule */
                  break;
                }
            return;
          }

      /* first check if we have installed or multiversion packages in the job */
      FOR_JOB_SELECT(p, pp, select, what)
        {
          if (pool->solvables[p].repo == installed)
            return;
          if (solv->multiversion.size && MAPTST(&solv->multiversion, p) && !solv->keepexplicitobsoletes)
            return;             /* will not obsolete anything, so just return */
        }
      omap.size = 0;
      qstart = q->count;
      FOR_JOB_SELECT(p, pp, select, what)
        {
          solver_intersect_obsoleted(solv, p, q, qstart, &omap);
          if (q->count == qstart)
            break;
        }
      if (omap.size)
        map_free(&omap);

      if (qstart == q->count)
        return;         /* nothing to prune */

      /* convert result to (DISABLE_UPDATE, p) pairs */
      i = q->count;
      for (j = qstart; j < i; j++)
        queue_push(q, q->elements[j]);
      for (j = qstart; j < q->count; j += 2)
        {
          q->elements[j] = DISABLE_UPDATE;
          q->elements[j + 1] = q->elements[i++];
        }

      /* now that we know which installed packages are obsoleted check each of them */
      if ((set & (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR)) == (SOLVER_SETEVR | SOLVER_SETARCH | SOLVER_SETVENDOR))
        return;         /* all is set, nothing to do */

      for (i = j = qstart; i < q->count; i += 2)
        {
          Solvable *is = pool->solvables + q->elements[i + 1];
          FOR_JOB_SELECT(p, pp, select, what)
            {
              int illegal = 0;
              s = pool->solvables + p;
              if ((set & SOLVER_SETEVR) != 0)
                illegal |= POLICY_ILLEGAL_DOWNGRADE;    /* ignore */
              if ((set & SOLVER_SETNAME) != 0)
                illegal |= POLICY_ILLEGAL_NAMECHANGE;   /* ignore */
              if ((set & SOLVER_SETARCH) != 0)
                illegal |= POLICY_ILLEGAL_ARCHCHANGE;   /* ignore */
              if ((set & SOLVER_SETVENDOR) != 0)
                illegal |= POLICY_ILLEGAL_VENDORCHANGE; /* ignore */
              illegal = policy_is_illegal(solv, is, s, illegal);
              if (illegal && illegal == POLICY_ILLEGAL_DOWNGRADE && (set & SOLVER_SETEV) != 0)
                {
                  /* it's ok if the EV is different */
                  if (pool_evrcmp(pool, is->evr, s->evr, EVRCMP_COMPARE_EVONLY) != 0)
                    illegal = 0;
                }
              if (illegal)
                break;
            }
          if (!p)
            {   
              /* no package conflicts with the update rule */
              /* thus keep the DISABLE_UPDATE */
              q->elements[j + 1] = q->elements[i + 1];
              j += 2;
            }
        }
      queue_truncate(q, j);
      return;

    case SOLVER_ERASE:
      if (!installed)
        break;
      set = how & SOLVER_SETMASK;
      if (!(set & (SOLVER_NOAUTOSET | SOLVER_SETARCH)) && pool->implicitobsoleteusescolors && solv->infarchrules != solv->infarchrules_end)
        {
          if (select == SOLVER_SOLVABLE)
            set |= SOLVER_SETARCH;
          else if ((select == SOLVER_SOLVABLE_NAME || select == SOLVER_SOLVABLE_PROVIDES) && ISRELDEP(what))
            {
              Reldep *rd = GETRELDEP(pool, what);
              if (rd->flags <= 7 && ISRELDEP(rd->name))
                rd = GETRELDEP(pool, rd->name);
              if (rd->flags == REL_ARCH)
                set |= SOLVER_SETARCH;
            }
        }
      if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
        {
          FOR_REPO_SOLVABLES(installed, p, s)
            queue_push2(q, DISABLE_UPDATE, p);
        }
      FOR_JOB_SELECT(p, pp, select, what)
        if (pool->solvables[p].repo == installed)
          {
            queue_push2(q, DISABLE_UPDATE, p);
            if ((set & SOLVER_SETARCH) != 0 && pool->implicitobsoleteusescolors && solv->infarchrules != solv->infarchrules_end)
              if (installed_is_in_lockstep(solv, p))
                queue_push2(q, DISABLE_INFARCH, pool->solvables[p].name);               /* allow to break the lock-step */
#ifdef ENABLE_LINKED_PKGS
            if (solv->instbuddy && solv->instbuddy[p - installed->start] > 1)
              queue_push2(q, DISABLE_UPDATE, solv->instbuddy[p - installed->start]);
#endif
          }
      return;

    case SOLVER_LOCK:
      if (!installed)
        break;
      qstart = q->count;
      if (select == SOLVER_SOLVABLE_ALL || (select == SOLVER_SOLVABLE_REPO && what == installed->repoid))
        {
          FOR_REPO_SOLVABLES(installed, p, s)
            {
              for (i = qstart; i < q->count; i += 2)
                if (q->elements[i] == DISABLE_DUP && q->elements[i + 1] == pool->solvables[p].name)
                  break;
              if (i == q->count)
                queue_push2(q, DISABLE_DUP, pool->solvables[p].name);
            }
        }
      FOR_JOB_SELECT(p, pp, select, what)
        {
          if (pool->solvables[p].repo != installed)
            continue;
          for (i = qstart; i < q->count; i += 2)
            if (q->elements[i] == DISABLE_DUP && q->elements[i + 1] == pool->solvables[p].name)
              break;
          if (i == q->count)
            queue_push2(q, DISABLE_DUP, pool->solvables[p].name);
        }
      break;

    default:
      return;
    }
}

/* disable all policy rules that are in conflict with our job list */
void
solver_disablepolicyrules(Solver *solv)
{
  Queue *job = &solv->job;
  int i, j;
  Queue allq;
  Rule *r;
  Id lastjob = -1;
  Id allqbuf[128];

  queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));

  for (i = solv->jobrules; i < solv->jobrules_end; i++)
    {
      r = solv->rules + i;
      if (r->d < 0)     /* disabled? */
        continue;
      j = solv->ruletojob.elements[i - solv->jobrules];
      if (j == lastjob)
        continue;
      lastjob = j;
      jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
    }
  if (solv->cleandepsmap.size)
    {
      solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
      for (i = solv->installed->start; i < solv->installed->end; i++)
        if (MAPTST(&solv->cleandepsmap, i - solv->installed->start))
          queue_push2(&allq, DISABLE_UPDATE, i);
    }
  MAPZERO(&solv->noupdate);
  for (i = 0; i < allq.count; i += 2)
    {
      Id type = allq.elements[i], arg = allq.elements[i + 1];
      switch(type)
        {
        case DISABLE_UPDATE:
          disableupdaterule(solv, arg);
          break;
        case DISABLE_INFARCH:
          disableinfarchrule(solv, arg);
          break;
        case DISABLE_DUP:
          disableduprule(solv, arg);
          break;
        case DISABLE_BLACK:
          disableblackrule(solv, arg);
          break;
        case DISABLE_REPOPRIO:
          disablerepopriorule(solv, arg);
          break;
        default:
          break;
        }
    }
  queue_free(&allq);
}

/* we just disabled job #jobidx, now reenable all policy rules that were
 * disabled because of this job */
void
solver_reenablepolicyrules(Solver *solv, int jobidx)
{
  Queue *job = &solv->job;
  int i, j, k, ai;
  Queue q, allq;
  Rule *r;
  Id lastjob = -1;
  Id qbuf[32], allqbuf[32];

  queue_init_buffer(&q, qbuf, sizeof(qbuf)/sizeof(*qbuf));
  jobtodisablelist(solv, job->elements[jobidx - 1], job->elements[jobidx], &q);
  if (!q.count)
    {
      queue_free(&q);
      return;
    }
  /* now remove everything from q that is disabled by other jobs */

  /* first remove cleandeps packages, they count as DISABLE_UPDATE */
  if (solv->cleandepsmap.size)
    {
      solver_createcleandepsmap(solv, &solv->cleandepsmap, 0);
      for (j = k = 0; j < q.count; j += 2)
        {
          if (q.elements[j] == DISABLE_UPDATE)
            {
              Id p = q.elements[j + 1];
              if (p >= solv->installed->start && p < solv->installed->end && MAPTST(&solv->cleandepsmap, p - solv->installed->start))
                continue;       /* remove element from q */
            }
          q.elements[k++] = q.elements[j];
          q.elements[k++] = q.elements[j + 1];
        }
      q.count = k;
      if (!q.count)
        {
          queue_free(&q);
          return;
        }
    }

  /* now go through the disable list of all other jobs */
  queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
  for (i = solv->jobrules; i < solv->jobrules_end; i++)
    {
      r = solv->rules + i;
      if (r->d < 0)     /* disabled? */
        continue;
      j = solv->ruletojob.elements[i - solv->jobrules];
      if (j == lastjob)
        continue;
      lastjob = j;
      jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
      if (!allq.count)
        continue;
      /* remove all elements in allq from q */
      for (j = k = 0; j < q.count; j += 2)
        {
          Id type = q.elements[j], arg = q.elements[j + 1];
          for (ai = 0; ai < allq.count; ai += 2)
            if (allq.elements[ai] == type && allq.elements[ai + 1] == arg)
              break;
          if (ai < allq.count)
            continue;   /* found it in allq, remove element from q */
          q.elements[k++] = q.elements[j];
          q.elements[k++] = q.elements[j + 1];
        }
      q.count = k;
      if (!q.count)
        {
          queue_free(&q);
          queue_free(&allq);
          return;
        }
      queue_empty(&allq);
    }
  queue_free(&allq);

  /* now re-enable anything that's left in q */
  for (j = 0; j < q.count; j += 2)
    {
      Id type = q.elements[j], arg = q.elements[j + 1];
      switch(type)
        {
        case DISABLE_UPDATE:
          reenableupdaterule(solv, arg);
          break;
        case DISABLE_INFARCH:
          reenableinfarchrule(solv, arg);
          break;
        case DISABLE_DUP:
          reenableduprule(solv, arg);
          break;
        case DISABLE_BLACK:
          reenableblackrule(solv, arg);
          break;
        case DISABLE_REPOPRIO:
          reenablerepopriorule(solv, arg);
          break;
        }
    }
  queue_free(&q);
}

/* we just removed a package from the cleandeps map, now reenable all policy rules that were
 * disabled because of this */
void
solver_reenablepolicyrules_cleandeps(Solver *solv, Id pkg)
{
  Queue *job = &solv->job;
  int i, j;
  Queue allq;
  Rule *r;
  Id lastjob = -1;
  Id allqbuf[128];

  queue_init_buffer(&allq, allqbuf, sizeof(allqbuf)/sizeof(*allqbuf));
  for (i = solv->jobrules; i < solv->jobrules_end; i++)
    {
      r = solv->rules + i;
      if (r->d < 0)     /* disabled? */
        continue;
      j = solv->ruletojob.elements[i - solv->jobrules];
      if (j == lastjob)
        continue;
      lastjob = j;
      jobtodisablelist(solv, job->elements[j], job->elements[j + 1], &allq);
    }
  for (i = 0; i < allq.count; i += 2)
    if (allq.elements[i] == DISABLE_UPDATE && allq.elements[i + 1] == pkg)
      break;
  if (i == allq.count)
    reenableupdaterule(solv, pkg);
  queue_free(&allq);
}


/***********************************************************************
 ***
 ***  Rule info part, tell the user what the rule is about.
 ***
 ***/

static void
addpkgruleinfo(Solver *solv, Id p, Id p2, Id d, int type, Id dep)
{
  Pool *pool = solv->pool;
  Rule *r;

  if (d)
    {
      assert(!p2 && d > 0);
      if (!pool->whatprovidesdata[d])
        d = 0;
      else if (!pool->whatprovidesdata[d + 1])
        {
          p2 = pool->whatprovidesdata[d];
          d = 0;
        }
    }

  /* check if this creates the rule we're searching for */
  r = solv->rules + solv->ruleinfoq->elements[0];
  if (d)
    {
      /* three or more literals */
      Id od = r->d < 0 ? -r->d - 1 : r->d;
      if (p != r->p && !od)
        return;
      if (d != od)
        {
          Id *dp = pool->whatprovidesdata + d;
          Id *odp = pool->whatprovidesdata + od;
          while (*dp)
            if (*dp++ != *odp++)
              return;
          if (*odp)
            return;
        }
      /* set p2 for multiversion conflicts */
      if (p < 0 && pool->whatprovidesdata[d] < 0 && pool->whatprovidesdata[d + 1] >= 0 && type == SOLVER_RULE_PKG_CONFLICTS)
        p2 = pool->whatprovidesdata[d];
    }
  else
    {
      /* one or two literals */
      Id op = p, op2 = p2;
      if (op2 && op > op2)      /* normalize */
        {
          Id o = op;
          op = op2;
          op2 = o;
        }
      if (r->p != op || r->w2 != op2 || (r->d && r->d != -1))
        return;
      if (type == SOLVER_RULE_PKG_CONFLICTS && !p2)
        p2 = -SYSTEMSOLVABLE;
      if (type == SOLVER_RULE_PKG_SAME_NAME)
        {
          p = op;       /* we normalize same name order */
          p2 = op2;
        }
    }
  /* yep, rule matches. record info */
  queue_push(solv->ruleinfoq, type);
  queue_push(solv->ruleinfoq, p < 0 ? -p : 0);
  queue_push(solv->ruleinfoq, p2 < 0 ? -p2 : 0);
  queue_push(solv->ruleinfoq, dep);
}

static int
solver_allruleinfos_cmp(const void *ap, const void *bp, void *dp)
{
  const Id *a = ap, *b = bp;
  int r;

  r = a[0] - b[0];
  if (r)
    return r;
  r = a[1] - b[1];
  if (r)
    return r;
  r = a[2] - b[2];
  if (r)
    return r;
  r = a[3] - b[3];
  if (r)
    return r;
  return 0;
}

static void
getpkgruleinfos(Solver *solv, Rule *r, Queue *rq)
{
  Pool *pool = solv->pool;
  Id l, pp;
  if (r->p >= 0)
    return;
  queue_push(rq, r - solv->rules);      /* push the rule we're interested in */
  solv->ruleinfoq = rq;
  FOR_RULELITERALS(l, pp, r)
    {
      if (l >= 0)
        break;
      solver_addpkgrulesforsolvable(solv, pool->solvables - l, 0);
    }
#ifdef ENABLE_LINKED_PKGS
  FOR_RULELITERALS(l, pp, r)
    {
      if (l < 0)
        {
          if (l == r->p)
            continue;
          break;
        }
      if (!strchr(pool_id2str(pool, pool->solvables[l].name), ':') || !has_package_link(pool, pool->solvables + l))
        break;
      add_package_link(solv, pool->solvables + l, 0, 0);
    }
#endif
  solv->ruleinfoq = 0;
  queue_shift(rq);
}

int
solver_allruleinfos(Solver *solv, Id rid, Queue *rq)
{
  Rule *r = solv->rules + rid;
  int i, j;

  queue_empty(rq);
  if (rid <= 0 || rid >= solv->pkgrules_end)
    {
      Id type, from, to, dep;
      type = solver_ruleinfo(solv, rid, &from, &to, &dep);
      queue_push(rq, type);
      queue_push(rq, from);
      queue_push(rq, to);
      queue_push(rq, dep);
      return 1;
    }
  getpkgruleinfos(solv, r, rq);
  /* now sort & unify em */
  if (!rq->count)
    return 0;
  solv_sort(rq->elements, rq->count / 4, 4 * sizeof(Id), solver_allruleinfos_cmp, 0);
  /* throw out identical entries */
  for (i = j = 0; i < rq->count; i += 4)
    {
      if (j)
        {
          if (rq->elements[i] == rq->elements[j - 4] &&
              rq->elements[i + 1] == rq->elements[j - 3] &&
              rq->elements[i + 2] == rq->elements[j - 2] &&
              rq->elements[i + 3] == rq->elements[j - 1])
            continue;
        }
      rq->elements[j++] = rq->elements[i];
      rq->elements[j++] = rq->elements[i + 1];
      rq->elements[j++] = rq->elements[i + 2];
      rq->elements[j++] = rq->elements[i + 3];
    }
  rq->count = j;
  return j / 4;
}

SolverRuleinfo
solver_ruleinfo(Solver *solv, Id rid, Id *fromp, Id *top, Id *depp)
{
  Pool *pool = solv->pool;
  Rule *r = solv->rules + rid;
  SolverRuleinfo type = SOLVER_RULE_UNKNOWN;

  if (fromp)
    *fromp = 0;
  if (top)
    *top = 0;
  if (depp)
    *depp = 0;
  if (rid > 0 && rid < solv->pkgrules_end)
    {
      Queue rq;
      int i;

      if (r->p >= 0)
        return SOLVER_RULE_PKG;
      if (fromp)
        *fromp = -r->p;
      queue_init(&rq);
      getpkgruleinfos(solv, r, &rq);
      type = SOLVER_RULE_PKG;
      for (i = 0; i < rq.count; i += 4)
        {
          Id qt, qo, qp, qd;
          qt = rq.elements[i];
          qp = rq.elements[i + 1];
          qo = rq.elements[i + 2];
          qd = rq.elements[i + 3];
          if (type == SOLVER_RULE_PKG || qt == SOLVER_RULE_PKG_SAME_NAME || type > qt)
            {
              type = qt;
              if (fromp)
                *fromp = qp;
              if (top)
                *top = qo;
              if (depp)
                *depp = qd;
              if (qt == SOLVER_RULE_PKG_SAME_NAME)
                break;                  /* prefer SOLVER_RULE_PKG_SAME_NAME */
            }
        }
      queue_free(&rq);
      return type;
    }
  if (rid >= solv->jobrules && rid < solv->jobrules_end)
    {
      Id jidx = solv->ruletojob.elements[rid - solv->jobrules];
      if (fromp)
        *fromp = jidx;
      if (top)
        *top = solv->job.elements[jidx];
      if (depp)
        *depp = solv->job.elements[jidx + 1];
      if ((r->d == 0 || r->d == -1) && r->w2 == 0 && r->p == -SYSTEMSOLVABLE)
        {
          Id how = solv->job.elements[jidx];
          if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_INSTALL|SOLVER_SOLVABLE_NAME))
            return SOLVER_RULE_JOB_UNKNOWN_PACKAGE;
          if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_INSTALL|SOLVER_SOLVABLE_PROVIDES))
            return SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP;
          if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_ERASE|SOLVER_SOLVABLE_NAME))
            return SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM;
          if ((how & (SOLVER_JOBMASK|SOLVER_SELECTMASK)) == (SOLVER_ERASE|SOLVER_SOLVABLE_PROVIDES))
            return SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM;
          return SOLVER_RULE_JOB_UNSUPPORTED;
        }
      return SOLVER_RULE_JOB;
    }
  if (rid >= solv->updaterules && rid < solv->updaterules_end)
    {
      if (fromp)
        *fromp = solv->installed->start + (rid - solv->updaterules);
      return SOLVER_RULE_UPDATE;
    }
  if (rid >= solv->featurerules && rid < solv->featurerules_end)
    {
      if (fromp)
        *fromp = solv->installed->start + (rid - solv->featurerules);
      return SOLVER_RULE_FEATURE;
    }
  if (rid >= solv->duprules && rid < solv->duprules_end)
    {
      if (fromp)
        *fromp = -r->p;
      if (depp)
        *depp = pool->solvables[-r->p].name;
      return SOLVER_RULE_DISTUPGRADE;
    }
  if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
    {
      if (fromp)
        *fromp = -r->p;
      if (depp)
        *depp = pool->solvables[-r->p].name;
      return SOLVER_RULE_INFARCH;
    }
  if (rid >= solv->bestrules && rid < solv->bestrules_end)
    {
      /* > 0: the package we are updating */
      if (fromp && solv->bestrules_info[rid - solv->bestrules] > 0)
        *fromp = solv->bestrules_info[rid - solv->bestrules];
      /* < 0: the job rule */
      if (top && solv->bestrules_info[rid - solv->bestrules] < 0)
        *top = -solv->bestrules_info[rid - solv->bestrules];
      return SOLVER_RULE_BEST;
    }
  if (rid >= solv->yumobsrules && rid < solv->yumobsrules_end)
    {
      if (fromp)
        *fromp = -r->p;
      if (top)
        {
          /* first solvable is enough, we just need it for the name */
          if (!r->d || r->d == -1)
            *top = r->w2;
          else
            *top = pool->whatprovidesdata[r->d < 0 ? -r->d : r->d];
        }
      if (depp)
        *depp = solv->yumobsrules_info[rid - solv->yumobsrules];
      return SOLVER_RULE_YUMOBS;
    }
  if (rid >= solv->blackrules && rid < solv->blackrules_end)
    {
      if (fromp)
        *fromp = -r->p;
      return SOLVER_RULE_BLACK;
    }
  if (rid >= solv->strictrepopriorules && rid < solv->strictrepopriorules_end)
    {
      if (fromp)
        *fromp = -r->p;
      return SOLVER_RULE_STRICT_REPO_PRIORITY;
    }
  if (rid >= solv->choicerules && rid < solv->choicerules_end)
    {
      if (solv->choicerules_info && fromp)
        *fromp = solv->choicerules_info[rid - solv->choicerules];
      return SOLVER_RULE_CHOICE;
    }
  if (rid >= solv->recommendsrules && rid < solv->recommendsrules_end)
    {
      if (solv->recommendsrules_info && fromp)
        *fromp = solv->recommendsrules_info[rid - solv->recommendsrules];
      return SOLVER_RULE_RECOMMENDS;
    }
  if (rid >= solv->learntrules)
    return SOLVER_RULE_LEARNT;
  return SOLVER_RULE_UNKNOWN;
}

SolverRuleinfo
solver_ruleclass(Solver *solv, Id rid)
{
  if (rid <= 0)
    return SOLVER_RULE_UNKNOWN;
  if (rid > 0 && rid < solv->pkgrules_end)
    return SOLVER_RULE_PKG;
  if (rid >= solv->jobrules && rid < solv->jobrules_end)
    return SOLVER_RULE_JOB;
  if (rid >= solv->updaterules && rid < solv->updaterules_end)
    return SOLVER_RULE_UPDATE;
  if (rid >= solv->featurerules && rid < solv->featurerules_end)
    return SOLVER_RULE_FEATURE;
  if (rid >= solv->duprules && rid < solv->duprules_end)
    return SOLVER_RULE_DISTUPGRADE;
  if (rid >= solv->infarchrules && rid < solv->infarchrules_end)
    return SOLVER_RULE_INFARCH;
  if (rid >= solv->bestrules && rid < solv->bestrules_end)
    return SOLVER_RULE_BEST;
  if (rid >= solv->yumobsrules && rid < solv->yumobsrules_end)
    return SOLVER_RULE_YUMOBS;
  if (rid >= solv->blackrules && rid < solv->blackrules_end)
    return SOLVER_RULE_BLACK;
  if (rid >= solv->choicerules && rid < solv->choicerules_end)
    return SOLVER_RULE_CHOICE;
  if (rid >= solv->recommendsrules && rid < solv->recommendsrules_end)
    return SOLVER_RULE_RECOMMENDS;
  if (rid >= solv->strictrepopriorules && rid < solv->strictrepopriorules_end)
    return SOLVER_RULE_STRICT_REPO_PRIORITY;
  if (rid >= solv->learntrules && rid < solv->nrules)
    return SOLVER_RULE_LEARNT;
  return SOLVER_RULE_UNKNOWN;
}

void
solver_ruleliterals(Solver *solv, Id rid, Queue *q)
{
  Pool *pool = solv->pool;
  Id p, pp;
  Rule *r;

  queue_empty(q);
  r = solv->rules + rid;
  FOR_RULELITERALS(p, pp, r)
    if (p != -SYSTEMSOLVABLE)
      queue_push(q, p);
  if (!q->count)
    queue_push(q, -SYSTEMSOLVABLE);     /* hmm, better to return an empty result? */
}

int
solver_rule2jobidx(Solver *solv, Id rid)
{
  if (rid < solv->jobrules || rid >= solv->jobrules_end)
    return 0;
  return solv->ruletojob.elements[rid - solv->jobrules] + 1;
}

/* job rule introspection */
Id
solver_rule2job(Solver *solv, Id rid, Id *whatp)
{
  int idx;
  if (rid < solv->jobrules || rid >= solv->jobrules_end)
    {
      if (whatp)
        *whatp = 0;
      return 0;
    }
  idx = solv->ruletojob.elements[rid - solv->jobrules];
  if (whatp)
    *whatp = solv->job.elements[idx + 1];
  return solv->job.elements[idx];
}

/* update/feature rule introspection */
Id
solver_rule2solvable(Solver *solv, Id rid)
{
  if (rid >= solv->updaterules && rid < solv->updaterules_end && solv->installed)
    return solv->installed->start + (rid - solv->updaterules);
  if (rid >= solv->featurerules && rid < solv->featurerules_end && solv->installed)
    return solv->installed->start + (rid - solv->featurerules);
  return 0;
}

Id
solver_rule2pkgrule(Solver *solv, Id rid)
{
  if (rid >= solv->choicerules && rid < solv->choicerules_end)
    return solv->choicerules_info[rid - solv->choicerules];
  if (rid >= solv->recommendsrules && rid < solv->recommendsrules_end)
    return solv->recommendsrules_info[rid - solv->recommendsrules];
  return 0;
}

static void
solver_rule2rules_rec(Solver *solv, Id rid, Queue *q, Map *seen)
{
  int i;
  Id rid2;

  if (seen)
    MAPSET(seen, rid);
  for (i = solv->learnt_why.elements[rid - solv->learntrules]; (rid2 = solv->learnt_pool.elements[i]) != 0; i++)
    {
      if (seen)
        {
          if (MAPTST(seen, rid2))
            continue;
          if (rid2 >= solv->learntrules)
            solver_rule2rules_rec(solv, rid2, q, seen);
          continue;
        }
      queue_push(q, rid2);
    }
}

/* learnt rule introspection */
void
solver_rule2rules(Solver *solv, Id rid, Queue *q, int recursive)
{
  queue_empty(q);
  if (rid < solv->learntrules || rid >= solv->nrules)
    return;
  if (recursive)
    {
      Map seen;
      map_init(&seen, solv->nrules);
      solver_rule2rules_rec(solv, rid, q, &seen);
      map_free(&seen);
    }
  else
    solver_rule2rules_rec(solv, rid, q, 0);
}


/* check if the newest versions of pi still provides the dependency we're looking for */
/* pi: installed package
 * r: rule for the dependency
 * m: map with all positive elements of r
 * return 0: at least one provider
 * return 1: the newest versions do not provide the dependency
 */
static int
solver_choicerulecheck(Solver *solv, Id pi, Rule *r, Map *m, Queue *q)
{
  Pool *pool = solv->pool;
  Rule *ur;
  Id p, pp;
  int i;

  if (!q->count || q->elements[0] != pi)
    {
      if (q->count)
        queue_empty(q);
      ur = solv->rules + solv->updaterules + (pi - pool->installed->start);
      if (!ur->p)
        ur = solv->rules + solv->featurerules + (pi - pool->installed->start);
      if (!ur->p)
        return 0;
      queue_push2(q, pi, 0);
      FOR_RULELITERALS(p, pp, ur)
        if (p > 0)
          queue_push(q, p);
    }
  if (q->count == 2)
    return 1;
  if (q->count == 3)
    {
      p = q->elements[2];
      return MAPTST(m, p) ? 0 : 1;
    }
  if (!q->elements[1])
    {
      for (i = 2; i < q->count; i++)
        if (!MAPTST(m, q->elements[i]))
          break;
      if (i == q->count)
        return 0;       /* all provide it, no need to filter */
      /* some don't provide it, have to filter */
      queue_deleten(q, 0, 2);
      policy_filter_unwanted(solv, q, POLICY_MODE_CHOOSE);
      queue_unshift(q, 1);      /* filter mark */
      queue_unshift(q, pi);
    }
  for (i = 2; i < q->count; i++)
    if (MAPTST(m, q->elements[i]))
      return 0;         /* at least one provides it */
  return 1;     /* none of the new packages provided it */
}

static Id
choicerule_find_installed(Pool *pool, Id p)
{
  Solvable *s = pool->solvables + p;
  Id p2, pp2;

  if (!s->repo)
    return 0;
  if (s->repo == pool->installed)
    return p;
  FOR_PROVIDES(p2, pp2, s->name)
    {
      Solvable *s2 = pool->solvables + p2;
      if (s2->repo != pool->installed)
        continue;
      if (!pool->implicitobsoleteusesprovides && s->name != s2->name)
        continue;
      if (pool->implicitobsoleteusescolors && !pool_colormatch(pool, s, s2))
        continue;
      return p2;
    }
  if (s->obsoletes)
    {
      Id obs, *obsp = s->repo->idarraydata + s->obsoletes;
      while ((obs = *obsp++) != 0)
        {
          FOR_PROVIDES(p2, pp2, obs)
            {
              Solvable *s2 = pool->solvables + p2;
              if (s2->repo != pool->installed)
                continue;
              if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
                continue;
              if (pool->obsoleteusescolors && !pool_colormatch(pool, s, s2))
                continue;
              return p2;
            }
        }
    }
  return 0;
}

void
solver_addchoicerules(Solver *solv)
{
  Pool *pool = solv->pool;
  Map m, mneg;
  Rule *r;
  Queue q, qi, qcheck, infoq;
  int i, j, rid, havechoice, negcnt;
  Id p, d, pp, p2;
  Solvable *s;
  Id lastaddedp, lastaddedd;
  int lastaddedcnt;
  unsigned int now;
  int isinstalled;

  solv->choicerules = solv->nrules;
  if (!pool->installed)
    {
      solv->choicerules_end = solv->nrules;
      return;
    }
  now = solv_timems(0);
  queue_init(&q);
  queue_init(&qi);
  queue_init(&qcheck);
  queue_init(&infoq);
  map_init(&m, pool->nsolvables);
  map_init(&mneg, pool->nsolvables);
  /* set up negative assertion map from infarch and dup rules */
  for (rid = solv->infarchrules, r = solv->rules + rid; rid < solv->infarchrules_end; rid++, r++)
    if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
      MAPSET(&mneg, -r->p);
  for (rid = solv->duprules, r = solv->rules + rid; rid < solv->duprules_end; rid++, r++)
    if (r->p < 0 && !r->w2 && (r->d == 0 || r->d == -1))
      MAPSET(&mneg, -r->p);
  lastaddedp = 0;
  lastaddedd = 0;
  lastaddedcnt = 0;
  for (rid = 1; rid < solv->pkgrules_end ; rid++)
    {
      r = solv->rules + rid;
      if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 <= 0))
        continue;       /* only look at requires rules */
      /* solver_printrule(solv, SOLV_DEBUG_RESULT, r); */
      queue_empty(&qi);
      havechoice = 0;
      isinstalled = 0;
      FOR_RULELITERALS(p, pp, r)
        {
          if (p < 0)
            {
              Solvable *s = pool->solvables - p;
              p2 = s->repo == pool->installed ? -p : 0;
              if (p2)
                {
                  if (!(solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, p2 - solv->installed->start))))
                    isinstalled = 1;
                }
              continue;
            }
          s = pool->solvables + p;
          if (!s->repo)
            continue;
          if (s->repo == pool->installed)
            {
              queue_push2(&qi, p, p);
              continue;
            }
          /* find an installed package p2 that we can update/downgrade to p */
          p2 = choicerule_find_installed(pool, p);
          if (p2)
            {
              if (MAPTST(&mneg, p))
                continue;
              if (policy_is_illegal(solv, pool->solvables + p2, s, 0))
                continue;
              queue_push2(&qi, p2, p);
              continue;
            }
          /* package p is independent of the installed ones */
          havechoice = 1;
        }
#if 0
      printf("havechoice: %d qcount %d qicount %d\n", havechoice, q.count, qi.count);
#endif
      if (!havechoice || !qi.count)
        continue;       /* no choice */

      FOR_RULELITERALS(p, pp, r)
        if (p > 0)
          MAPSET(&m, p);

      if (!isinstalled)
        {
          /* do extra checking for packages related to installed packages */
          for (i = j = 0; i < qi.count; i += 2)
            {
              p2 = qi.elements[i];
              if (solv->updatemap_all || (solv->updatemap.size && MAPTST(&solv->updatemap, p2 - solv->installed->start)))
                {
                  if (solver_choicerulecheck(solv, p2, r, &m, &qcheck))
                    continue;
                }
              qi.elements[j++] = p2;
              qi.elements[j++] = qi.elements[i + 1];
            }
          queue_truncate(&qi, j);
        }

      if (!qi.count)
        {
          FOR_RULELITERALS(p, pp, r)
            if (p > 0)
              MAPCLR(&m, p);
          continue;
        }

      queue_empty(&q);
      /* split q from qi */
      for (i = j = 0; i < qi.count; i += 2)
        {
          queue_push(&q, qi.elements[i + 1]);
          qi.elements[j++] = qi.elements[i];
        }
      queue_truncate(&qi, j);


      /* now check the update rules of the installed package.
       * if all packages of the update rules are contained in
       * the dependency rules, there's no need to set up the choice rule */
      for (i = 0; i < qi.count; i++)
        {
          Rule *ur;
          if (!qi.elements[i])
            continue;
          ur = solv->rules + solv->updaterules + (qi.elements[i] - pool->installed->start);
          if (!ur->p)
            ur = solv->rules + solv->featurerules + (qi.elements[i] - pool->installed->start);
          if (!ur->p)
            continue;
          FOR_RULELITERALS(p, pp, ur)
            if (!MAPTST(&m, p))
              break;
          if (p)
            break;
          /* speed improvement: only check each package once */
          for (j = i + 1; j < qi.count; j++)
            if (qi.elements[i] == qi.elements[j])
              qi.elements[j] = 0;
        }
      /* empty map again */
      negcnt = 0;
      FOR_RULELITERALS(p, pp, r)
        if (p > 0)
          MAPCLR(&m, p);
        else
          negcnt++;
      if (i == qi.count)
        {
#if 0
          printf("skipping choice ");
          solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
#endif
          continue;
        }
      /* add neg elements to the front */
      if (negcnt > 1)
        {
          i = 0;
          FOR_RULELITERALS(p, pp, r)
           if (p < 0 && p != r->p)
             queue_insert(&q, i++, p);
        }
      /* don't add identical rules */
      if (lastaddedp == r->p && lastaddedcnt == q.count)
        {
          for (i = 0; i < q.count; i++)
            if (q.elements[i] != pool->whatprovidesdata[lastaddedd + i])
              break;
          if (i == q.count)
            continue;   /* already added that one */
        }
      d = q.count ? pool_queuetowhatprovides(pool, &q) : 0;

      lastaddedp = r->p;
      lastaddedd = d;
      lastaddedcnt = q.count;

      solver_addrule(solv, r->p, 0, d);
      queue_push(&solv->weakruleq, solv->nrules - 1);
      queue_push(&infoq, rid);
#if 0
      printf("OLD ");
      solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + rid);
      printf("WEAK CHOICE ");
      solver_printrule(solv, SOLV_DEBUG_RESULT, solv->rules + solv->nrules - 1);
#endif
    }
  if (infoq.count)
    solv->choicerules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
  queue_free(&q);
  queue_free(&qi);
  queue_free(&qcheck);
  queue_free(&infoq);
  map_free(&m);
  map_free(&mneg);
  solv->choicerules_end = solv->nrules;
  POOL_DEBUG(SOLV_DEBUG_STATS, "choice rule creation took %d ms\n", solv_timems(now));
}

/* called when a choice rule needs to be disabled by analyze_unsolvable.
 * We also have to disable all other choice rules so that the best packages
 * get picked */
void
solver_disablechoicerules(Solver *solv, Rule *r)
{
  Id rid, p, pp;
  Pool *pool = solv->pool;
  Map m;
  Rule *or;

  solver_disablerule(solv, r);
  or = solv->rules + solv->choicerules_info[(r - solv->rules) - solv->choicerules];
  map_init(&m, pool->nsolvables);
  FOR_RULELITERALS(p, pp, or)
    if (p > 0)
      MAPSET(&m, p);
  FOR_RULELITERALS(p, pp, r)
    if (p > 0)
      MAPCLR(&m, p);
  for (rid = solv->choicerules; rid < solv->choicerules_end; rid++)
    {
      r = solv->rules + rid;
      if (r->d < 0)
        continue;
      or = solv->rules + solv->choicerules_info[rid - solv->choicerules];
      FOR_RULELITERALS(p, pp, or)
        if (p > 0 && MAPTST(&m, p))
          break;
      if (p)
        solver_disablerule(solv, r);
    }
  map_free(&m);
}

static void
prune_to_update_targets(Solver *solv, Id *cp, Queue *q)
{
  int i, j;
  Id p, *cp2;
  for (i = j = 0; i < q->count; i++)
    {
      p = q->elements[i];
      for (cp2 = cp; *cp2; cp2++)
        if (*cp2 == p)
          {
            q->elements[j++] = p;
            break;
          }
    }
  queue_truncate(q, j);
}

static void
prune_to_dup_packages(Solver *solv, Id p, Queue *q)
{
  int i, j;
  for (i = j = 0; i < q->count; i++)
    {
      Id p = q->elements[i];
      if (MAPTST(&solv->dupmap, p))
        q->elements[j++] = p;
    }
  queue_truncate(q, j);
}

static void
prune_best_update(Solver *solv, Id p, Queue *q)
{
  if (solv->update_targets && solv->update_targets->elements[p - solv->installed->start])
    prune_to_update_targets(solv, solv->update_targets->elements + solv->update_targets->elements[p - solv->installed->start], q);
  if (solv->dupinvolvedmap.size && MAPTST(&solv->dupinvolvedmap, p))
    prune_to_dup_packages(solv, p, q);
  /* select best packages, just look at prio and version */
  policy_filter_unwanted(solv, q, POLICY_MODE_RECOMMEND);
}

static void
prune_disabled(Pool *pool, Queue *q)
{
  int i, j;
  for (i = j = 0; i < q->count; i++)
    {
      Id p = q->elements[i];
      Solvable *s = pool->solvables + p;
      if (s->repo && s->repo != pool->installed && !MAPTST(pool->considered, p))
        continue;
      q->elements[j++] = p;
    }
  queue_truncate(q, j);
}

void
solver_addbestrules(Solver *solv, int havebestinstalljobs, int haslockjob)
{
  Pool *pool = solv->pool;
  Id p;
  Solvable *s;
  Repo *installed = solv->installed;
  Queue q, q2;
  Rule *r;
  Queue infoq;
  int i, oldcnt;
  Map *lockedmap = 0;

  solv->bestrules = solv->nrules;
  queue_init(&q);
  queue_init(&q2);
  queue_init(&infoq);

  if (haslockjob)
    {
      int i;
      lockedmap = solv_calloc(1, sizeof(Map));
      map_init(lockedmap, pool->nsolvables);
      for (i = 0, r = solv->rules + solv->jobrules; i < solv->ruletojob.count; i++, r++)
        {
          if (r->w2 || (solv->job.elements[solv->ruletojob.elements[i]] & SOLVER_JOBMASK) != SOLVER_LOCK)
            continue;
          p = r->p > 0 ? r->p : -r->p;
          MAPSET(lockedmap, p);
        }
    }
  if (havebestinstalljobs)
    {
      for (i = 0; i < solv->job.count; i += 2)
        {
          Id how = solv->job.elements[i];
          if ((how & (SOLVER_JOBMASK | SOLVER_FORCEBEST)) == (SOLVER_INSTALL | SOLVER_FORCEBEST))
            {
              int j, k;
              Id p2, pp2;
              for (j = 0; j < solv->ruletojob.count; j++)
                {
                  if (solv->ruletojob.elements[j] != i)
                    continue;
                  r = solv->rules + solv->jobrules + j;
                  queue_empty(&q);
                  queue_empty(&q2);
                  FOR_RULELITERALS(p2, pp2, r)
                    {
                      if (p2 > 0)
                        queue_push(&q, p2);
                      else if (p2 < 0)
                        queue_push(&q2, p2);
                    }
                  if (pool->considered && pool->whatprovideswithdisabled)
                    prune_disabled(pool, &q);
                  if (!q.count)
                    continue;   /* orphaned */
                  /* select best packages, just look at prio and version */
                  oldcnt = q.count;
                  policy_filter_unwanted(solv, &q, POLICY_MODE_RECOMMEND);
                  if (q.count == oldcnt)
                    continue;   /* nothing filtered */
                  if (lockedmap)
                    {
                      queue_insertn(&q, 0, q2.count, q2.elements);
                      queue_empty(&q2);
                      FOR_RULELITERALS(p2, pp2, r)
                        {
                          if (p2 <= 0)
                            continue;
                          if (installed && pool->solvables[p2].repo == installed)
                            {
                              if (MAPTST(lockedmap, p2))
                                queue_pushunique(&q, p2);               /* we always want that package */
                            }
                          else if (MAPTST(lockedmap, p2))
                            continue;
                          queue_push(&q2, p2);
                        }
                      if (pool->considered && pool->whatprovideswithdisabled)
                        prune_disabled(pool, &q2);
                      policy_filter_unwanted(solv, &q2, POLICY_MODE_RECOMMEND);
                      for (k = 0; k < q2.count; k++)
                        queue_pushunique(&q, q2.elements[k]);
                      queue_empty(&q2);
                    }
                  if (q2.count)
                    queue_insertn(&q, 0, q2.count, q2.elements);
                  p2 = queue_shift(&q);
                  if (q.count < 2)
                    solver_addrule(solv, p2, q.count ? q.elements[0] : 0, 0);
                  else
                    solver_addrule(solv, p2, 0, pool_queuetowhatprovides(pool, &q));
                  if ((how & SOLVER_WEAK) != 0)
                    queue_push(&solv->weakruleq, solv->nrules - 1);
                  queue_push(&infoq, -(solv->jobrules + j));
                }
            }
        }
    }
  solv->bestrules_up = solv->nrules;

  if (installed && (solv->bestupdatemap_all || solv->bestupdatemap.size))
    {
      Map m;

      if (solv->allowuninstall || solv->allowuninstall_all || solv->allowuninstallmap.size)
        map_init(&m, pool->nsolvables);
      else
        map_init(&m, 0);
      FOR_REPO_SOLVABLES(installed, p, s)
        {
          Id d, p2, pp2;
          if (!solv->updatemap_all && (!solv->updatemap.size || !MAPTST(&solv->updatemap, p - installed->start)))
            continue;
          if (!solv->bestupdatemap_all && (!solv->bestupdatemap.size || !MAPTST(&solv->bestupdatemap, p - installed->start)))
            continue;
          queue_empty(&q);
          if (solv->bestobeypolicy)
            r = solv->rules + solv->updaterules + (p - installed->start);
          else
            {
              r = solv->rules + solv->featurerules + (p - installed->start);
              if (!r->p)        /* identical to update rule? */
                r = solv->rules + solv->updaterules + (p - installed->start);
            }
          if (solv->specialupdaters && (d = solv->specialupdaters[p - installed->start]) != 0 && r == solv->rules + solv->updaterules + (p - installed->start))
            {
              /* need to check specialupdaters */
              if (r->p == p)    /* be careful with the dup case */
                queue_push(&q, p);
              while ((p2 = pool->whatprovidesdata[d++]) != 0)
                queue_push(&q, p2);
            }
          else
            {
              FOR_RULELITERALS(p2, pp2, r)
                if (p2 > 0)
                  queue_push(&q, p2);
            }
          if (lockedmap)
            {
              queue_empty(&q2);
              queue_insertn(&q2, 0, q.count, q.elements);
            }
          prune_best_update(solv, p, &q);
          if (!q.count)
            continue;   /* orphaned */
          if (lockedmap)
            {
              int j;
              /* always ok to keep installed locked packages */
              if (MAPTST(lockedmap, p))
                queue_pushunique(&q2, p);
              for (j = 0; j < q2.count; j++)
                {
                  Id p2 = q2.elements[j];
                  if (pool->solvables[p2].repo == installed && MAPTST(lockedmap, p2))
                    queue_pushunique(&q, p2);
                }
              /* filter out locked packages */
              for (i = j = 0; j < q2.count; j++)
                {
                  Id p2 = q2.elements[j];
                  if (pool->solvables[p2].repo == installed || !MAPTST(lockedmap, p2))
                    q2.elements[i++] = p2;
                }
              queue_truncate(&q2, i);
              prune_best_update(solv, p, &q2);
              for (j = 0; j < q2.count; j++)
                queue_pushunique(&q, q2.elements[j]);
            }
          if (solv->bestobeypolicy)
            {
              /* also filter the best of the feature rule packages and add them */
              r = solv->rules + solv->featurerules + (p - installed->start);
              if (r->p)
                {
                  int j;
                  queue_empty(&q2);
                  FOR_RULELITERALS(p2, pp2, r)
                    if (p2 > 0)
                      queue_push(&q2, p2);
                  prune_best_update(solv, p, &q2);
                  for (j = 0; j < q2.count; j++)
                    queue_pushunique(&q, q2.elements[j]);
                  if (lockedmap)
                    {
                      queue_empty(&q2);
                      FOR_RULELITERALS(p2, pp2, r)
                        if (p2 > 0)
                          if (pool->solvables[p2].repo == installed || !MAPTST(lockedmap, p2))
                            queue_push(&q2, p2);
                      prune_best_update(solv, p, &q2);
                      for (j = 0; j < q2.count; j++)
                        queue_pushunique(&q, q2.elements[j]);
                    }
                }
            }
          if (solv->allowuninstall || solv->allowuninstall_all || (solv->allowuninstallmap.size && MAPTST(&solv->allowuninstallmap, p - installed->start)))
            {
              /* package is flagged both for allowuninstall and best, add negative rules */
              d = q.count == 1 ? q.elements[0] : -pool_queuetowhatprovides(pool, &q);
              for (i = 0; i < q.count; i++)
                MAPSET(&m, q.elements[i]);
              r = solv->rules + solv->featurerules + (p - installed->start);
              if (!r->p)        /* identical to update rule? */
                r = solv->rules + solv->updaterules + (p - installed->start);
              FOR_RULELITERALS(p2, pp2, r)
                {
                  if (MAPTST(&m, p2))
                    continue;
                  if (d >= 0)
                    solver_addrule(solv, -p2, d, 0);
                  else
                    solver_addrule(solv, -p2, 0, -d);
                  queue_push(&infoq, p);
                }
              for (i = 0; i < q.count; i++)
                MAPCLR(&m, q.elements[i]);
              continue;
            }
          p2 = queue_shift(&q);
          if (q.count < 2)
            solver_addrule(solv, p2, q.count ? q.elements[0] : 0, 0);
          else
            solver_addrule(solv, p2, 0, pool_queuetowhatprovides(pool, &q));
          queue_push(&infoq, p);
        }
      map_free(&m);
    }
  if (infoq.count)
    solv->bestrules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
  solv->bestrules_end = solv->nrules;
  queue_free(&q);
  queue_free(&q2);
  queue_free(&infoq);
  if (lockedmap)
    {
      map_free(lockedmap);
      solv_free(lockedmap);
    }
}




/* yumobs rule handling */
/* note that we use pool->obsoleteusescolors || pool->implicitobsoleteusescolors
 * like in policy_findupdatepackages */

static void
find_obsolete_group(Solver *solv, Id obs, Queue *q)
{
  Pool *pool = solv->pool;
  Queue qn;
  Id p2, pp2, op, *opp, opp2;
  int i, j, qnc, ncnt;

  queue_empty(q);
  FOR_PROVIDES(p2, pp2, obs)
    {
      Solvable *s2 = pool->solvables + p2;
      if (s2->repo != pool->installed)
        continue;
      if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
        continue;
      /* we obsolete installed package s2 with obs. now find all other packages that have the same dep  */
      for (opp = solv->obsoletes_data + solv->obsoletes[p2 - solv->installed->start]; (op = *opp++) != 0;)
        {
          Solvable *os = pool->solvables + op;
          Id obs2, *obsp2;
          if (!os->obsoletes)
            continue;
          if ((pool->obsoleteusescolors || pool->implicitobsoleteusescolors) && !pool_colormatch(pool, s2, os))
            continue;
          obsp2 = os->repo->idarraydata + os->obsoletes;
          while ((obs2 = *obsp2++) != 0)
            if (obs2 == obs)
              break;
          if (obs2)
            queue_pushunique(q, op);
        }
      /* also search packages with the same name */
      FOR_PROVIDES(op, opp2, s2->name)
        {
          Solvable *os = pool->solvables + op;
          Id obs2, *obsp2;
          if (os->name != s2->name)
            continue;
          if (!os->obsoletes)
            continue;
          if ((pool->obsoleteusescolors || pool->implicitobsoleteusescolors) && !pool_colormatch(pool, s2, os))
            continue;
          obsp2 = os->repo->idarraydata + os->obsoletes;
          while ((obs2 = *obsp2++) != 0)
            if (obs2 == obs)
              break;
          if (obs2)
            queue_pushunique(q, op);
        }
    }
  /* find names so that we can build groups */
  queue_init_clone(&qn, q);
  prune_to_best_version(pool, &qn);
#if 0
{
  for (i = 0; i < qn.count; i++)
    printf(" + %s\n", pool_solvid2str(pool, qn.elements[i]));
}
#endif
  /* filter into name groups */
  qnc = qn.count;
  if (qnc == 1)
    {
      queue_free(&qn);
      queue_empty(q);
      return;
    }
  ncnt = 0;
  for (i = 0; i < qnc; i++)
    {
      Id n = pool->solvables[qn.elements[i]].name;
      int got = 0;
      for (j = 0; j < q->count; j++)
        {
          Id p = q->elements[j];
          if (pool->solvables[p].name == n)
            {
              queue_push(&qn, p);
              got = 1;
            }
        }
      if (got)
        {
          queue_push(&qn, 0);
          ncnt++;
        }
    }
  if (ncnt <= 1)
    {
      queue_empty(q);
    }
  else
    {
      queue_empty(q);
      queue_insertn(q, 0, qn.count - qnc, qn.elements + qnc);
    }
  queue_free(&qn);
}

void
solver_addyumobsrules(Solver *solv)
{
  Pool *pool = solv->pool;
  Repo *installed = solv->installed;
  Id p, op, *opp;
  Solvable *s;
  Queue qo, qq, infoq;
  int i, j, k;
  unsigned int now;

  solv->yumobsrules = solv->nrules;
  if (!installed || !solv->obsoletes)
    {
      solv->yumobsrules_end = solv->nrules;
      return;
    }
  now = solv_timems(0);
  queue_init(&qo);
  FOR_REPO_SOLVABLES(installed, p, s)
    {
      if (!solv->obsoletes[p - installed->start])
        continue;
#if 0
printf("checking yumobs for %s\n", pool_solvable2str(pool, s));
#endif
      for (opp = solv->obsoletes_data + solv->obsoletes[p - installed->start]; (op = *opp++) != 0;)
        {
          Solvable *os = pool->solvables + op;
          Id obs, *obsp = os->repo->idarraydata + os->obsoletes;
          Id p2, pp2;
          while ((obs = *obsp++) != 0)
            {
              FOR_PROVIDES(p2, pp2, obs)
                {
                  Solvable *s2 = pool->solvables + p2;
                  if (s2->repo != installed)
                    continue;
                  if (!pool->obsoleteusesprovides && !pool_match_nevr(pool, pool->solvables + p2, obs))
                    continue;
                  if ((pool->obsoleteusescolors || pool->implicitobsoleteusescolors) && !pool_colormatch(pool, s, s2))
                    continue;
                  queue_pushunique(&qo, obs);
                  break;
                }
            }
        }
    }
  if (!qo.count)
    {
      queue_free(&qo);
      return;
    }
  queue_init(&infoq);
  queue_init(&qq);
  for (i = 0; i < qo.count; i++)
    {
      int group, groupk, groupstart;
      queue_empty(&qq);
#if 0
printf("investigating %s\n", pool_dep2str(pool, qo.elements[i]));
#endif
      find_obsolete_group(solv, qo.elements[i], &qq);
#if 0
printf("result:\n");
for (j = 0; j < qq.count; j++)
  if (qq.elements[j] == 0)
    printf("---\n");
  else
    printf("%s\n", pool_solvid2str(pool, qq.elements[j]));
#endif

      if (!qq.count)
        continue;
      /* at least two groups, build rules */
      group = 0;
      for (j = 0; j < qq.count; j++)
        {
          p = qq.elements[j];
          if (!p)
            {
              group++;
              continue;
            }
          if (pool->solvables[p].repo == installed)
            continue;
          groupk = 0;
          groupstart = 0;
          for (k = 0; k < qq.count; k++)
            {
              Id pk = qq.elements[k];
              if (pk)
                continue;
              if (group != groupk && k > groupstart)
                {
                  /* add the rule */
                  if (k - groupstart == 1)
                    solver_addrule(solv, -p, qq.elements[groupstart], 0);
                  else
                    solver_addrule(solv, -p, 0, pool_ids2whatprovides(pool, qq.elements + groupstart, k - groupstart));
                  queue_push(&infoq, qo.elements[i]);
                }
              groupstart = k + 1;
              groupk++;
            }
        }
    }
  if (infoq.count)
    solv->yumobsrules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
  queue_free(&infoq);
  queue_free(&qq);
  queue_free(&qo);
  solv->yumobsrules_end = solv->nrules;
  POOL_DEBUG(SOLV_DEBUG_STATS, "yumobs rule creation took %d ms\n", solv_timems(now));
}

/* recommendsrules are a copy of some recommends package rule but
 * with some disfavored literals removed */
void
solver_addrecommendsrules(Solver *solv)
{
  Pool *pool = solv->pool;
  int i, havedis, havepos;
  Id p, pp;
  Queue q, infoq;

  solv->recommendsrules = solv->nrules;
  queue_init(&q);
  queue_init(&infoq);
  for (i = 0; i < solv->recommendsruleq->count; i++)
    {
      int rid = solv->recommendsruleq->elements[i];
      Rule *r = solv->rules + rid;
      queue_empty(&q);
      havedis = havepos = 0;
      FOR_RULELITERALS(p, pp, r)
        {
          if (p > 0 && solv->favormap[p] < 0)
            havedis = 1;
          else
            {
              if (p > 0)
                havepos = 1;
              queue_push(&q, p);
            }
        }
      if (!havedis)
        continue;
      solver_disablerule(solv, r);
      if (!havepos || q.count < 2)
        continue;
      if (q.count == 2)
        solver_addrule(solv, q.elements[0], q.elements[1], 0);
      else
        solver_addrule(solv, q.elements[0], 0, pool_ids2whatprovides(pool, q.elements + 1, q.count - 1));
      queue_push(&infoq, rid);
    }
  if (infoq.count)
    solv->recommendsrules_info = solv_memdup2(infoq.elements, infoq.count, sizeof(Id));
  queue_free(&infoq);
  queue_free(&q);
  solv->recommendsrules_end = solv->nrules;
}

void
solver_breakorphans(Solver *solv)
{
  Pool *pool = solv->pool;
  Repo *installed = solv->installed;
  int i, rid;
  Map m;

  if (!installed || solv->droporphanedmap_all)
    return;
  solv->brokenorphanrules = solv_calloc(1, sizeof(Queue));
  queue_init(solv->brokenorphanrules);
  map_init(&m, installed->end - installed->start);
  for (i = 0; i < solv->orphaned.count; i++)
    {
      Id p = solv->orphaned.elements[i];
      if (pool->solvables[p].repo != installed)
        continue;
      if (solv->droporphanedmap.size && MAPTST(&solv->droporphanedmap, p - installed->start))
        continue;
      MAPSET(&m, p - installed->start);
    }
  for (rid = 1; rid < solv->pkgrules_end ; rid++)
    {
      Id p, *dp;
      Rule *r = solv->rules + rid;
      /* ignore non-deps and simple conflicts */
      if (r->p >= 0 || ((r->d == 0 || r->d == -1) && r->w2 < 0))
        continue;
      p = -r->p;
      if (p < installed->start || p >= installed->end || !MAPTST(&m, p - installed->start))
        {
          /* need to check other literals */
          if (r->d == 0 || r->d == -1)
            continue;
          for (dp = pool->whatprovidesdata + (r->d < 0 ? -r->d - 1 : r->d); *dp < 0; dp++)
            {
              p = -*dp;
              if (p >= installed->start && p < installed->end && MAPTST(&m, p - installed->start))
                break;
            }
          if (*dp >= 0)
            continue;
        }
      /* ok, disable this rule */
      queue_push(solv->brokenorphanrules, rid);
      if (r->d >= 0)
        solver_disablerule(solv, r);
    }
  map_free(&m);
  if (!solv->brokenorphanrules->count)
    {
      queue_free(solv->brokenorphanrules);
      solv->brokenorphanrules = solv_free(solv->brokenorphanrules);
    }
}

void
solver_check_brokenorphanrules(Solver *solv, Queue *dq)
{
  Pool *pool = solv->pool;
  int i;
  Id l, pp;

  queue_empty(dq);
  if (!solv->brokenorphanrules)
    return;
  for (i = 0; i < solv->brokenorphanrules->count; i++)
    {
      int rid = solv->brokenorphanrules->elements[i];
      Rule *r = solv->rules + rid;
      FOR_RULELITERALS(l, pp, r)
        {
          if (l < 0)
            {
              if (solv->decisionmap[-l] <= 0)
                break;
            }
          else
            {
              if (solv->decisionmap[l] > 0 && pool->solvables[l].repo != solv->installed)
                break;
            }
        }
      if (l)
        continue;
      FOR_RULELITERALS(l, pp, r)
        if (l > 0 && solv->decisionmap[l] == 0 && pool->solvables[l].repo != solv->installed)
          queue_pushunique(dq, l);
    }
}

const char *
solver_ruleinfo2str(Solver *solv, SolverRuleinfo type, Id source, Id target, Id dep)
{
  Pool *pool = solv->pool;
  char *s;
  Solvable *ss;
  switch (type)
    {
    case SOLVER_RULE_DISTUPGRADE:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " does not belong to a distupgrade repository", 0);
    case SOLVER_RULE_INFARCH:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " has inferior architecture", 0);
    case SOLVER_RULE_UPDATE:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " needs to stay installed or be updated", 0);
    case SOLVER_RULE_FEATURE:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " needs to stay installed or be updated/downgraded", 0);
    case SOLVER_RULE_JOB:
      return pool_tmpjoin(pool, "job ", pool_job2str(pool, target, dep, 0), 0);
    case SOLVER_RULE_JOB_UNSUPPORTED:
      return pool_tmpjoin(pool, "unsupported job ", pool_job2str(pool, target, dep, 0), 0);
    case SOLVER_RULE_JOB_NOTHING_PROVIDES_DEP:
      return pool_tmpjoin(pool, "nothing provides requested ", pool_dep2str(pool, dep), 0);
    case SOLVER_RULE_JOB_UNKNOWN_PACKAGE:
      return pool_tmpjoin(pool, "requested package ", pool_dep2str(pool, dep), " does not exist");
    case SOLVER_RULE_JOB_PROVIDED_BY_SYSTEM:
      return pool_tmpjoin(pool, "requested ", pool_dep2str(pool, dep), " is provided by the system");
    case SOLVER_RULE_BEST:
      if (source > 0)
        return pool_tmpjoin(pool, "install best update candidate for ", pool_solvid2str(pool, source), 0);
      if (target > 0)
        {
          target = solver_rule2job(solv, target, &dep);
          return pool_tmpjoin(pool, "best package for job ", pool_job2str(pool, target, dep, 0), 0);
        }
     return "best rule";
    case SOLVER_RULE_PKG:
      return "bad pkg rule type";
    case SOLVER_RULE_PKG_NOT_INSTALLABLE:
      ss = pool->solvables + source;
      if (pool_disabled_solvable(pool, ss))
        return pool_tmpjoin(pool, pool_solvid2str(pool, source), " is disabled", 0);
      if (ss->arch && ss->arch != ARCH_SRC && ss->arch != ARCH_NOSRC &&
          pool->id2arch && pool_arch2score(pool, ss->arch) == 0)
        return pool_tmpjoin(pool, pool_solvid2str(pool, source), " does not have a compatible architecture", 0);
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " is not installable", 0);
    case SOLVER_RULE_PKG_NOTHING_PROVIDES_DEP:
      s = pool_tmpjoin(pool, "nothing provides ", pool_dep2str(pool, dep), 0);
      return pool_tmpappend(pool, s, " needed by ", pool_solvid2str(pool, source));
    case SOLVER_RULE_PKG_SAME_NAME:
      s = pool_tmpjoin(pool, "cannot install both ", pool_solvid2str(pool, source), 0);
      return pool_tmpappend(pool, s, " and ", pool_solvid2str(pool, target));
    case SOLVER_RULE_PKG_CONFLICTS:
      s = pool_tmpappend(pool, pool_solvid2str(pool, source), " conflicts with ", pool_dep2str(pool, dep));
      if (target)
        s = pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
      return s;
    case SOLVER_RULE_PKG_SELF_CONFLICT:
      s = pool_tmpjoin(pool, pool_solvid2str(pool, source), " conflicts with ", 0);
      return pool_tmpappend(pool, s, pool_dep2str(pool, dep), " provided by itself");
    case SOLVER_RULE_PKG_OBSOLETES:
      s = pool_tmpappend(pool, pool_solvid2str(pool, source), " obsoletes ", pool_dep2str(pool, dep));
      if (target)
        s = pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
      return s;
    case SOLVER_RULE_PKG_INSTALLED_OBSOLETES:
      s = pool_tmpjoin(pool, "installed ", pool_solvid2str(pool, source), 0);
      s = pool_tmpappend(pool, s, " obsoletes ", pool_dep2str(pool, dep));
      if (target)
        s = pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
      return s;
    case SOLVER_RULE_PKG_IMPLICIT_OBSOLETES:
      s = pool_tmpappend(pool, pool_solvid2str(pool, source), " implicitly obsoletes ", pool_dep2str(pool, dep));
      if (target)
        s = pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
      return s;
    case SOLVER_RULE_PKG_REQUIRES:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " requires ", pool_dep2str(pool, dep));
    case SOLVER_RULE_PKG_RECOMMENDS:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " recommends ", pool_dep2str(pool, dep));
    case SOLVER_RULE_PKG_CONSTRAINS:
      s = pool_tmpappend(pool, pool_solvid2str(pool, source), " has constraint ", pool_dep2str(pool, dep));
      return pool_tmpappend(pool, s, " conflicting with ", pool_solvid2str(pool, target));
    case SOLVER_RULE_PKG_SUPPLEMENTS:
      s = pool_tmpjoin(pool, pool_solvid2str(pool, source), " supplements ", pool_dep2str(pool, dep));
      if (target)
        s = pool_tmpappend(pool, s, " provided by ", pool_solvid2str(pool, target));
      return s;
    case SOLVER_RULE_YUMOBS:
      s = pool_tmpjoin(pool, "both ", pool_solvid2str(pool, source), " and ");
      s = pool_tmpjoin(pool, s, pool_solvid2str(pool, target), " obsolete ");
      return pool_tmpappend(pool, s, pool_dep2str(pool, dep), 0);
    case SOLVER_RULE_BLACK:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " can only be installed by a direct request", 0);
    case SOLVER_RULE_STRICT_REPO_PRIORITY:
      return pool_tmpjoin(pool, pool_solvid2str(pool, source), " is excluded by strict repo priority", 0);
    case SOLVER_RULE_LEARNT:
      return "learnt rule";
    case SOLVER_RULE_CHOICE:
      if (source > 0)
        {
          const char *s2;
          type = solver_ruleinfo(solv, source, &source, &target, &dep);
          s2 = solver_ruleinfo2str(solv, type, source, target, dep);
          return pool_tmpjoin(pool, s2, " (limited version)", 0);
        }
      return "choice rule";
    case SOLVER_RULE_RECOMMENDS:
      if (source > 0)
        {
          const char *s2;
          type = solver_ruleinfo(solv, source, &source, &target, &dep);
          s2 = solver_ruleinfo2str(solv, type, source, target, dep);
          return pool_tmpjoin(pool, s2, " (limited version)", 0);
        }
      return "recommends rule";
    default:
      return "bad rule type";
    }
}