scsi: hpsa: Use vmemdup_user to replace the open code

vmemdup_user is better than duplicating its implementation, So just replace
the open code.

The issue is detected with the help of Coccinelle.

Tested-by: Don Brace <don.brace@microsemi.com>
Acked-by: Don Brace <don.brace@microsemi.com>
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 58bb70b886d70d714ee6b448843aa113c2b313c0..666ba09e5f428673e7efc8f6446ec38465b5e7a9 100644 (file)
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6381,13 +6381,9 @@ static int hpsa_big_passthru_ioctl(struct ctlr_info *h, void __user *argp)
                return -EINVAL;
        if (!capable(CAP_SYS_RAWIO))
                return -EPERM;
-       ioc = kmalloc(sizeof(*ioc), GFP_KERNEL);
-       if (!ioc) {
-               status = -ENOMEM;
-               goto cleanup1;
-       }
-       if (copy_from_user(ioc, argp, sizeof(*ioc))) {
-               status = -EFAULT;
+       ioc = vmemdup_user(argp, sizeof(*ioc));
+       if (IS_ERR(ioc)) {
+               status = PTR_ERR(ioc);
                goto cleanup1;
        }
        if ((ioc->buf_size < 1) &&
@@ -6505,7 +6501,7 @@ cleanup1:
                kfree(buff);
        }
        kfree(buff_size);
-       kfree(ioc);
+       kvfree(ioc);
        return status;
 }