]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
nfsd: kill stale comment about simple_fill_super() requirements
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 12 Nov 2023 00:27:17 +0000 (19:27 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Wed, 20 Dec 2023 17:10:31 +0000 (12:10 -0500)
That went into the tree back in 2005; the comment used to be true for
predecessor of simple_fill_super() that happened to live in nfsd; that one
didn't take care to skip the array entries with NULL ->name, so it could
not tolerate any gaps.  That had been fixed in 2003 when nfsd_fill_super()
had been abstracted into simple_fill_super(); if Neil's patch lived out
of tree during that time, he probably replaced the name of function when
rebasing it and didn't notice that restriction in question was no longer
there.

Acked-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/nfsd/nfsctl.c

index 3e15b72f421d4c104574728ae75b2dc16cf38015..26a25e40c4513177d4c3e9e787df100ab34225ac 100644 (file)
@@ -48,10 +48,6 @@ enum {
        NFSD_MaxBlkSize,
        NFSD_MaxConnections,
        NFSD_Filecache,
-       /*
-        * The below MUST come last.  Otherwise we leave a hole in nfsd_files[]
-        * with !CONFIG_NFSD_V4 and simple_fill_super() goes oops
-        */
 #ifdef CONFIG_NFSD_V4
        NFSD_Leasetime,
        NFSD_Gracetime,