]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
vsock/virtio: set SOCK_DONE on peer shutdown
authorStephen Barber <smbarber@chromium.org>
Sat, 15 Jun 2019 06:42:37 +0000 (23:42 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 15 Jun 2019 21:01:09 +0000 (14:01 -0700)
Set the SOCK_DONE flag to match the TCP_CLOSING state when a peer has
shut down and there is nothing left to read.

This fixes the following bug:
1) Peer sends SHUTDOWN(RDWR).
2) Socket enters TCP_CLOSING but SOCK_DONE is not set.
3) read() returns -ENOTCONN until close() is called, then returns 0.

Signed-off-by: Stephen Barber <smbarber@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/vmw_vsock/virtio_transport_common.c

index f3f3d06cb6d8f69f9d4b082c07c7ddd488c30a1f..e30f53728725d1c5e80d22cfccaea4ffb17474a9 100644 (file)
@@ -871,8 +871,10 @@ virtio_transport_recv_connected(struct sock *sk,
                if (le32_to_cpu(pkt->hdr.flags) & VIRTIO_VSOCK_SHUTDOWN_SEND)
                        vsk->peer_shutdown |= SEND_SHUTDOWN;
                if (vsk->peer_shutdown == SHUTDOWN_MASK &&
-                   vsock_stream_has_data(vsk) <= 0)
+                   vsock_stream_has_data(vsk) <= 0) {
+                       sock_set_flag(sk, SOCK_DONE);
                        sk->sk_state = TCP_CLOSING;
+               }
                if (le32_to_cpu(pkt->hdr.flags))
                        sk->sk_state_change(sk);
                break;