]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
sctp: check assoc before SCTP_ADDR_{MADE_PRIM, ADDED} event
authorJonas Falkevik <jonas.falkevik@gmail.com>
Wed, 27 May 2020 09:56:40 +0000 (11:56 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 May 2020 19:47:02 +0000 (12:47 -0700)
Make sure SCTP_ADDR_{MADE_PRIM,ADDED} are sent only for associations
that have been established.

These events are described in rfc6458#section-6.1
SCTP_PEER_ADDR_CHANGE:
This tag indicates that an address that is
part of an existing association has experienced a change of
state (e.g., a failure or return to service of the reachability
of an endpoint via a specific transport address).

Signed-off-by: Jonas Falkevik <jonas.falkevik@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/ulpevent.c

index c82dbdcf13f2ffe13d10a2acac67ed26b1f6c0ea..77d5c36a8991c853bcd05a35bcd8ba48385cb165 100644 (file)
@@ -343,6 +343,9 @@ void sctp_ulpevent_nofity_peer_addr_change(struct sctp_transport *transport,
        struct sockaddr_storage addr;
        struct sctp_ulpevent *event;
 
+       if (asoc->state < SCTP_STATE_ESTABLISHED)
+               return;
+
        memset(&addr, 0, sizeof(struct sockaddr_storage));
        memcpy(&addr, &transport->ipaddr, transport->af_specific->sockaddr_len);