]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mmc: moxart-mmc: Factor out moxart_use_dma() helper
authorLinus Walleij <linus.walleij@linaro.org>
Sat, 27 Jan 2024 00:19:49 +0000 (01:19 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 13 Feb 2024 12:40:55 +0000 (13:40 +0100)
The same code is in two places and we will add a third place.
Break this out into its own function.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240127-mmc-proper-kmap-v2-2-d8e732aa97d1@linaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/moxart-mmc.c

index 5cfdd3a86e545753baf0eeea0eef13e27bad77c9..d12d7d79b19cea2633c5945dbc37d02ba404614a 100644 (file)
@@ -254,6 +254,11 @@ static void moxart_dma_complete(void *param)
        complete(&host->dma_complete);
 }
 
+static bool moxart_use_dma(struct moxart_host *host)
+{
+       return (host->data_len > host->fifo_width) && host->have_dma;
+}
+
 static void moxart_transfer_dma(struct mmc_data *data, struct moxart_host *host)
 {
        u32 len, dir_slave;
@@ -375,7 +380,7 @@ static void moxart_prepare_data(struct moxart_host *host)
        if (data->flags & MMC_DATA_WRITE)
                datactrl |= DCR_DATA_WRITE;
 
-       if ((host->data_len > host->fifo_width) && host->have_dma)
+       if (moxart_use_dma(host))
                datactrl |= DCR_DMA_EN;
 
        writel(DCR_DATA_FIFO_RESET, host->base + REG_DATA_CONTROL);
@@ -407,7 +412,7 @@ static void moxart_request(struct mmc_host *mmc, struct mmc_request *mrq)
        moxart_send_command(host, host->mrq->cmd);
 
        if (mrq->cmd->data) {
-               if ((host->data_len > host->fifo_width) && host->have_dma) {
+               if (moxart_use_dma(host)) {
 
                        writel(CARD_CHANGE, host->base + REG_INTERRUPT_MASK);