]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
btrfs: remove redundant log root tree index assignment during log sync
authorFilipe Manana <fdmanana@suse.com>
Mon, 9 Oct 2023 12:01:43 +0000 (13:01 +0100)
committerDavid Sterba <dsterba@suse.com>
Thu, 12 Oct 2023 14:44:19 +0000 (16:44 +0200)
During log syncing, when we start updating the log root tree we compute
an index value, stored in variable 'index2', once we lock the log root
tree's mutex. This value depends on the log root's log_transid. And
shortly after we compute again the same value for 'index2' - the value
is exactly the same since we haven't released the mutex and therefore
the log_transid of the log root is the same as before.

This second 'index2' computation became pointless after commit
a93e01682e28 ("btrfs: remove no longer needed use of log_writers for the
log root tree"). So remove it.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tree-log.c

index 8b3893c01734bb291ca9004c99af6415890cd6d7..6c7e7e723e3ab9205d324e72567d07dcb8be7e9c 100644 (file)
@@ -3016,7 +3016,6 @@ int btrfs_sync_log(struct btrfs_trans_handle *trans,
                goto out;
        }
 
-       index2 = root_log_ctx.log_transid % 2;
        if (atomic_read(&log_root_tree->log_commit[index2])) {
                blk_finish_plug(&plug);
                ret = btrfs_wait_tree_log_extents(log, mark);