]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: timers: Fix abs() warning in posix_timers test
authorJohn Stultz <jstultz@google.com>
Wed, 10 Apr 2024 23:26:30 +0000 (16:26 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Fri, 12 Apr 2024 12:11:15 +0000 (14:11 +0200)
Building with clang results in the following warning:

  posix_timers.c:69:6: warning: absolute value function 'abs' given an
      argument of type 'long long' but has parameter of type 'int' which may
      cause truncation of value [-Wabsolute-value]
        if (abs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) {
            ^
So switch to using llabs() instead.

Fixes: 0bc4b0cf1570 ("selftests: add basic posix timers selftests")
Signed-off-by: John Stultz <jstultz@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20240410232637.4135564-3-jstultz@google.com
tools/testing/selftests/timers/posix_timers.c

index 348f47176e0a34b9c71122cedd6a26a21dc7925e..c001dd79179d5d28e51d69cbad4c7e9a6a026053 100644 (file)
@@ -66,7 +66,7 @@ static int check_diff(struct timeval start, struct timeval end)
        diff = end.tv_usec - start.tv_usec;
        diff += (end.tv_sec - start.tv_sec) * USECS_PER_SEC;
 
-       if (abs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) {
+       if (llabs(diff - DELAY * USECS_PER_SEC) > USECS_PER_SEC / 2) {
                printf("Diff too high: %lld..", diff);
                return -1;
        }