]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
d_alloc_parallel(): in-lookup hash insertion doesn't need an RCU variant
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 12 Nov 2023 05:38:02 +0000 (00:38 -0500)
committerAl Viro <viro@zeniv.linux.org.uk>
Sat, 25 Nov 2023 07:50:24 +0000 (02:50 -0500)
We only search in the damn thing under hlist_bl_lock(); RCU variant
of insertion was, IIRC, pretty much cargo-culted - mea culpa...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/dcache.c

index 8473c8f0ce229cbaf4ffe569d18fb0040fbd6434..82d0861857035fa63f25f1fa2784918842a19005 100644 (file)
@@ -2692,7 +2692,7 @@ retry:
        /* we can't take ->d_lock here; it's OK, though. */
        new->d_flags |= DCACHE_PAR_LOOKUP;
        new->d_wait = wq;
-       hlist_bl_add_head_rcu(&new->d_u.d_in_lookup_hash, b);
+       hlist_bl_add_head(&new->d_u.d_in_lookup_hash, b);
        hlist_bl_unlock(b);
        return new;
 mismatch: