]> git.ipfire.org Git - thirdparty/mdadm.git/commit
systemd/mdadm-last-resort: use ConditionPathExists instead of Conflicts
authorNeilBrown <neilb@suse.com>
Thu, 20 Apr 2017 02:40:05 +0000 (12:40 +1000)
committerJes Sorensen <jsorensen@fb.com>
Thu, 20 Apr 2017 16:57:27 +0000 (12:57 -0400)
commit5c4b3b9aa9f576305b36d5ccbd4b929b51307ce9
treea7232b5be01db53060685a7c2f994f6685f63bdd
parenta250ce240f245df594570a5e25398680d403af67
systemd/mdadm-last-resort: use ConditionPathExists instead of Conflicts

Commit cec72c071bbe ("systemd/mdadm-last-resort: add Conflicts to .service file.")

added a 'Conflicts' directive to the mdadm-last-resort@.service file in
the hope that this would make sure the service didn't run after the device
was active, even if the timer managed to get started, which is possible in
race conditions.

This seemed to work is testing, but it isn't clear why, and it is known
to cause problems.
If systemd happens to know that the mentioned device is a dependency of a
mount point, the Conflicts can unmount that mountpoint, which is certainly
not wanted.

So remove the "Conflicts" and instead use
 ConditionPathExists=!/sys/devices/virtual/block/%i/md/sync_action

The "sync_action" file exists for any array which requires last-resort
handling, and only appears when the array is activated.  So it is safe
to rely on it to determine if the last-resort is really needed.

Fixes: cec72c071bbe ("systemd/mdadm-last-resort: add Conflicts to .service file.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jes Sorensen <jsorensen@fb.com>
systemd/mdadm-last-resort@.service