]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core.git/commitdiff
cracklib: Modify patch to compile with GCC 14 master
authorZoltan Boszormenyi <zboszor@gmail.com>
Mon, 29 Apr 2024 10:29:59 +0000 (12:29 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 30 Apr 2024 21:20:13 +0000 (22:20 +0100)
GCC 14 implicitly turns a warning into a compiler error:

| ../../git/src/lib/packlib.c: In function ‘PWClose’:
| ../../git/src/lib/packlib.c:554:40: error: passing argument 1 of ‘HwmsHostToBigEndian’ from incompatible pointer type [-Wincompatible-pointer-types]
|   554 |             HwmsHostToBigEndian(tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32);
|       |                                 ~~~~~~~^~~~~
|       |                                        |
|       |                                        uint32_t * {aka unsigned int *}
| ../../git/src/lib/packlib.c:142:27: note: expected ‘char *’ but argument is of type ‘uint32_t *’ {aka ‘unsigned int *’}
|   142 | HwmsHostToBigEndian(char *pHwms, int nLen,int nBitType)
|       |                     ~~~~~~^~~~~

Add the cast to (char *) to silence it.

Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-extended/cracklib/cracklib/0001-packlib.c-support-dictionary-byte-order-dependent.patch

index 20572b55c4ccbc5e552b6b67dc3b35d24e8dbb73..35229ae8900eef0f3f5f84ca6bca1d7064c1d70d 100644 (file)
@@ -303,7 +303,7 @@ index 9396e1d..d0bb181 100644
 +          PWDICT tmp_pwp;
 +
 +          memcpy(&tmp_pwp, pwp, sizeof(PWDICT));
-+          HwmsHostToBigEndian(tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32);
++          HwmsHostToBigEndian((char *)tmp_pwp.hwms, sizeof(tmp_pwp.hwms), en_is32);
 +          fwrite(tmp_pwp.hwms, 1, sizeof(tmp_pwp.hwms), pwp->wfp);
        }
      }