tparam_on_enc_ext(): Remove dead code in cleanup

Fixes Coverity 1548382

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22606)

diff --git a/test/quicapitest.c b/test/quicapitest.c
index 77c9598c698b916c7800fef5642dd3f1df02a5a5..41cf0fc7a87ead0ed948634ab3863b49ba1f5578 100644 (file)
--- a/test/quicapitest.c
+++ b/test/quicapitest.c
@@ -1994,12 +1994,8 @@ static int tparam_on_enc_ext(QTEST_FAULT *qtf, QTEST_ENCRYPTED_EXTENSIONS *ee,
 
     rc = 1;
 err:
-    if (have_wpkt) {
-        if (rc)
-            WPACKET_finish(&wpkt);
-        else
-            WPACKET_cleanup(&wpkt);
-    }
+    if (have_wpkt)
+        WPACKET_cleanup(&wpkt);
     BUF_MEM_free(old_bufm);
     BUF_MEM_free(new_bufm);
     return rc;