]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Remove redundant logic for DTLS server version selection
authorFrederik Wedel-Heinen <frederik.wedel-heinen@dencrypt.dk>
Tue, 12 Dec 2023 11:58:01 +0000 (12:58 +0100)
committerMatt Caswell <matt@openssl.org>
Mon, 18 Dec 2023 09:56:34 +0000 (09:56 +0000)
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22989)

ssl/statem/statem_srvr.c

index b0f700dda40f1ad919fd96561758b290538037ba..da77c16e6b288bdf58beb10939a4fe09e22d3206 100644 (file)
@@ -1734,16 +1734,9 @@ static int tls_early_post_process_client_hello(SSL_CONNECTION *s)
         /* SSLv3/TLS */
         s->client_version = clienthello->legacy_version;
     }
-    /*
-     * Do SSL/TLS version negotiation if applicable.
-     */
-    if (SSL_CONNECTION_IS_DTLS(s)
-            && ssl->method->version != DTLS_ANY_VERSION
-            && DTLS_VERSION_LT((int)clienthello->legacy_version, s->version)) {
-        protverr = SSL_R_VERSION_TOO_LOW;
-    } else {
-        protverr = ssl_choose_server_version(s, clienthello, &dgrd);
-    }
+
+    /* Choose the server SSL/TLS/DTLS version. */
+    protverr = ssl_choose_server_version(s, clienthello, &dgrd);
 
     if (protverr) {
         if (SSL_IS_FIRST_HANDSHAKE(s)) {