]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Postpone two TODO(QUIC) items appropriately
authorTomas Mraz <tomas@openssl.org>
Tue, 17 Oct 2023 06:58:22 +0000 (08:58 +0200)
committerMatt Caswell <matt@openssl.org>
Fri, 20 Oct 2023 15:29:18 +0000 (16:29 +0100)
The one in ch_rx_handle_packet() is a tuning thing -> QUIC FUTURE
The one in ossl_quic_tserver_shutdown() is a server thing -> QUIC SERVER

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22408)

ssl/quic/quic_channel.c
ssl/quic/quic_tserver.c

index 0462fd241103946f6ffa51e05cf7995943cf66fe..3b9993b96adb57d370dcbb31235bd91d4fc6dde3 100644 (file)
@@ -2302,7 +2302,7 @@ static void ch_rx_handle_packet(QUIC_CHANNEL *ch)
              * non-zero Token Length field MUST either discard the packet or
              * generate a connection error of type PROTOCOL_VIOLATION.
              *
-             * TODO(QUIC): consider the implications of RFC 9000 s. 10.2.3
+             * TODO(QUIC FUTURE): consider the implications of RFC 9000 s. 10.2.3
              * Immediate Close during the Handshake:
              *      However, at the cost of reducing feedback about
              *      errors for legitimate peers, some forms of denial of
index 3630577e707b918affe75a4c9a3a2edbd998808c..3fc51b4a778aa1202a58a44106b60f73888e3bd7 100644 (file)
@@ -508,7 +508,7 @@ int ossl_quic_tserver_shutdown(QUIC_TSERVER *srv, uint64_t app_error_code)
 {
     ossl_quic_channel_local_close(srv->ch, app_error_code, NULL);
 
-    /* TODO(QUIC): !SSL_SHUTDOWN_FLAG_NO_STREAM_FLUSH */
+    /* TODO(QUIC SERVER): !SSL_SHUTDOWN_FLAG_NO_STREAM_FLUSH */
 
     if (ossl_quic_channel_is_terminated(srv->ch))
         return 1;