Most of the callers do not actually check for
the special -1 return condition because they do not
pass NULL to it. It is also extremely improbable that
any code depends on this -1 return value in this condition
so it can be safely changed to 0 return.
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Ben Kaduk <kaduk@mit.edu>
(Merged from https://github.com/openssl/openssl/pull/22930)
*Neil Horman*
+ * OPENSSL_sk_push() and sk_<TYPE>_push() functions now return 0 instead of -1
+ if called with a NULL stack argument.
+
+ *Tomáš Mráz*
+
* In `openssl speed`, changed the default hash function used with `hmac` from
`md5` to `sha256`.
int OPENSSL_sk_push(OPENSSL_STACK *st, const void *data)
{
if (st == NULL)
- return -1;
+ return 0;
return OPENSSL_sk_insert(st, data, st->num);
}
B<sk_I<TYPE>_insert>(), B<sk_I<TYPE>_push>() and B<sk_I<TYPE>_unshift>() return
the total number of elements in the stack and 0 if an error occurred.
-B<sk_I<TYPE>_push>() further returns -1 if I<sk> is NULL.
B<sk_I<TYPE>_set>() returns a pointer to the replacement element or NULL on
error.
stack. To avoid any performance implications this change introduces,
B<sk_I<TYPE>_sort>() should be called before these find operations.
+Before OpenSSL 3.3.0 B<sk_I<TYPE>_push>() returned -1 if I<sk> was NULL. It
+was changed to return 0 in this condition as for other errors.
+
=head1 COPYRIGHT
Copyright 2000-2023 The OpenSSL Project Authors. All Rights Reserved.