]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
Linux: do not change --txqueuelen OS default if not configured.
authorGert Doering <gert@greenie.muc.de>
Mon, 29 Jun 2020 18:04:05 +0000 (20:04 +0200)
committerGert Doering <gert@greenie.muc.de>
Mon, 29 Jun 2020 20:54:14 +0000 (22:54 +0200)
Remove default setting of "set txqueuelen to 100".  This default dates
back to the "pre git" times (before 2005) and might have been beneficial
back then - nowadays, the Linux default is 500, and thus reducing(!)
txqueuelen by-default can cause TX packet drops on the tun interface,
and that's bad for throughput.

This is a similar change to commit f0b64e5dc (remove setting of the
socket send/receive buffers by default) - similar vintage of the
existing code, similar motivation.

Note: buffer length can be checked with "ip link show" (qlen NNN)

See also:
  https://ivanvari.com/solving-openvpn-poor-throughput-and-packet-loss/

Signed-off-by: Gert Doering <gert@greenie.muc.de>
Acked-by: Arne Schwabe <arne@rfc2549.org>
Message-Id: <20200629180405.17671-1-gert@greenie.muc.de>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20160.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/options.c

index 34e2bfd3dbdd67546d061b8b1293cfc35f746bdb..2073b4a6647dd3d1f225f4221d65ab64e446fe06 100644 (file)
@@ -844,9 +844,6 @@ init_options(struct options *o, const bool init_gc)
 #ifdef ENABLE_FEATURE_TUN_PERSIST
     o->persist_mode = 1;
 #endif
-#ifdef TARGET_LINUX
-    o->tuntap_options.txqueuelen = 100;
-#endif
 #ifdef _WIN32
 #if 0
     o->tuntap_options.ip_win32_type = IPW32_SET_ADAPTIVE;