dumresp: Use the correct return type for recvfrom()

Otherwise we can't correctly process error codes.
Reported by Coverity (CID 1401645).

diff --git a/pdns/dumresp.cc b/pdns/dumresp.cc
index 354eba7461bb2172d0f6d587e8ea1d2108c8429c..5d457dc47f6f0888fb416571ca5eb333967c1b30 100644 (file)
--- a/pdns/dumresp.cc
+++ b/pdns/dumresp.cc
@@ -202,12 +202,12 @@ try
   auto dh = reinterpret_cast<struct dnsheader*>(buffer);
 
   for(;;) {
-    uint16_t len = recvfrom(s.getHandle(), buffer, sizeof(buffer), 0, reinterpret_cast<struct sockaddr*>(&rem), &socklen);
+    ssize_t len = recvfrom(s.getHandle(), buffer, sizeof(buffer), 0, reinterpret_cast<struct sockaddr*>(&rem), &socklen);
 
     if(len < 0)
       unixDie("recvfrom");
 
-    if (len < sizeof(dnsheader))
+    if (static_cast<size_t>(len) < sizeof(dnsheader))
       unixDie("too small " + std::to_string(len));
 
     if(dh->qr)