There were a number of styles for this exception object.
This enforces a single style (const, space before &).
cout <<", "<< ntohs(dh->arcount) <<");\n";
}
- catch(MOADNSException& mde) {
+ catch(const MOADNSException &mde) {
// cerr<<"error parsing packet: "<<mde.what()<<endl;
continue;
}
lastreport = pr.d_pheader.ts;
}
}
- catch(MOADNSException& mde) {
+ catch(const MOADNSException &mde) {
// cerr<<"error parsing packet: "<<mde.what()<<endl;
parseErrors++;
continue;
measureResultAndClean(iter);
}
}
- catch(MOADNSException &e)
+ catch(const MOADNSException &mde)
{
s_wednserrors++;
}
}
}
}
- catch(MOADNSException &e)
+ catch(const MOADNSException &mde)
{
if(!g_quiet)
- cerr<<"Error parsing packet: "<<e.what()<<endl;
+ cerr<<"Error parsing packet: "<<mde.what()<<endl;
s_idmanager.releaseID(qd.d_assignedID); // not added to qids for cleanup
s_origdnserrors++;
}
counts[mdp.d_qtype]++;
}
- catch(MOADNSException &e) {
- cout<<"Error from remote "<<pr.getSource().toString()<<": "<<e.what()<<"\n";
+ catch(const MOADNSException &mde) {
+ cout<<"Error from remote "<<pr.getSource().toString()<<": "<<mde.what()<<"\n";
// sock.sendTo(string(pr.d_payload, pr.d_payload + pr.d_len), remote);
}
}
}
- catch(MOADNSException& mde) {
+ catch(const MOADNSException &mde) {
if(verbose)
cout<<"error parsing packet: "<<mde.what()<<endl;
if(pw)
} /* if (mdp.d_qtype == QType::IXFR) */
shutdown(cfd, 2);
- } catch (MOADNSException &e) {
- g_log<<Logger::Warning<<prefix<<"Could not parse DNS packet from "<<saddr.toStringWithPort()<<": "<<e.what()<<endl;
+ } catch (const MOADNSException &mde) {
+ g_log<<Logger::Warning<<prefix<<"Could not parse DNS packet from "<<saddr.toStringWithPort()<<": "<<mde.what()<<endl;
} catch (runtime_error &e) {
g_log<<Logger::Warning<<prefix<<"Could not write reply to "<<saddr.toStringWithPort()<<": "<<e.what()<<endl;
}
g_log<<Logger::Error<<"startDoResolve problem "<<makeLoginfo(dc)<<": "<<ae.reason<<endl;
delete dc;
}
- catch(MOADNSException& e) {
- g_log<<Logger::Error<<"DNS parser error "<<makeLoginfo(dc) <<": "<<dc->d_mdp.d_qname<<", "<<e.what()<<endl;
+ catch(const MOADNSException &mde) {
+ g_log<<Logger::Error<<"DNS parser error "<<makeLoginfo(dc) <<": "<<dc->d_mdp.d_qname<<", "<<mde.what()<<endl;
delete dc;
}
catch(std::exception& e) {
try {
dc=new DNSComboWriter(conn->data, g_now);
}
- catch(MOADNSException &mde) {
+ catch(const MOADNSException &mde) {
g_stats.clientParseError++;
if(g_logCommonErrors)
g_log<<Logger::Error<<"Unable to parse packet from TCP client "<< conn->d_remote.toStringWithPort() <<endl;
}
}
}
- catch(const MOADNSException& mde) {
+ catch(const MOADNSException &mde) {
g_stats.clientParseError++;
if(g_logCommonErrors) {
g_log<<Logger::Error<<"Unable to parse packet from remote UDP client "<<fromaddr.toString() <<": "<<mde.what()<<endl;
di.backend->abortTransaction();
}
}
- catch(MOADNSException &re) {
- g_log<<Logger::Error<<"Unable to parse record during incoming AXFR of '"<<domain<<"' (MOADNSException): "<<re.what()<<endl;
+ catch(const MOADNSException &mde) {
+ g_log<<Logger::Error<<"Unable to parse record during incoming AXFR of '"<<domain<<"' (MOADNSException): "<<mde.what()<<endl;
if(di.backend && transaction) {
g_log<<Logger::Error<<"Aborting possible open transaction for domain '"<<domain<<"' AXFR"<<endl;
di.backend->abortTransaction();