]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Use initializer list for ConnectionInfo
authorRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 10 Apr 2019 10:23:49 +0000 (12:23 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 10 Apr 2019 12:26:49 +0000 (14:26 +0200)
Reported by cppcheck.

pdns/dnsdist-tcp.cc

index 878f056a02ec68844874abe230a466a4ab65eb43..1c51cdc16cab584b5df2f00c31c1262a877c61d0 100644 (file)
@@ -209,12 +209,9 @@ struct ConnectionInfo
   ConnectionInfo(ClientState* cs_): cs(cs_), fd(-1)
   {
   }
-  ConnectionInfo(ConnectionInfo&& rhs)
+  ConnectionInfo(ConnectionInfo&& rhs): remote(rhs.remote), cs(rhs.cs), fd(rhs.fd)
   {
-    remote = rhs.remote;
-    cs = rhs.cs;
     rhs.cs = nullptr;
-    fd = rhs.fd;
     rhs.fd = -1;
   }