Check the result of the dynamic pointer cast in getSerialFromRecords()

Reported by Coverity (CID 1401665).

diff --git a/pdns/ixfrutils.cc b/pdns/ixfrutils.cc
index e20cfe666be4244db1bc436287e6e5e0deb602e6..9ff93bbabf397eada632cc6b6f0ee467bb3819f3 100644 (file)
--- a/pdns/ixfrutils.cc
+++ b/pdns/ixfrutils.cc
@@ -99,8 +99,10 @@ uint32_t getSerialFromRecords(const records_t& records, DNSRecord& soaret)
 
   for(auto iter = found.first; iter != found.second; ++iter) {
     auto soa = std::dynamic_pointer_cast<SOARecordContent>(iter->d_content);
-    soaret = *iter;
-    return soa->d_st.serial;
+    if (soa) {
+      soaret = *iter;
+      return soa->d_st.serial;
+    }
   }
   return 0;
 }