]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
rec: dnspython's API changed wrt NSID, apply (version dependent) fix in regression... 13813/head
authorOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 19 Feb 2024 10:05:32 +0000 (11:05 +0100)
committerOtto Moerbeek <otto.moerbeek@open-xchange.com>
Mon, 19 Feb 2024 10:30:12 +0000 (11:30 +0100)
See https://dnspython.readthedocs.io/en/stable/whatsnew.html 2.6.0 2nd bullet

regression-tests.recursor-dnssec/test_ServerNames.py

index e130a3d0dde037266a734e1c379f86b5c13d4f15..79dfd0060ee9da046ec27fa0bab0b9645a2196ec 100644 (file)
@@ -108,7 +108,10 @@ version-string=%s
         response = self.sendUDPQuery(query)
 
         self.assertEqual(len(response.options), 1)
-        self.assertEqual(response.options[0].data, self._servername.encode('ascii'))
+        if dns.version.MAJOR < 2 or (dns.version.MAJOR == 2 and dns.version.MINOR < 6):
+            self.assertEqual(response.options[0].data, self._servername.encode('ascii'))
+        else:
+            self.assertEqual(response.options[0].to_text(), 'NSID ' + self._servername)
 
     def testNSIDTCP(self):
         """
@@ -119,4 +122,7 @@ version-string=%s
         response = self.sendTCPQuery(query)
 
         self.assertEqual(len(response.options), 1)
-        self.assertEqual(response.options[0].data, self._servername.encode('ascii'))
+        if dns.version.MAJOR < 2 or (dns.version.MAJOR == 2 and dns.version.MINOR < 6):
+            self.assertEqual(response.options[0].data, self._servername.encode('ascii'))
+        else:
+            self.assertEqual(response.options[0].to_text(), 'NSID ' + self._servername)