rec: Fix 'loop variable [...] creates a copy' warnings

Reported by clang++ 10.

diff --git a/pdns/filterpo.cc b/pdns/filterpo.cc
index 087be580a5d35091d1822a56fd35ce84b76b8fb3..2de0102ac21b383648b6a80eeb3170cc24df0229 100644 (file)
--- a/pdns/filterpo.cc
+++ b/pdns/filterpo.cc
@@ -626,15 +626,15 @@ void DNSFilterEngine::Zone::dump(FILE* fp) const
     dumpNamedPolicy(fp, pair.first + DNSName("rpz-nsdname.") + d_domain, pair.second);
   }
 
-  for (const auto pair : d_qpolAddr) {
+  for (const auto& pair : d_qpolAddr) {
     dumpAddrPolicy(fp, pair.first, DNSName("rpz-client-ip.") + d_domain, pair.second);
   }
 
-  for (const auto pair : d_propolNSAddr) {
+  for (const auto& pair : d_propolNSAddr) {
     dumpAddrPolicy(fp, pair.first, DNSName("rpz-nsip.") + d_domain, pair.second);
   }
 
-  for (const auto pair : d_postpolAddr) {
+  for (const auto& pair : d_postpolAddr) {
     dumpAddrPolicy(fp, pair.first, DNSName("rpz-ip.") + d_domain, pair.second);
   }
 }

diff --git a/pdns/recursordist/test-syncres_cc.cc b/pdns/recursordist/test-syncres_cc.cc
index f7a06bb1a4f9809c621675f5ce218483e2f88c7b..1eec4369cd65065f81fa54aa4e38716a094f56b9 100644 (file)
--- a/pdns/recursordist/test-syncres_cc.cc
+++ b/pdns/recursordist/test-syncres_cc.cc
@@ -279,7 +279,7 @@ bool addRRSIG(const testkeysset_t& keys, std::vector<DNSRecord>& records, const
   const uint16_t type = records[recordsCount - 1].d_type;
 
   sortedRecords_t recordcontents;
-  for (const auto record : records) {
+  for (const auto& record : records) {
     if (record.d_name == name && record.d_type == type) {
       recordcontents.insert(record.d_content);
     }