]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/rdma/vmw/pvrdma_dev_ring: Replace strncpy with pstrcpy
authorJulia Suvorova <jusual@redhat.com>
Wed, 18 Mar 2020 13:48:49 +0000 (14:48 +0100)
committerMarcel Apfelbaum <marcel.apfelbaum@gmail.com>
Sat, 21 Mar 2020 17:13:12 +0000 (19:13 +0200)
ring->name is defined as 'char name[MAX_RING_NAME_SZ]'. Replace untruncated
strncpy with QEMU function.
This case prevented QEMU from compiling with --enable-sanitizers.

Signed-off-by: Julia Suvorova <jusual@redhat.com>
Message-Id: <20200318134849.237011-1-jusual@redhat.com>
Reviewed-by: Yuval Shaia <yuval.shaia.ml.gmail.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
hw/rdma/vmw/pvrdma_dev_ring.c

index d7bc7f5ccc8afaec536ce59545fe2b23d9348f36..c2b3dd70a9bf940b4213e71ce86e0224b98cb74f 100644 (file)
@@ -16,6 +16,7 @@
 #include "qemu/osdep.h"
 #include "hw/pci/pci.h"
 #include "cpu.h"
+#include "qemu/cutils.h"
 
 #include "trace.h"
 
@@ -30,8 +31,7 @@ int pvrdma_ring_init(PvrdmaRing *ring, const char *name, PCIDevice *dev,
     int i;
     int rc = 0;
 
-    strncpy(ring->name, name, MAX_RING_NAME_SZ);
-    ring->name[MAX_RING_NAME_SZ - 1] = 0;
+    pstrcpy(ring->name, MAX_RING_NAME_SZ, name);
     ring->dev = dev;
     ring->ring_state = ring_state;
     ring->max_elems = max_elems;