]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
s390x/sclp: fix maxram calculation
authorChristian Borntraeger <borntraeger@de.ibm.com>
Mon, 30 Jul 2018 14:09:26 +0000 (16:09 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Tue, 31 Jul 2018 16:27:16 +0000 (11:27 -0500)
We clamp down ram_size to match the sclp increment size. We do
not do the same for maxram_size, which means for large guests
with some sizes (e.g. -m 50000) maxram_size differs from ram_size.
This can break other code (e.g. CMMA migration) which uses maxram_size
to calculate the number of pages and then throws some errors.

Fixes: 82fab5c5b90e468f3e9d54c ("s390x/sclp: remove memory hotplug support")
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
CC: qemu-stable@nongnu.org
CC: David Hildenbrand <david@redhat.com>
Message-Id: <1532959766-53343-1-git-send-email-borntraeger@de.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
(cherry picked from commit 408e5ace517ff18c9c7cd918fc93358162e6e26d)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/s390x/sclp.c

index 047d577313e3e495f7fadf1d0e755f166f3f9c3e..2abdb62ef4e331aa1e61108642d4d1971c798787 100644 (file)
@@ -319,6 +319,7 @@ static void sclp_memory_init(SCLPDevice *sclp)
     initial_mem = initial_mem >> increment_size << increment_size;
 
     machine->ram_size = initial_mem;
+    machine->maxram_size = initial_mem;
     /* let's propagate the changed ram size into the global variable. */
     ram_size = initial_mem;
 }