]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
ppc/spapr_events: fix potential NULL pointer dereference in rtas_event_log_dequeue
authorPanNengyuan <pannengyuan@huawei.com>
Mon, 25 Nov 2019 12:34:51 +0000 (20:34 +0800)
committerDavid Gibson <david@gibson.dropbear.id.au>
Mon, 25 Nov 2019 23:12:58 +0000 (10:12 +1100)
This fixes coverity issues 68911917:
        360
    CID 68911917: (NULL_RETURNS)
        361. dereference: Dereferencing "source", which is known to be
             "NULL".
        361        if (source->mask & event_mask) {
        362            break;
        363        }

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: PanNengyuan <pannengyuan@huawei.com>
Message-Id: <1574685291-38176-1-git-send-email-pannengyuan@huawei.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr_events.c

index 0e4c19523aea8163e0d3e636427d41dfd913d79f..e355e000d07698dea8b36bef8f102e589c47c5d1 100644 (file)
@@ -358,6 +358,7 @@ static SpaprEventLogEntry *rtas_event_log_dequeue(SpaprMachineState *spapr,
             rtas_event_log_to_source(spapr,
                                      spapr_event_log_entry_type(entry));
 
+        g_assert(source);
         if (source->mask & event_mask) {
             break;
         }