]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
qcow2: Set MIN_L2_CACHE_SIZE to 2
authorMax Reitz <mreitz@redhat.com>
Mon, 1 Jun 2015 16:09:17 +0000 (18:09 +0200)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 29 Jul 2015 23:26:34 +0000 (18:26 -0500)
The L2 cache must cover at least two L2 tables, because during COW two
L2 tables are accessed simultaneously.

Reported-by: Alexander Graf <agraf@suse.de>
Cc: qemu-stable <qemu-stable@nongnu.org>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Tested-by: Alexander Graf <agraf@suse.de>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 57e216695948a79d9ced82fc217a37cce70fd986)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/qcow2.h

index 422b8251385ca3b955e1e261be5cc00574042eb7..2f20949593cde6629a1eb998ad87655f25c54080 100644 (file)
@@ -62,7 +62,8 @@
 #define MIN_CLUSTER_BITS 9
 #define MAX_CLUSTER_BITS 21
 
-#define MIN_L2_CACHE_SIZE 1 /* cluster */
+/* Must be at least 2 to cover COW */
+#define MIN_L2_CACHE_SIZE 2 /* clusters */
 
 /* Must be at least 4 to cover all cases of refcount table growth */
 #define MIN_REFCOUNT_CACHE_SIZE 4 /* clusters */