It was being done so that the second one prints errors without races.
However, the same thing can be achieved by passing -Orecurse to make(1).
And this makes the logs even more readable, since there's no racy output
at all.
Fixes: 97f79e3b2715 ("CI: Make build logs more readable")
Link: <https://github.com/shadow-maint/shadow/pull/702>
Link: <https://github.com/nginx/unit/pull/1123>
Acked-by: Iker Pedrosa <ipedrosa@redhat.com>
Cc: Andrew Clayton <a.clayton@nginx.com>
Cc: Konstantin Pavlov <thresh@nginx.com>
Cc: Dylan Arbour <https://github.com/arbourd>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
- name: Build shadow-utils
run: |
PROCESSORS=$(/usr/bin/getconf _NPROCESSORS_ONLN)
- make -kj$PROCESSORS || true
-
- - name: Check build errors
- run: make
+ make -Orecurse -j$PROCESSORS
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
--disable-man \
--disable-nls \
--with-yescrypt
-RUN make -kj4 || true
-RUN make
+RUN make -Orecurse -j4
RUN bash -c "trap 'cat <tests/unit/test-suite.log >&2' ERR; make check;"
RUN make install
--without-selinux \
--enable-man \
--with-yescrypt
-RUN make -kj4 || true
-RUN make
+RUN make -Orecurse -j4
RUN bash -c "trap 'cat <tests/unit/test-suite.log >&2' ERR; make check;"
RUN make install
--with-group-name-max-length=32 \
--enable-lastlog \
--enable-logind=no
-RUN make -kj4 || true
-RUN make
+RUN make -Orecurse -j4
RUN bash -c "trap 'cat <tests/unit/test-suite.log >&2' ERR; make check;"
RUN make install