Merge in SNORT/snort3 from ~UMASHARM/snort3:coverity_fixes to master
Squashed commit of the following:
commit
f005a9908950f50692dc4ce1dba83c7b406da8eb
Author: Umang Sharma <umasharm@cisco.com>
Date: Fri Dec 8 11:40:39 2023 -0500
appid: fixes for coverity issues
switch (fd->state)
{
case TNS_STATE_MESSAGE_LEN:
+ if (fd->pos >= 2)
+ break;
+
fd->l.raw_len[fd->pos++] = args.data[offset];
if (fd->pos >= offsetof(ClientTNSMsg, checksum))
{
fd->state = TNS_STATE_MESSAGE_CONNECT_OFFSET;
break;
case TNS_STATE_MESSAGE_CONNECT_OFFSET:
+ if (fd->pos >= CONNECT_DATA_OFFSET + 2)
+ break;
fd->l.raw_len[fd->pos - CONNECT_DATA_OFFSET] = args.data[offset];
fd->pos++;
- if (fd->pos >= (CONNECT_DATA_OFFSET + 2))
+ if (fd->pos == (CONNECT_DATA_OFFSET + 2))
{
fd->offsetlen = ntohs(fd->l.len);
if (fd->offsetlen > args.size)