]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Complain about malformed 64bit header values, not the valid ones.
authorAlex Rousskov <rousskov@measurement-factory.com>
Fri, 27 Jan 2017 13:28:31 +0000 (02:28 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Fri, 27 Jan 2017 13:28:31 +0000 (02:28 +1300)
Added this regression in r14819, apparently confused by my own
unfortunate "bad is true" httpHeaderNoteParsedEntry(error) API.

src/HttpHeader.cc

index 2acc70228f639cc85a761956ef15e08c38807bde..1733ab6490134b43d31d8e8ee677d8e8e976af3b 100644 (file)
@@ -1467,7 +1467,7 @@ HttpHeaderEntry::getInt64() const
 {
     int64_t val = -1;
     const bool ok = httpHeaderParseOffset(value.termedBuf(), &val);
-    httpHeaderNoteParsedEntry(id, value, ok);
+    httpHeaderNoteParsedEntry(id, value, !ok);
     return val; // remains -1 if !ok (XXX: bad method API)
 }