src/resolve/resolved-dns-trust-anchor.c

   1 /* SPDX-License-Identifier: LGPL-2.1+ */
   2
   3 #include "sd-messages.h"
   4
   5 #include "alloc-util.h"
   6 #include "conf-files.h"
   7 #include "def.h"
   8 #include "dns-domain.h"
   9 #include "fd-util.h"
  10 #include "fileio.h"
  11 #include "hexdecoct.h"
  12 #include "parse-util.h"
  13 #include "resolved-dns-trust-anchor.h"
  14 #include "resolved-dns-dnssec.h"
  15 #include "set.h"
  16 #include "string-util.h"
  17 #include "strv.h"
  18
  19 static const char trust_anchor_dirs[] = CONF_PATHS_NULSTR("dnssec-trust-anchors.d");
  20
  21 /* The first DS RR from https://data.iana.org/root-anchors/root-anchors.xml, retrieved December 2015 */
  22 static const uint8_t root_digest1[] =
  23         { 0x49, 0xAA, 0xC1, 0x1D, 0x7B, 0x6F, 0x64, 0x46, 0x70, 0x2E, 0x54, 0xA1, 0x60, 0x73, 0x71, 0x60,
  24           0x7A, 0x1A, 0x41, 0x85, 0x52, 0x00, 0xFD, 0x2C, 0xE1, 0xCD, 0xDE, 0x32, 0xF2, 0x4E, 0x8F, 0xB5 };
  25
  26 /* The second DS RR from https://data.iana.org/root-anchors/root-anchors.xml, retrieved February 2017 */
  27 static const uint8_t root_digest2[] =
  28         { 0xE0, 0x6D, 0x44, 0xB8, 0x0B, 0x8F, 0x1D, 0x39, 0xA9, 0x5C, 0x0B, 0x0D, 0x7C, 0x65, 0xD0, 0x84,
  29           0x58, 0xE8, 0x80, 0x40, 0x9B, 0xBC, 0x68, 0x34, 0x57, 0x10, 0x42, 0x37, 0xC7, 0xF8, 0xEC, 0x8D };
  30
  31 static bool dns_trust_anchor_knows_domain_positive(DnsTrustAnchor *d, const char *name) {
  32         assert(d);
  33
  34         /* Returns true if there's an entry for the specified domain
  35          * name in our trust anchor */
  36
  37         return
  38                 hashmap_contains(d->positive_by_key, &DNS_RESOURCE_KEY_CONST(DNS_CLASS_IN, DNS_TYPE_DNSKEY, name)) ||
  39                 hashmap_contains(d->positive_by_key, &DNS_RESOURCE_KEY_CONST(DNS_CLASS_IN, DNS_TYPE_DS, name));
  40 }
  41
  42 static int add_root_ksk(
  43                 DnsAnswer *answer,
  44                 DnsResourceKey *key,
  45                 uint16_t key_tag,
  46                 uint8_t algorithm,
  47                 uint8_t digest_type,
  48                 const void *digest,
  49                 size_t digest_size) {
  50
  51         _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL;
  52         int r;
  53
  54         rr = dns_resource_record_new(key);
  55         if (!rr)
  56                 return -ENOMEM;
  57
  58         rr->ds.key_tag = key_tag;
  59         rr->ds.algorithm = algorithm;
  60         rr->ds.digest_type = digest_type;
  61         rr->ds.digest_size = digest_size;
  62         rr->ds.digest = memdup(digest, rr->ds.digest_size);
  63         if (!rr->ds.digest)
  64                 return  -ENOMEM;
  65
  66         r = dns_answer_add(answer, rr, 0, DNS_ANSWER_AUTHENTICATED);
  67         if (r < 0)
  68                 return r;
  69
  70         return 0;
  71 }
  72
  73 static int dns_trust_anchor_add_builtin_positive(DnsTrustAnchor *d) {
  74         _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL;
  75         _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL;
  76         int r;
  77
  78         assert(d);
  79
  80         r = hashmap_ensure_allocated(&d->positive_by_key, &dns_resource_key_hash_ops);
  81         if (r < 0)
  82                 return r;
  83
  84         /* Only add the built-in trust anchor if there's neither a DS nor a DNSKEY defined for the root domain. That
  85          * way users have an easy way to override the root domain DS/DNSKEY data. */
  86         if (dns_trust_anchor_knows_domain_positive(d, "."))
  87                 return 0;
  88
  89         key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_DS, "");
  90         if (!key)
  91                 return -ENOMEM;
  92
  93         answer = dns_answer_new(2);
  94         if (!answer)
  95                 return -ENOMEM;
  96
  97         /* Add the two RRs from https://data.iana.org/root-anchors/root-anchors.xml */
  98         r = add_root_ksk(answer, key, 19036, DNSSEC_ALGORITHM_RSASHA256, DNSSEC_DIGEST_SHA256, root_digest1, sizeof(root_digest1));
  99         if (r < 0)
 100                 return r;
 101
 102         r = add_root_ksk(answer, key, 20326, DNSSEC_ALGORITHM_RSASHA256, DNSSEC_DIGEST_SHA256, root_digest2, sizeof(root_digest2));
 103         if (r < 0)
 104                 return r;
 105
 106         r = hashmap_put(d->positive_by_key, key, answer);
 107         if (r < 0)
 108                 return r;
 109
 110         answer = NULL;
 111         return 0;
 112 }
 113
 114 static int dns_trust_anchor_add_builtin_negative(DnsTrustAnchor *d) {
 115
 116         static const char private_domains[] =
 117                 /* RFC 6761 says that .test is a special domain for
 118                  * testing and not to be installed in the root zone */
 119                 "test\0"
 120
 121                 /* RFC 6761 says that these reverse IP lookup ranges
 122                  * are for private addresses, and hence should not
 123                  * show up in the root zone */
 124                 "10.in-addr.arpa\0"
 125                 "16.172.in-addr.arpa\0"
 126                 "17.172.in-addr.arpa\0"
 127                 "18.172.in-addr.arpa\0"
 128                 "19.172.in-addr.arpa\0"
 129                 "20.172.in-addr.arpa\0"
 130                 "21.172.in-addr.arpa\0"
 131                 "22.172.in-addr.arpa\0"
 132                 "23.172.in-addr.arpa\0"
 133                 "24.172.in-addr.arpa\0"
 134                 "25.172.in-addr.arpa\0"
 135                 "26.172.in-addr.arpa\0"
 136                 "27.172.in-addr.arpa\0"
 137                 "28.172.in-addr.arpa\0"
 138                 "29.172.in-addr.arpa\0"
 139                 "30.172.in-addr.arpa\0"
 140                 "31.172.in-addr.arpa\0"
 141                 "168.192.in-addr.arpa\0"
 142
 143                 /* The same, but for IPv6. */
 144                 "d.f.ip6.arpa\0"
 145
 146                 /* RFC 6762 reserves the .local domain for Multicast
 147                  * DNS, it hence cannot appear in the root zone. (Note
 148                  * that we by default do not route .local traffic to
 149                  * DNS anyway, except when a configured search domain
 150                  * suggests so.) */
 151                 "local\0"
 152
 153                 /* These two are well known, popular private zone
 154                  * TLDs, that are blocked from delegation, according
 155                  * to:
 156                  * http://icannwiki.com/Name_Collision#NGPC_Resolution
 157                  *
 158                  * There's also ongoing work on making this official
 159                  * in an RRC:
 160                  * https://www.ietf.org/archive/id/draft-chapin-additional-reserved-tlds-02.txt */
 161                 "home\0"
 162                 "corp\0"
 163
 164                 /* The following four TLDs are suggested for private
 165                  * zones in RFC 6762, Appendix G, and are hence very
 166                  * unlikely to be made official TLDs any day soon */
 167                 "lan\0"
 168                 "intranet\0"
 169                 "internal\0"
 170                 "private\0";
 171
 172         const char *name;
 173         int r;
 174
 175         assert(d);
 176
 177         /* Only add the built-in trust anchor if there's no negative
 178          * trust anchor defined at all. This enables easy overriding
 179          * of negative trust anchors. */
 180
 181         if (set_size(d->negative_by_name) > 0)
 182                 return 0;
 183
 184         r = set_ensure_allocated(&d->negative_by_name, &dns_name_hash_ops);
 185         if (r < 0)
 186                 return r;
 187
 188         /* We add a couple of domains as default negative trust
 189          * anchors, where it's very unlikely they will be installed in
 190          * the root zone. If they exist they must be private, and thus
 191          * unsigned. */
 192
 193         NULSTR_FOREACH(name, private_domains) {
 194
 195                 if (dns_trust_anchor_knows_domain_positive(d, name))
 196                         continue;
 197
 198                 r = set_put_strdup(d->negative_by_name, name);
 199                 if (r < 0)
 200                         return r;
 201         }
 202
 203         return 0;
 204 }
 205
 206 static int dns_trust_anchor_load_positive(DnsTrustAnchor *d, const char *path, unsigned line, const char *s) {
 207         _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL;
 208         _cleanup_free_ char *domain = NULL, *class = NULL, *type = NULL;
 209         _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL;
 210         DnsAnswer *old_answer = NULL;
 211         const char *p = s;
 212         int r;
 213
 214         assert(d);
 215         assert(line);
 216
 217         r = extract_first_word(&p, &domain, NULL, EXTRACT_QUOTES);
 218         if (r < 0)
 219                 return log_warning_errno(r, "Unable to parse domain in line %s:%u: %m", path, line);
 220
 221         r = dns_name_is_valid(domain);
 222         if (r < 0)
 223                 return log_warning_errno(r, "Failed to chack validity of domain name '%s', at line %s:%u, ignoring line: %m", domain, path, line);
 224         if (r == 0) {
 225                 log_warning("Domain name %s is invalid, at line %s:%u, ignoring line.", domain, path, line);
 226                 return -EINVAL;
 227         }
 228
 229         r = extract_many_words(&p, NULL, 0, &class, &type, NULL);
 230         if (r < 0)
 231                 return log_warning_errno(r, "Unable to parse class and type in line %s:%u: %m", path, line);
 232         if (r != 2) {
 233                 log_warning("Missing class or type in line %s:%u", path, line);
 234                 return -EINVAL;
 235         }
 236
 237         if (!strcaseeq(class, "IN")) {
 238                 log_warning("RR class %s is not supported, ignoring line %s:%u.", class, path, line);
 239                 return -EINVAL;
 240         }
 241
 242         if (strcaseeq(type, "DS")) {
 243                 _cleanup_free_ char *key_tag = NULL, *algorithm = NULL, *digest_type = NULL;
 244                 _cleanup_free_ void *dd = NULL;
 245                 uint16_t kt;
 246                 int a, dt;
 247                 size_t l;
 248
 249                 r = extract_many_words(&p, NULL, 0, &key_tag, &algorithm, &digest_type, NULL);
 250                 if (r < 0) {
 251                         log_warning_errno(r, "Failed to parse DS parameters on line %s:%u: %m", path, line);
 252                         return -EINVAL;
 253                 }
 254                 if (r != 3) {
 255                         log_warning("Missing DS parameters on line %s:%u", path, line);
 256                         return -EINVAL;
 257                 }
 258
 259                 r = safe_atou16(key_tag, &kt);
 260                 if (r < 0)
 261                         return log_warning_errno(r, "Failed to parse DS key tag %s on line %s:%u: %m", key_tag, path, line);
 262
 263                 a = dnssec_algorithm_from_string(algorithm);
 264                 if (a < 0) {
 265                         log_warning("Failed to parse DS algorithm %s on line %s:%u", algorithm, path, line);
 266                         return -EINVAL;
 267                 }
 268
 269                 dt = dnssec_digest_from_string(digest_type);
 270                 if (dt < 0) {
 271                         log_warning("Failed to parse DS digest type %s on line %s:%u", digest_type, path, line);
 272                         return -EINVAL;
 273                 }
 274
 275                 if (isempty(p)) {
 276                         log_warning("Missing DS digest on line %s:%u", path, line);
 277                         return -EINVAL;
 278                 }
 279
 280                 r = unhexmem(p, strlen(p), &dd, &l);
 281                 if (r < 0) {
 282                         log_warning("Failed to parse DS digest %s on line %s:%u", p, path, line);
 283                         return -EINVAL;
 284                 }
 285
 286                 rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DS, domain);
 287                 if (!rr)
 288                         return log_oom();
 289
 290                 rr->ds.key_tag = kt;
 291                 rr->ds.algorithm = a;
 292                 rr->ds.digest_type = dt;
 293                 rr->ds.digest_size = l;
 294                 rr->ds.digest = TAKE_PTR(dd);
 295
 296         } else if (strcaseeq(type, "DNSKEY")) {
 297                 _cleanup_free_ char *flags = NULL, *protocol = NULL, *algorithm = NULL;
 298                 _cleanup_free_ void *k = NULL;
 299                 uint16_t f;
 300                 size_t l;
 301                 int a;
 302
 303                 r = extract_many_words(&p, NULL, 0, &flags, &protocol, &algorithm, NULL);
 304                 if (r < 0)
 305                         return log_warning_errno(r, "Failed to parse DNSKEY parameters on line %s:%u: %m", path, line);
 306                 if (r != 3) {
 307                         log_warning("Missing DNSKEY parameters on line %s:%u", path, line);
 308                         return -EINVAL;
 309                 }
 310
 311                 if (!streq(protocol, "3")) {
 312                         log_warning("DNSKEY Protocol is not 3 on line %s:%u", path, line);
 313                         return -EINVAL;
 314                 }
 315
 316                 r = safe_atou16(flags, &f);
 317                 if (r < 0)
 318                         return log_warning_errno(r, "Failed to parse DNSKEY flags field %s on line %s:%u", flags, path, line);
 319                 if ((f & DNSKEY_FLAG_ZONE_KEY) == 0) {
 320                         log_warning("DNSKEY lacks zone key bit set on line %s:%u", path, line);
 321                         return -EINVAL;
 322                 }
 323                 if ((f & DNSKEY_FLAG_REVOKE)) {
 324                         log_warning("DNSKEY is already revoked on line %s:%u", path, line);
 325                         return -EINVAL;
 326                 }
 327
 328                 a = dnssec_algorithm_from_string(algorithm);
 329                 if (a < 0) {
 330                         log_warning("Failed to parse DNSKEY algorithm %s on line %s:%u", algorithm, path, line);
 331                         return -EINVAL;
 332                 }
 333
 334                 if (isempty(p)) {
 335                         log_warning("Missing DNSKEY key on line %s:%u", path, line);
 336                         return -EINVAL;
 337                 }
 338
 339                 r = unbase64mem(p, strlen(p), &k, &l);
 340                 if (r < 0)
 341                         return log_warning_errno(r, "Failed to parse DNSKEY key data %s on line %s:%u", p, path, line);
 342
 343                 rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNSKEY, domain);
 344                 if (!rr)
 345                         return log_oom();
 346
 347                 rr->dnskey.flags = f;
 348                 rr->dnskey.protocol = 3;
 349                 rr->dnskey.algorithm = a;
 350                 rr->dnskey.key_size = l;
 351                 rr->dnskey.key = TAKE_PTR(k);
 352
 353         } else {
 354                 log_warning("RR type %s is not supported, ignoring line %s:%u.", type, path, line);
 355                 return -EINVAL;
 356         }
 357
 358         r = hashmap_ensure_allocated(&d->positive_by_key, &dns_resource_key_hash_ops);
 359         if (r < 0)
 360                 return log_oom();
 361
 362         old_answer = hashmap_get(d->positive_by_key, rr->key);
 363         answer = dns_answer_ref(old_answer);
 364
 365         r = dns_answer_add_extend(&answer, rr, 0, DNS_ANSWER_AUTHENTICATED);
 366         if (r < 0)
 367                 return log_error_errno(r, "Failed to add trust anchor RR: %m");
 368
 369         r = hashmap_replace(d->positive_by_key, rr->key, answer);
 370         if (r < 0)
 371                 return log_error_errno(r, "Failed to add answer to trust anchor: %m");
 372
 373         old_answer = dns_answer_unref(old_answer);
 374         answer = NULL;
 375
 376         return 0;
 377 }
 378
 379 static int dns_trust_anchor_load_negative(DnsTrustAnchor *d, const char *path, unsigned line, const char *s) {
 380         _cleanup_free_ char *domain = NULL;
 381         const char *p = s;
 382         int r;
 383
 384         assert(d);
 385         assert(line);
 386
 387         r = extract_first_word(&p, &domain, NULL, EXTRACT_QUOTES);
 388         if (r < 0)
 389                 return log_warning_errno(r, "Unable to parse line %s:%u: %m", path, line);
 390
 391         r = dns_name_is_valid(domain);
 392         if (r < 0)
 393                 return log_warning_errno(r, "Failed to chack validity of domain name '%s', at line %s:%u, ignoring line: %m", domain, path, line);
 394         if (r == 0) {
 395                 log_warning("Domain name %s is invalid, at line %s:%u, ignoring line.", domain, path, line);
 396                 return -EINVAL;
 397         }
 398
 399         if (!isempty(p)) {
 400                 log_warning("Trailing garbage at line %s:%u, ignoring line.", path, line);
 401                 return -EINVAL;
 402         }
 403
 404         r = set_ensure_allocated(&d->negative_by_name, &dns_name_hash_ops);
 405         if (r < 0)
 406                 return log_oom();
 407
 408         r = set_put(d->negative_by_name, domain);
 409         if (r < 0)
 410                 return log_oom();
 411         if (r > 0)
 412                 domain = NULL;
 413
 414         return 0;
 415 }
 416
 417 static int dns_trust_anchor_load_files(
 418                 DnsTrustAnchor *d,
 419                 const char *suffix,
 420                 int (*loader)(DnsTrustAnchor *d, const char *path, unsigned n, const char *line)) {
 421
 422         _cleanup_strv_free_ char **files = NULL;
 423         char **f;
 424         int r;
 425
 426         assert(d);
 427         assert(suffix);
 428         assert(loader);
 429
 430         r = conf_files_list_nulstr(&files, suffix, NULL, 0, trust_anchor_dirs);
 431         if (r < 0)
 432                 return log_error_errno(r, "Failed to enumerate %s trust anchor files: %m", suffix);
 433
 434         STRV_FOREACH(f, files) {
 435                 _cleanup_fclose_ FILE *g = NULL;
 436                 unsigned n = 0;
 437
 438                 g = fopen(*f, "r");
 439                 if (!g) {
 440                         if (errno == ENOENT)
 441                                 continue;
 442
 443                         log_warning_errno(errno, "Failed to open '%s', ignoring: %m", *f);
 444                         continue;
 445                 }
 446
 447                 for (;;) {
 448                         _cleanup_free_ char *line = NULL;
 449                         char *l;
 450
 451                         r = read_line(g, LONG_LINE_MAX, &line);
 452                         if (r < 0) {
 453                                 log_warning_errno(r, "Failed to read '%s', ignoring: %m", *f);
 454                                 break;
 455                         }
 456                         if (r == 0)
 457                                 break;
 458
 459                         n++;
 460
 461                         l = strstrip(line);
 462                         if (isempty(l))
 463                                 continue;
 464
 465                         if (*l == ';')
 466                                 continue;
 467
 468                         (void) loader(d, *f, n, l);
 469                 }
 470         }
 471
 472         return 0;
 473 }
 474
 475 static int domain_name_cmp(char * const *a, char * const *b) {
 476         return dns_name_compare_func(*a, *b);
 477 }
 478
 479 static int dns_trust_anchor_dump(DnsTrustAnchor *d) {
 480         DnsAnswer *a;
 481         Iterator i;
 482
 483         assert(d);
 484
 485         if (hashmap_isempty(d->positive_by_key))
 486                 log_info("No positive trust anchors defined.");
 487         else {
 488                 log_info("Positive Trust Anchors:");
 489                 HASHMAP_FOREACH(a, d->positive_by_key, i) {
 490                         DnsResourceRecord *rr;
 491
 492                         DNS_ANSWER_FOREACH(rr, a)
 493                                 log_info("%s", dns_resource_record_to_string(rr));
 494                 }
 495         }
 496
 497         if (set_isempty(d->negative_by_name))
 498                 log_info("No negative trust anchors defined.");
 499         else {
 500                 _cleanup_free_ char **l = NULL, *j = NULL;
 501
 502                 l = set_get_strv(d->negative_by_name);
 503                 if (!l)
 504                         return log_oom();
 505
 506                 typesafe_qsort(l, set_size(d->negative_by_name), domain_name_cmp);
 507
 508                 j = strv_join(l, " ");
 509                 if (!j)
 510                         return log_oom();
 511
 512                 log_info("Negative trust anchors: %s", j);
 513         }
 514
 515         return 0;
 516 }
 517
 518 int dns_trust_anchor_load(DnsTrustAnchor *d) {
 519         int r;
 520
 521         assert(d);
 522
 523         /* If loading things from disk fails, we don't consider this fatal */
 524         (void) dns_trust_anchor_load_files(d, ".positive", dns_trust_anchor_load_positive);
 525         (void) dns_trust_anchor_load_files(d, ".negative", dns_trust_anchor_load_negative);
 526
 527         /* However, if the built-in DS fails, then we have a problem. */
 528         r = dns_trust_anchor_add_builtin_positive(d);
 529         if (r < 0)
 530                 return log_error_errno(r, "Failed to add built-in positive trust anchor: %m");
 531
 532         r = dns_trust_anchor_add_builtin_negative(d);
 533         if (r < 0)
 534                 return log_error_errno(r, "Failed to add built-in negative trust anchor: %m");
 535
 536         dns_trust_anchor_dump(d);
 537
 538         return 0;
 539 }
 540
 541 void dns_trust_anchor_flush(DnsTrustAnchor *d) {
 542         assert(d);
 543
 544         d->positive_by_key = hashmap_free_with_destructor(d->positive_by_key, dns_answer_unref);
 545         d->revoked_by_rr = set_free_with_destructor(d->revoked_by_rr, dns_resource_record_unref);
 546         d->negative_by_name = set_free_free(d->negative_by_name);
 547 }
 548
 549 int dns_trust_anchor_lookup_positive(DnsTrustAnchor *d, const DnsResourceKey *key, DnsAnswer **ret) {
 550         DnsAnswer *a;
 551
 552         assert(d);
 553         assert(key);
 554         assert(ret);
 555
 556         /* We only serve DS and DNSKEY RRs. */
 557         if (!IN_SET(key->type, DNS_TYPE_DS, DNS_TYPE_DNSKEY))
 558                 return 0;
 559
 560         a = hashmap_get(d->positive_by_key, key);
 561         if (!a)
 562                 return 0;
 563
 564         *ret = dns_answer_ref(a);
 565         return 1;
 566 }
 567
 568 int dns_trust_anchor_lookup_negative(DnsTrustAnchor *d, const char *name) {
 569         int r;
 570
 571         assert(d);
 572         assert(name);
 573
 574         for (;;) {
 575                 /* If the domain is listed as-is in the NTA database, then that counts */
 576                 if (set_contains(d->negative_by_name, name))
 577                         return true;
 578
 579                 /* If the domain isn't listed as NTA, but is listed as positive trust anchor, then that counts. See RFC
 580                  * 7646, section 1.1 */
 581                 if (hashmap_contains(d->positive_by_key, &DNS_RESOURCE_KEY_CONST(DNS_CLASS_IN, DNS_TYPE_DS, name)))
 582                         return false;
 583
 584                 if (hashmap_contains(d->positive_by_key, &DNS_RESOURCE_KEY_CONST(DNS_CLASS_IN, DNS_TYPE_KEY, name)))
 585                         return false;
 586
 587                 /* And now, let's look at the parent, and check that too */
 588                 r = dns_name_parent(&name);
 589                 if (r < 0)
 590                         return r;
 591                 if (r == 0)
 592                         break;
 593         }
 594
 595         return false;
 596 }
 597
 598 static int dns_trust_anchor_revoked_put(DnsTrustAnchor *d, DnsResourceRecord *rr) {
 599         int r;
 600
 601         assert(d);
 602
 603         r = set_ensure_allocated(&d->revoked_by_rr, &dns_resource_record_hash_ops);
 604         if (r < 0)
 605                 return r;
 606
 607         r = set_put(d->revoked_by_rr, rr);
 608         if (r < 0)
 609                 return r;
 610         if (r > 0)
 611                 dns_resource_record_ref(rr);
 612
 613         return r;
 614 }
 615
 616 static int dns_trust_anchor_remove_revoked(DnsTrustAnchor *d, DnsResourceRecord *rr) {
 617         _cleanup_(dns_answer_unrefp) DnsAnswer *new_answer = NULL;
 618         DnsAnswer *old_answer;
 619         int r;
 620
 621         /* Remember that this is a revoked trust anchor RR */
 622         r = dns_trust_anchor_revoked_put(d, rr);
 623         if (r < 0)
 624                 return r;
 625
 626         /* Remove this from the positive trust anchor */
 627         old_answer = hashmap_get(d->positive_by_key, rr->key);
 628         if (!old_answer)
 629                 return 0;
 630
 631         new_answer = dns_answer_ref(old_answer);
 632
 633         r = dns_answer_remove_by_rr(&new_answer, rr);
 634         if (r <= 0)
 635                 return r;
 636
 637         /* We found the key! Warn the user */
 638         log_struct(LOG_WARNING,
 639                    "MESSAGE_ID=" SD_MESSAGE_DNSSEC_TRUST_ANCHOR_REVOKED_STR,
 640                    LOG_MESSAGE("DNSSEC trust anchor %s has been revoked.\n"
 641                                "Please update the trust anchor, or upgrade your operating system.",
 642                                strna(dns_resource_record_to_string(rr))),
 643                    "TRUST_ANCHOR=%s", dns_resource_record_to_string(rr));
 644
 645         if (dns_answer_size(new_answer) <= 0) {
 646                 assert_se(hashmap_remove(d->positive_by_key, rr->key) == old_answer);
 647                 dns_answer_unref(old_answer);
 648                 return 1;
 649         }
 650
 651         r = hashmap_replace(d->positive_by_key, new_answer->items[0].rr->key, new_answer);
 652         if (r < 0)
 653                 return r;
 654
 655         new_answer = NULL;
 656         dns_answer_unref(old_answer);
 657         return 1;
 658 }
 659
 660 static int dns_trust_anchor_check_revoked_one(DnsTrustAnchor *d, DnsResourceRecord *revoked_dnskey) {
 661         DnsAnswer *a;
 662         int r;
 663
 664         assert(d);
 665         assert(revoked_dnskey);
 666         assert(revoked_dnskey->key->type == DNS_TYPE_DNSKEY);
 667         assert(revoked_dnskey->dnskey.flags & DNSKEY_FLAG_REVOKE);
 668
 669         a = hashmap_get(d->positive_by_key, revoked_dnskey->key);
 670         if (a) {
 671                 DnsResourceRecord *anchor;
 672
 673                 /* First, look for the precise DNSKEY in our trust anchor database */
 674
 675                 DNS_ANSWER_FOREACH(anchor, a) {
 676
 677                         if (anchor->dnskey.protocol != revoked_dnskey->dnskey.protocol)
 678                                 continue;
 679
 680                         if (anchor->dnskey.algorithm != revoked_dnskey->dnskey.algorithm)
 681                                 continue;
 682
 683                         if (anchor->dnskey.key_size != revoked_dnskey->dnskey.key_size)
 684                                 continue;
 685
 686                         /* Note that we allow the REVOKE bit to be
 687                          * different! It will be set in the revoked
 688                          * key, but unset in our version of it */
 689                         if (((anchor->dnskey.flags ^ revoked_dnskey->dnskey.flags) | DNSKEY_FLAG_REVOKE) != DNSKEY_FLAG_REVOKE)
 690                                 continue;
 691
 692                         if (memcmp(anchor->dnskey.key, revoked_dnskey->dnskey.key, anchor->dnskey.key_size) != 0)
 693                                 continue;
 694
 695                         dns_trust_anchor_remove_revoked(d, anchor);
 696                         break;
 697                 }
 698         }
 699
 700         a = hashmap_get(d->positive_by_key, &DNS_RESOURCE_KEY_CONST(revoked_dnskey->key->class, DNS_TYPE_DS, dns_resource_key_name(revoked_dnskey->key)));
 701         if (a) {
 702                 DnsResourceRecord *anchor;
 703
 704                 /* Second, look for DS RRs matching this DNSKEY in our trust anchor database */
 705
 706                 DNS_ANSWER_FOREACH(anchor, a) {
 707
 708                         /* We set mask_revoke to true here, since our
 709                          * DS fingerprint will be the one of the
 710                          * unrevoked DNSKEY, but the one we got passed
 711                          * here has the bit set. */
 712                         r = dnssec_verify_dnskey_by_ds(revoked_dnskey, anchor, true);
 713                         if (r < 0)
 714                                 return r;
 715                         if (r == 0)
 716                                 continue;
 717
 718                         dns_trust_anchor_remove_revoked(d, anchor);
 719                         break;
 720                 }
 721         }
 722
 723         return 0;
 724 }
 725
 726 int dns_trust_anchor_check_revoked(DnsTrustAnchor *d, DnsResourceRecord *dnskey, DnsAnswer *rrs) {
 727         DnsResourceRecord *rrsig;
 728         int r;
 729
 730         assert(d);
 731         assert(dnskey);
 732
 733         /* Looks if "dnskey" is a self-signed RR that has been revoked
 734          * and matches one of our trust anchor entries. If so, removes
 735          * it from the trust anchor and returns > 0. */
 736
 737         if (dnskey->key->type != DNS_TYPE_DNSKEY)
 738                 return 0;
 739
 740         /* Is this DNSKEY revoked? */
 741         if ((dnskey->dnskey.flags & DNSKEY_FLAG_REVOKE) == 0)
 742                 return 0;
 743
 744         /* Could this be interesting to us at all? If not,
 745          * there's no point in looking for and verifying a
 746          * self-signed RRSIG. */
 747         if (!dns_trust_anchor_knows_domain_positive(d, dns_resource_key_name(dnskey->key)))
 748                 return 0;
 749
 750         /* Look for a self-signed RRSIG in the other rrs belonging to this DNSKEY */
 751         DNS_ANSWER_FOREACH(rrsig, rrs) {
 752                 DnssecResult result;
 753
 754                 if (rrsig->key->type != DNS_TYPE_RRSIG)
 755                         continue;
 756
 757                 r = dnssec_rrsig_match_dnskey(rrsig, dnskey, true);
 758                 if (r < 0)
 759                         return r;
 760                 if (r == 0)
 761                         continue;
 762
 763                 r = dnssec_verify_rrset(rrs, dnskey->key, rrsig, dnskey, USEC_INFINITY, &result);
 764                 if (r < 0)
 765                         return r;
 766                 if (result != DNSSEC_VALIDATED)
 767                         continue;
 768
 769                 /* Bingo! This is a revoked self-signed DNSKEY. Let's
 770                  * see if this precise one exists in our trust anchor
 771                  * database, too. */
 772                 r = dns_trust_anchor_check_revoked_one(d, dnskey);
 773                 if (r < 0)
 774                         return r;
 775
 776                 return 1;
 777         }
 778
 779         return 0;
 780 }
 781
 782 int dns_trust_anchor_is_revoked(DnsTrustAnchor *d, DnsResourceRecord *rr) {
 783         assert(d);
 784
 785         if (!IN_SET(rr->key->type, DNS_TYPE_DS, DNS_TYPE_DNSKEY))
 786                 return 0;
 787
 788         return set_contains(d->revoked_by_rr, rr);
 789 }