]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
fuzz: check return value
authorYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 22 Jan 2018 00:55:38 +0000 (09:55 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 22 Jan 2018 00:55:38 +0000 (09:55 +0900)
Closes CID #1385306 and #1385300.

src/fuzz/fuzz-dns-packet.c

index 3d8d79a42df765666c4e7de9c70a4f1d9b6890ed..0f25081b22e6c77916c8bb47726279e1cd302bd2 100644 (file)
 
 int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) {
         _cleanup_(dns_packet_unrefp) DnsPacket *p = NULL;
-        int r;
 
         if (size > DNS_PACKET_SIZE_MAX)
                 return 0;
 
-        r = dns_packet_new(&p, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX);
-        if (r < 0)
-                return 0;
+        assert_se(dns_packet_new(&p, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX) >= 0);
         p->size = 0; /* by default append starts after the header, undo that */
-        dns_packet_append_blob(p, data, size, NULL);
+        assert_se(dns_packet_append_blob(p, data, size, NULL) >= 0);
         if (size < DNS_PACKET_HEADER_SIZE) {
                 /* make sure we pad the packet back up to the minimum header size */
-                assert(p->allocated >= DNS_PACKET_HEADER_SIZE);
+                assert_se(p->allocated >= DNS_PACKET_HEADER_SIZE);
                 memzero(DNS_PACKET_DATA(p) + size, DNS_PACKET_HEADER_SIZE - size);
                 p->size = DNS_PACKET_HEADER_SIZE;
         }
-        dns_packet_extract(p);
+        (void) dns_packet_extract(p);
 
         return 0;
 }