]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: print an error when networkctl returns an unexpected EC 13225/head
authorFrantisek Sumsal <frantisek@sumsal.cz>
Tue, 30 Jul 2019 18:27:34 +0000 (20:27 +0200)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Wed, 31 Jul 2019 14:33:12 +0000 (16:33 +0200)
If networkctl crashes, like recently with SIGABRT, it returns absolutely
no output, which may be confusing during debugging. Help it a little
with a short informative message.

test/networkd-test.py

index c971570346cd94b988fd2e4d0dd94f207155c60e..beb3bd9e1df03395539136cac06922b2815c4b57 100755 (executable)
@@ -420,7 +420,9 @@ DHCP={}
             subprocess.call(['ip', 'a', 'show', 'dev', self.iface])
             print('---- networkctl status {} ----'.format(self.iface))
             sys.stdout.flush()
-            subprocess.call(['networkctl', 'status', self.iface])
+            rc = subprocess.call(['networkctl', 'status', self.iface])
+            if rc != 0:
+                print("'networkctl status' exited with an unexpected code {}".format(rc))
             self.show_journal('systemd-networkd.service')
             self.print_server_log()
             raise