]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
system-update-generator: do not emit bogus warning if no /system-update symlink
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 7 Jun 2019 09:49:03 +0000 (11:49 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Wed, 12 Jun 2019 15:27:17 +0000 (17:27 +0200)
We only need to check for the kernel cmdline override our symlink is there.

src/system-update-generator/system-update-generator.c

index 77e265d71076ca7328e7c5c6e2a9f37e5c5af387..6ec4986c10ce70b21345f4afb5b325fdecaebfdc 100644 (file)
@@ -57,9 +57,10 @@ static int run(const char *dest, const char *dest_early, const char *dest_late)
         assert_se(arg_dest = dest_early);
 
         r = generate_symlink();
-        if (r < 0)
+        if (r <= 0)
                 return r;
 
+        /* We parse the command line only to emit warnings. */
         r = proc_cmdline_parse(parse_proc_cmdline_item, NULL, 0);
         if (r < 0)
                 log_warning_errno(r, "Failed to parse kernel command line, ignoring: %m");