]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: require at least version 3.6.0 of GnuTLS for DNS-over-TLS
authorIwan Timmer <irtimmer@gmail.com>
Tue, 29 Oct 2019 19:26:05 +0000 (20:26 +0100)
committerIwan Timmer <irtimmer@gmail.com>
Tue, 29 Oct 2019 19:26:05 +0000 (20:26 +0100)
Increase the required version to ensure TLS 1.3 is always supported when using GnuTLS for DNS-over-TLS and allow further changes to use recent API additions.

README
meson.build
src/resolve/resolved-dnstls-gnutls.c

diff --git a/README b/README
index 8aa16fe8c906d6474a5751520bb1d614b2b2df52..8dbf94b49cd4b35e906f46b31bab3b3a5877f6f8 100644 (file)
--- a/README
+++ b/README
@@ -155,7 +155,7 @@ REQUIREMENTS:
         libmicrohttpd (optional)
         libpython (optional)
         libidn2 or libidn (optional)
-        gnutls >= 3.1.4 (optional, >= 3.5.3 is required to support DNS-over-TLS with gnutls)
+        gnutls >= 3.1.4 (optional, >= 3.6.0 is required to support DNS-over-TLS with gnutls)
         openssl >= 1.1.0 (optional, required to support DNS-over-TLS with openssl)
         elfutils >= 158 (optional)
         polkit (optional)
index 0001504d53e4f45987bb18b54fc50cf59516ca96..a7a92225829e9be6bc5442c8bad3737ad83d2804 100644 (file)
@@ -1199,7 +1199,7 @@ if dns_over_tls != 'false'
         if dns_over_tls == 'openssl'
                 have_gnutls = false
         else
-                have_gnutls = (conf.get('HAVE_GNUTLS') == 1 and libgnutls.version().version_compare('>= 3.5.3'))
+                have_gnutls = (conf.get('HAVE_GNUTLS') == 1 and libgnutls.version().version_compare('>= 3.6.0'))
                 if dns_over_tls == 'gnutls' and not have_gnutls
                         error('DNS-over-TLS support was requested with gnutls, but dependencies are not available')
                 endif
index 7ad96620732bc21604268ad84c14024e1618363f..ea276d2c20fd24957b15c24981e3db8e66d22b45 100644 (file)
@@ -9,11 +9,7 @@
 #include "resolved-dns-stream.h"
 #include "resolved-dnstls.h"
 
-#if GNUTLS_VERSION_NUMBER >= 0x030600
 #define PRIORTY_STRING "NORMAL:-VERS-ALL:+VERS-TLS1.3:+VERS-TLS1.2"
-#else
-#define PRIORTY_STRING "NORMAL:-VERS-ALL:+VERS-TLS1.2"
-#endif
 DEFINE_TRIVIAL_CLEANUP_FUNC(gnutls_session_t, gnutls_deinit);
 
 static ssize_t dnstls_stream_writev(gnutls_transport_ptr_t p, const giovec_t *iov, int iovcnt) {