logind: create the session fifo before saving the session file

If the session fifo is not created the session state written to
the session file is "closing". This caused the lock screen in
gnome-shell to go into a loop trying to find the active session.

The problem was introduced in the sd-bus port in
cc3773810855956bad92337cee8fa193584ab62e

Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=71525

diff --git a/src/login/logind-session-dbus.c b/src/login/logind-session-dbus.c
index 167d2ab8b4da98b43691e89d604ad6ee56f89d5f..fa9c0039f4748d3131e4a2d08791d57b1c6f2e1b 100644 (file)
--- a/src/login/logind-session-dbus.c
+++ b/src/login/logind-session-dbus.c
@@ -644,14 +644,14 @@ int session_send_create_reply(Session *s, sd_bus_error *error) {
         if (error)
                 return sd_bus_reply_method_error(s->manager->bus, c, error);
 
-        /* Update the session state file before we notify the client
-         * about the result. */
-        session_save(s);
-
         fifo_fd = session_create_fifo(s);
         if (fifo_fd < 0)
                 return fifo_fd;
 
+        /* Update the session state file before we notify the client
+         * about the result. */
+        session_save(s);
+
         p = session_bus_path(s);
         if (!p)
                 return -ENOMEM;