return 1;
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_warning_errno(link, r, "could not set address label: %m");
- else if (r >= 0)
- manager_rtnl_process_address(rtnl, m, link->manager);
+ link_enter_failed(link);
+ return 1;
+ } else if (r >= 0)
+ (void) manager_rtnl_process_address(rtnl, m, link->manager);
if (link->address_label_messages == 0)
log_link_debug(link, "Addresses label set");
log_link_error_errno(link, r, "Could not set DHCPv4 address: %m");
link_enter_failed(link);
return 1;
- }
- if (r >= 0)
- manager_rtnl_process_address(rtnl, m, link->manager);
+ } else if (r >= 0)
+ (void) manager_rtnl_process_address(rtnl, m, link->manager);
r = link_set_dhcp_routes(link);
if (r < 0) {
}
/* Add back static routes since kernel removes while DHCPv4 address is removed from when lease expires */
- link_request_set_routes(link);
+ r = link_request_set_routes(link);
+ if (r < 0) {
+ link_enter_failed(link);
+ return 1;
+ }
if (link->dhcp4_messages == 0) {
link->dhcp4_configured = true;
assert(link);
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
if (r < 0)
log_link_debug_errno(link, r, "Received error on unreachable route removal for DHCPv6 delegated subnet: %m");
assert(link);
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST)
log_link_debug_errno(link, r, "Received error when adding unreachable route for DHCPv6 delegated subnet: %m");
return 1;
assert(link);
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
if (r < 0 && r != -EEXIST) {
if (link->rtnl_extended_attrs) {
return 1;
}
if (r >= 0)
- manager_rtnl_process_address(rtnl, m, link->manager);
+ (void) manager_rtnl_process_address(rtnl, m, link->manager);
- link_request_set_routes(link);
+ r = link_request_set_routes(link);
+ if (r < 0) {
+ link_enter_failed(link);
+ return 1;
+ }
return 1;
}
r = address_configure(addr, link, dhcp6_address_handler, true);
if (r < 0)
- log_link_warning_errno(link, r, "Could not assign DHCPv6 address: %m");
+ return log_link_warning_errno(link, r, "Could not assign DHCPv6 address: %m");
- return r;
+ return 0;
}
static int dhcp6_lease_address_acquired(sd_dhcp6_client *client, Link *link) {
assert(link);
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_debug_errno(link, r, "Received error adding DHCPv6 Prefix Delegation route: %m");
+ link_enter_failed(link);
+ return 1;
+ }
- return 0;
+ return 1;
}
static int dhcp6_prefix_add(Manager *m, struct in6_addr *addr, Link *link) {
assert(link);
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
- if (r < 0)
+ if (r < 0) {
log_link_debug_errno(link, r, "Received error on DHCPv6 Prefix Delegation route removal: %m");
+ link_enter_failed(link);
+ return 1;
+ }
return 1;
}
assert(link);
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_error_errno(link, r, "Could not add FDB entry: %m");
+ link_enter_failed(link);
+ return 1;
+ }
return 1;
}
if (r < 0 && r != -EEXIST) {
log_link_error_errno(link, r, "could not set ipv4ll route: %m");
link_enter_failed(link);
+ return 1;
}
link->ipv4ll_route = true;
if (r < 0 && r != -EEXIST) {
log_link_error_errno(link, r, "could not set ipv4ll address: %m");
link_enter_failed(link);
+ return 1;
} else if (r >= 0)
- manager_rtnl_process_address(rtnl, m, link->manager);
+ (void) manager_rtnl_process_address(rtnl, m, link->manager);
link->ipv4ll_address = true;
}
r = routing_policy_rule_configure(rule, link, NULL);
- if (r < 0) {
- log_link_warning_errno(link, r, "Could not set routing policy rules: %m");
- link_enter_failed(link);
- return r;
- }
+ if (r < 0)
+ return log_link_warning_errno(link, r, "Could not set routing policy rules: %m");
if (r > 0)
link->routing_policy_rule_messages++;
}
return 1;
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_warning_errno(link, r, "Could not set route: %m");
+ link_enter_failed(link);
+ return 1;
+ }
if (link->route_messages == 0) {
log_link_debug(link, "Routes set");
continue;
r = route_configure(rt, link, route_handler);
- if (r < 0) {
- log_link_warning_errno(link, r, "Could not set routes: %m");
- link_enter_failed(link);
- return r;
- }
+ if (r < 0)
+ return log_link_warning_errno(link, r, "Could not set routes: %m");
if (r > 0)
link->route_messages++;
}
void link_check_ready(Link *link) {
Address *a;
Iterator i;
+ int r;
assert(link);
if (!link->addresses_ready) {
link->addresses_ready = true;
- link_request_set_routes(link);
+ r = link_request_set_routes(link);
+ if (r < 0)
+ link_enter_failed(link);
return;
}
LIST_FOREACH(neighbors, neighbor, link->network->neighbors) {
r = neighbor_configure(neighbor, link, NULL);
- if (r < 0) {
- log_link_warning_errno(link, r, "Could not set neighbor: %m");
- link_enter_failed(link);
- return r;
- }
+ if (r < 0)
+ return log_link_warning_errno(link, r, "Could not set neighbor: %m");
}
if (link->neighbor_messages == 0) {
return 1;
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_warning_errno(link, r, "could not set address: %m");
- else if (r >= 0)
- manager_rtnl_process_address(rtnl, m, link->manager);
+ link_enter_failed(link);
+ return 1;
+ } else if (r >= 0)
+ (void) manager_rtnl_process_address(rtnl, m, link->manager);
if (link->address_messages == 0) {
log_link_debug(link, "Addresses set");
update = address_get(link, ad->family, &ad->in_addr, ad->prefixlen, NULL) > 0;
r = address_configure(ad, link, address_handler, update);
- if (r < 0) {
- log_link_warning_errno(link, r, "Could not set addresses: %m");
- link_enter_failed(link);
- return r;
- }
+ if (r < 0)
+ return log_link_warning_errno(link, r, "Could not set addresses: %m");
if (r > 0)
link->address_messages++;
}
LIST_FOREACH(labels, label, link->network->address_labels) {
r = address_label_configure(label, link, NULL, false);
- if (r < 0) {
- log_link_warning_errno(link, r, "Could not set address label: %m");
- link_enter_failed(link);
- return r;
- }
+ if (r < 0)
+ return log_link_warning_errno(link, r, "Could not set address label: %m");
link->address_label_messages++;
}
start it */
if (link_dhcp4_server_enabled(link) && (link->flags & IFF_UP)) {
r = dhcp4_server_configure(link);
- if (r < 0) {
- link_enter_failed(link);
+ if (r < 0)
return r;
- }
log_link_debug(link, "Offering DHCPv4 leases");
}
return 1;
r = sd_netlink_message_get_errno(m);
- if (r < 0) {
- log_link_warning_errno(link, r, "Could not set MTU: %m");
- return 1;
- }
-
- log_link_debug(link, "Setting MTU done.");
+ if (r < 0)
+ log_link_warning_errno(link, r, "Could not set MTU, ignoring: %m");
+ else
+ log_link_debug(link, "Setting MTU done.");
- if (link->state == LINK_STATE_INITIALIZED)
- (void) link_configure_after_setting_mtu(link);
+ if (link->state == LINK_STATE_INITIALIZED) {
+ r = link_configure_after_setting_mtu(link);
+ if (r < 0)
+ link_enter_failed(link);
+ }
return 1;
}
r = sd_netlink_message_get_errno(m);
if (r < 0)
- log_link_warning_errno(link, r, "Could not set link flags: %m");
+ log_link_warning_errno(link, r, "Could not set link flags, ignoring: %m");
return 1;
}
r = sd_netlink_message_get_errno(m);
if (r < 0)
- log_link_warning_errno(link, r, "Could not set address genmode for interface: %m");
+ log_link_warning_errno(link, r, "Could not set address genmode for interface, ignoring: %m");
return 1;
}
log_link_error_errno(link, r, "Could not join netdev: %m");
link_enter_failed(link);
return 1;
- } else
- log_link_debug(link, "Joined netdev");
+ }
+
+ log_link_debug(link, "Joined netdev");
if (link->enslaving == 0) {
- link_joined(link);
+ r = link_joined(link);
+ if (r < 0)
+ link_enter_failed(link);
}
return 1;
while ((link = set_steal_first(manager->links_requesting_uuid))) {
r = link_configure(link);
if (r < 0)
- log_link_error_errno(link, r, "Failed to configure link: %m");
+ link_enter_failed(link);
}
manager->links_requesting_uuid = set_free(manager->links_requesting_uuid);
}
static int link_initialized_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link) {
- (void) link_initialized_and_synced(link);
+ int r;
+
+ r = link_initialized_and_synced(link);
+ if (r < 0)
+ link_enter_failed(link);
return 1;
}
link->ndisc_messages--;
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_error_errno(link, r, "Could not set NDisc route or address: %m");
+ link_enter_failed(link);
+ return 1;
+ }
if (link->ndisc_messages == 0) {
link->ndisc_configured = true;
- link_request_set_routes(link);
+ r = link_request_set_routes(link);
+ if (r < 0) {
+ link_enter_failed(link);
+ return 1;
+ }
link_check_ready(link);
}
link->ndisc_messages--;
+ if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
+ return 1;
+
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_error_errno(link, r, "Could not set NDisc route or address: %m");
- else if (r >= 0)
- manager_rtnl_process_address(rtnl, m, link->manager);
+ link_enter_failed(link);
+ return 1;
+ } else if (r >= 0)
+ (void) manager_rtnl_process_address(rtnl, m, link->manager);
if (link->ndisc_messages == 0) {
link->ndisc_configured = true;
- link_request_set_routes(link);
+ r = link_request_set_routes(link);
+ if (r < 0) {
+ link_enter_failed(link);
+ return 1;
+ }
link_check_ready(link);
}
r = sd_netlink_message_get_errno(m);
if (r < 0 && r != -EEXIST)
- log_link_warning_errno(link, r, "Could not set neighbor: %m");
+ /* Neighbor may not exist yet. So, do not enter failed state here. */
+ log_link_warning_errno(link, r, "Could not set neighbor, ignoring: %m");
if (link->neighbor_messages == 0) {
log_link_debug(link, "Neighbors set");
return 1;
r = sd_netlink_message_get_errno(m);
- if (r < 0 && r != -EEXIST)
+ if (r < 0 && r != -EEXIST) {
log_link_warning_errno(link, r, "Could not add routing policy rule: %m");
+ link_enter_failed(link);
+ return 1;
+ }
if (link->routing_policy_rule_messages == 0) {
log_link_debug(link, "Routing policy rule configured");