userdb: make userdb_all() always set iterator when it returns >= 0

Fixes #14868.

diff --git a/src/shared/userdb.c b/src/shared/userdb.c
index 215e17db9b6b55de4da507568d011ca505b3c22d..1f05cda26ad4ab3943ea67f2dac1463c3f8d1de0 100644 (file)
--- a/src/shared/userdb.c
+++ b/src/shared/userdb.c
@@ -700,12 +700,8 @@ int userdb_all(UserDBFlags flags, UserDBIterator **ret) {
                 setpwent();
                 iterator->nss_iterating = true;
                 goto finish;
-        }
-
-        if (!FLAGS_SET(flags, USERDB_DONT_SYNTHESIZE))
-                goto finish;
-
-        return r;
+        } else if (r < 0)
+                return r;
 
 finish:
         *ret = TAKE_PTR(iterator);