]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test: return a non-zero return code when 'nobody' user doesn't exist
authorFrantisek Sumsal <frantisek@sumsal.cz>
Mon, 6 May 2019 08:48:12 +0000 (10:48 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 6 May 2019 13:13:07 +0000 (15:13 +0200)
Lookup of a non-existing user using getpwnam() is not considered
an error, thus the `errno` is not set appropriately, causing
unexpected fails on systems, where 'nobody' user doesn't exist by
default

src/test/test-capability.c

index 6b2de66bb7ff7f7b103098bb136914272420b079..f9fae84ddeacb14c97883dc875f5163b660dff43 100644 (file)
@@ -99,7 +99,7 @@ static int setup_tests(bool *run_ambient) {
 
         nobody = getpwnam(NOBODY_USER_NAME);
         if (!nobody)
-                return log_error_errno(errno, "Could not find nobody user: %m");
+                return log_error_errno(SYNTHETIC_ERRNO(ENOENT), "Could not find nobody user: %m");
 
         test_uid = nobody->pw_uid;
         test_gid = nobody->pw_gid;