]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolve: really always initialize aux
authorRonan Pigott <ronan@rjp.ie>
Mon, 8 Apr 2024 19:45:01 +0000 (12:45 -0700)
committerDaan De Meyer <daan.j.demeyer@gmail.com>
Tue, 9 Apr 2024 07:39:49 +0000 (09:39 +0200)
dns_transaction_request_dnssec_rr was already adjusted in 400171036592,
to allow for the return parameter to be passed uninitialized. However
this codepath was missed, meaning this function could sometimes return
success without having actually set the parameter.

Fixes: 400171036592 ("resolved: minor dnssec fixups")
Fixes: 47690634f157 ("resolved: don't request the SOA for every dns label")
src/resolve/resolved-dns-transaction.c

index 392f416c98f63243430f5badc026d9a3fb509a5c..dc8b7c8ff0ff5a2f97370185488b844eb7125f10 100644 (file)
@@ -2347,9 +2347,9 @@ static int dns_transaction_request_dnssec_rr_full(DnsTransaction *t, DnsResource
                 r = dns_transaction_go(aux);
                 if (r < 0)
                         return r;
-                if (ret)
-                        *ret = aux;
         }
+        if (ret)
+                *ret = aux;
 
         return 1;
 }