]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
pam_systemd: don't use PAM_SYSTEM_ERR for something that isn't precisely a system...
authorLennart Poettering <lennart@poettering.net>
Tue, 13 Aug 2019 12:14:47 +0000 (14:14 +0200)
committerLennart Poettering <lennart@poettering.net>
Tue, 19 Nov 2019 14:26:45 +0000 (15:26 +0100)
It's not really clear which PAM errors to use for which conditions, but
something called PAM_SYSTEM_ERR should probably not be used when the
error is not the result of some system call failure.

src/login/pam_systemd.c

index 9a938c1c9b446030e235476b622ce88ca749c121..7884fa247963d4844f28c777b148fadc5f78118a 100644 (file)
@@ -660,7 +660,7 @@ _public_ PAM_EXTERN int pam_sm_open_session(
                         return PAM_SUCCESS;
                 } else {
                         pam_syslog(handle, LOG_ERR, "Failed to create session: %s", bus_error_message(&error, r));
-                        return PAM_SYSTEM_ERR;
+                        return PAM_SESSION_ERR;
                 }
         }