]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udev: do logging before setting variables to NULL
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Tue, 15 Jan 2019 07:17:44 +0000 (08:17 +0100)
committerLennart Poettering <lennart@poettering.net>
Tue, 15 Jan 2019 12:58:45 +0000 (13:58 +0100)
gcc-9 diagnoses this as an error.
Reported by Jeff Law.

src/udev/udev-rules.c

index 7d5b9b7935110d408b39b19278fdb75a61b14605..739748532f205e24dc6a6fcf47b15a364f91cafc 100644 (file)
@@ -2231,13 +2231,12 @@ int udev_rules_apply_to_event(
                         r = hashmap_put(event->seclabel_list, name, label);
                         if (r < 0)
                                 return log_oom();
-
-                        name = label = NULL;
-
                         log_device_debug(dev, "SECLABEL{%s}='%s' %s:%u",
                                          name, label,
                                          rules_str(rules, rule->rule.filename_off),
                                          rule->rule.filename_line);
+                        name = label = NULL;
+
                         break;
                 }
                 case TK_A_ENV: {