]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
resolved: don't let EDNS0 OPT dgram size affect TCP
authorLennart Poettering <lennart@poettering.net>
Wed, 13 Mar 2019 18:28:38 +0000 (19:28 +0100)
committerLennart Poettering <lennart@poettering.net>
Wed, 13 Mar 2019 18:34:05 +0000 (19:34 +0100)
Fixes: #11884
src/resolve/resolved-dns-packet.h

index 008860b5d1d35d26aa3304f4f5feac3765cced0e..56614c4a071756ad76ca59c7f20089fe5a27a166 100644 (file)
@@ -119,12 +119,12 @@ static inline uint16_t DNS_PACKET_PAYLOAD_SIZE_MAX(DnsPacket *p) {
 
         /* Returns the advertised maximum size for replies, or the DNS default if there's nothing defined. */
 
+        if (p->ipproto == IPPROTO_TCP) /* we ignore EDNS(0) size data on TCP, like everybody else */
+                return DNS_PACKET_SIZE_MAX;
+
         if (p->opt)
                 return MAX(DNS_PACKET_UNICAST_SIZE_MAX, p->opt->key->class);
 
-        if (p->ipproto == IPPROTO_TCP)
-                return DNS_PACKET_SIZE_MAX;
-
         return DNS_PACKET_UNICAST_SIZE_MAX;
 }