Also, stop the state machine when we get into a broken state, rather than just notify the user.
event = SD_NDISC_EVENT_ROUTER_ADVERTISMENT_MANAGED;
log_ndisc(nd, "Received Router Advertisement flags %s/%s",
- ra->nd_ra_flags_reserved & ND_RA_FLAG_MANAGED? "MANAGED": "none",
- ra->nd_ra_flags_reserved & ND_RA_FLAG_OTHER? "OTHER": "none");
+ ra->nd_ra_flags_reserved & ND_RA_FLAG_MANAGED ? "MANAGED" : "none",
+ ra->nd_ra_flags_reserved & ND_RA_FLAG_OTHER ? "OTHER" : "none");
if (event != SD_NDISC_EVENT_ROUTER_ADVERTISMENT_NONE) {
r = ndisc_ra_parse(nd, ra, len);
next_timeout, 0,
ndisc_router_solicitation_timeout, nd);
if (r < 0) {
- ndisc_notify(nd, r);
+ /* we cannot continue if we are unable to rearm the timer */
+ sd_ndisc_stop(nd);
return 0;
}
nd->state = NDISC_STATE_IDLE;
+ ndisc_notify(nd, SD_NDISC_EVENT_STOP);
+
return 0;
}
static void test_rs_done(sd_ndisc *nd, int event, void *userdata) {
sd_event *e = userdata;
- static int idx = 0;
+ static unsigned idx = 0;
struct {
uint8_t flag;
int event;
} flag_event[] = {
+ { 0, SD_NDISC_EVENT_STOP },
+ { 0, SD_NDISC_EVENT_STOP },
{ 0, SD_NDISC_EVENT_ROUTER_ADVERTISMENT_NONE },
{ ND_RA_FLAG_OTHER, SD_NDISC_EVENT_ROUTER_ADVERTISMENT_OTHER },
{ ND_RA_FLAG_MANAGED, SD_NDISC_EVENT_ROUTER_ADVERTISMENT_MANAGED }
if (verbose)
printf(" got event %d\n", event);
- if (idx < 3) {
+ if (idx < ELEMENTSOF(flag_event)) {
send_ra(flag_event[idx].flag);
return;
}
return;
switch(event) {
+ case SD_NDISC_EVENT_STOP:
case SD_NDISC_EVENT_ROUTER_ADVERTISMENT_NONE:
return;
break;
default:
- if (event < 0)
- log_link_warning_errno(link, event, "IPv6 Neighbor Discover error: %m");
- else
- log_link_warning(link, "IPv6 Neighbor Discovery unknown event: %d", event);
+ log_link_warning(link, "IPv6 Neighbor Discovery unknown event: %d", event);
break;
}
_SD_BEGIN_DECLARATIONS;
enum {
- SD_NDISC_EVENT_ROUTER_ADVERTISMENT_NONE = 0,
- SD_NDISC_EVENT_ROUTER_ADVERTISMENT_TIMEOUT = 1,
- SD_NDISC_EVENT_ROUTER_ADVERTISMENT_OTHER = 2,
- SD_NDISC_EVENT_ROUTER_ADVERTISMENT_MANAGED = 3,
+ SD_NDISC_EVENT_ROUTER_ADVERTISMENT_NONE = 0,
+ SD_NDISC_EVENT_ROUTER_ADVERTISMENT_TIMEOUT = 1,
+ SD_NDISC_EVENT_ROUTER_ADVERTISMENT_OTHER = 2,
+ SD_NDISC_EVENT_ROUTER_ADVERTISMENT_MANAGED = 3,
+ SD_NDISC_EVENT_STOP = 4,
};
typedef struct sd_ndisc sd_ndisc;