]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
service: make use of log_unit_warning_errno()'s return value
authorLennart Poettering <lennart@poettering.net>
Tue, 28 Feb 2017 15:08:21 +0000 (16:08 +0100)
committerLennart Poettering <lennart@poettering.net>
Tue, 28 Feb 2017 15:08:21 +0000 (16:08 +0100)
src/core/service.c

index 3f87e083694b198d2addad784bd65e3eb82d7b4e..5bc8df3e1c1e8ddf546e0b1f82ab3210406d6596 100644 (file)
@@ -849,11 +849,8 @@ static int service_load_pid_file(Service *s, bool may_warn) {
                 return r;
 
         r = unit_watch_pid(UNIT(s), pid);
-        if (r < 0) {
-                /* FIXME: we need to do something here */
-                log_unit_warning_errno(UNIT(s), r, "Failed to watch PID "PID_FMT" for service: %m", pid);
-                return r;
-        }
+        if (r < 0) /* FIXME: we need to do something here */
+                return log_unit_warning_errno(UNIT(s), r, "Failed to watch PID "PID_FMT" for service: %m", pid);
 
         return 0;
 }
@@ -1374,8 +1371,7 @@ static int service_spawn(
                 return r;
 
         r = unit_watch_pid(UNIT(s), pid);
-        if (r < 0)
-                /* FIXME: we need to do something here */
+        if (r < 0) /* FIXME: we need to do something here */
                 return r;
 
         *_pid = pid;