quote unknown header keywords in diagnostics

* src/xheader.c (decx): Quote unknown header in warning, as it may
contain control characters.  Problem reported by Wicher Minnaard.

diff --git a/NEWS b/NEWS
index 4a8754cf59514349565daf12dc094fd02291eacd..4b8094e59f599777b7a043878e0b2728fb6282bc 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -1,4 +1,4 @@
-GNU tar NEWS - User visible changes. 2023-08-21
+GNU tar NEWS - User visible changes. 2023-09-10
 Please send GNU tar bug reports to <bug-tar@gnu.org>
 \f
 version TBD
@@ -31,6 +31,8 @@ used, command output will be parsed using strptime(3).
 
 ** tar no longer uses alloca, fixing an unlikely stack overflow.
 
+** When diagnosing invalid extended headers tar now quotes control characters.
+
 \f
 version 1.35 - Sergey Poznyakoff, 2023-07-18
 

diff --git a/THANKS b/THANKS
index aee0a9241fd9bb35deb20e74940903e603ec6452..b51f169416abdbf2edb8bccb566ee4ecac6f26e1 100644 (file)
--- a/THANKS
+++ b/THANKS
@@ -535,6 +535,7 @@ Warner Losh         imp@boulder.parcplace.com
 Warren Dodge           warrend@sptekwv3.wv.tek.com
 Wayne Christopher      wayne@icemcfd.com
 Werner Almesberger     werner.almesberger@lrc.di.epfl.ch
+Wichar Minnaard                wicher@gavagai.nl
 William Bader          william@nscs.fast.net
 William J. Eaton       wje@hoffman.rstnu.bcm.tmc.edu
 William Kucharski      kucharsk@netcom.com

diff --git a/src/xheader.c b/src/xheader.c
index 1347ce18170538ef52ac2104fc6fd4404007bb72..c82222edc796396c97026901ddf147d9f2caa14f 100644 (file)
--- a/src/xheader.c
+++ b/src/xheader.c
@@ -692,8 +692,8 @@ decx (void *data, char const *keyword, char const *value, size_t size)
     t->decoder (st, keyword, value, size);
   else
     WARNOPT (WARN_UNKNOWN_KEYWORD,
-            (0, 0, _("Ignoring unknown extended header keyword '%s'"),
-             keyword));
+            (0, 0, _("Ignoring unknown extended header keyword %s"),
+             quotearg_style (shell_escape_always_quoting_style, keyword)));
 }
 
 void