tools/patman/test.py

   1 # -*- coding: utf-8 -*-
   2 # SPDX-License-Identifier: GPL-2.0+
   3 #
   4 # Copyright (c) 2011 The Chromium OS Authors.
   5 #
   6
   7 import os
   8 import tempfile
   9 import unittest
  10
  11 import checkpatch
  12 import gitutil
  13 import patchstream
  14 import series
  15
  16
  17 class TestPatch(unittest.TestCase):
  18     """Test this program
  19
  20     TODO: Write tests for the rest of the functionality
  21     """
  22
  23     def testBasic(self):
  24         """Test basic filter operation"""
  25         data='''
  26
  27 From 656c9a8c31fa65859d924cd21da920d6ba537fad Mon Sep 17 00:00:00 2001
  28 From: Simon Glass <sjg@chromium.org>
  29 Date: Thu, 28 Apr 2011 09:58:51 -0700
  30 Subject: [PATCH (resend) 3/7] Tegra2: Add more clock support
  31
  32 This adds functions to enable/disable clocks and reset to on-chip peripherals.
  33
  34 cmd/pci.c:152:11: warning: format ‘%llx’ expects argument of type
  35    ‘long long unsigned int’, but argument 3 has type
  36    ‘u64 {aka long unsigned int}’ [-Wformat=]
  37
  38 BUG=chromium-os:13875
  39 TEST=build U-Boot for Seaboard, boot
  40
  41 Change-Id: I80fe1d0c0b7dd10aa58ce5bb1d9290b6664d5413
  42
  43 Review URL: http://codereview.chromium.org/6900006
  44
  45 Signed-off-by: Simon Glass <sjg@chromium.org>
  46 ---
  47  arch/arm/cpu/armv7/tegra2/Makefile         |    2 +-
  48  arch/arm/cpu/armv7/tegra2/ap20.c           |   57 ++----
  49  arch/arm/cpu/armv7/tegra2/clock.c          |  163 +++++++++++++++++
  50 '''
  51         expected='''
  52
  53 From 656c9a8c31fa65859d924cd21da920d6ba537fad Mon Sep 17 00:00:00 2001
  54 From: Simon Glass <sjg@chromium.org>
  55 Date: Thu, 28 Apr 2011 09:58:51 -0700
  56 Subject: [PATCH (resend) 3/7] Tegra2: Add more clock support
  57
  58 This adds functions to enable/disable clocks and reset to on-chip peripherals.
  59
  60 cmd/pci.c:152:11: warning: format ‘%llx’ expects argument of type
  61    ‘long long unsigned int’, but argument 3 has type
  62    ‘u64 {aka long unsigned int}’ [-Wformat=]
  63
  64 Signed-off-by: Simon Glass <sjg@chromium.org>
  65 ---
  66
  67  arch/arm/cpu/armv7/tegra2/Makefile         |    2 +-
  68  arch/arm/cpu/armv7/tegra2/ap20.c           |   57 ++----
  69  arch/arm/cpu/armv7/tegra2/clock.c          |  163 +++++++++++++++++
  70 '''
  71         out = ''
  72         inhandle, inname = tempfile.mkstemp()
  73         infd = os.fdopen(inhandle, 'w')
  74         infd.write(data)
  75         infd.close()
  76
  77         exphandle, expname = tempfile.mkstemp()
  78         expfd = os.fdopen(exphandle, 'w')
  79         expfd.write(expected)
  80         expfd.close()
  81
  82         patchstream.FixPatch(None, inname, series.Series(), None)
  83         rc = os.system('diff -u %s %s' % (inname, expname))
  84         self.assertEqual(rc, 0)
  85
  86         os.remove(inname)
  87         os.remove(expname)
  88
  89     def GetData(self, data_type):
  90         data='''From 4924887af52713cabea78420eff03badea8f0035 Mon Sep 17 00:00:00 2001
  91 From: Simon Glass <sjg@chromium.org>
  92 Date: Thu, 7 Apr 2011 10:14:41 -0700
  93 Subject: [PATCH 1/4] Add microsecond boot time measurement
  94
  95 This defines the basics of a new boot time measurement feature. This allows
  96 logging of very accurate time measurements as the boot proceeds, by using
  97 an available microsecond counter.
  98
  99 %s
 100 ---
 101  README              |   11 ++++++++
 102  MAINTAINERS         |    3 ++
 103  common/bootstage.c  |   50 ++++++++++++++++++++++++++++++++++++
 104  include/bootstage.h |   71 +++++++++++++++++++++++++++++++++++++++++++++++++++
 105  include/common.h    |    8 ++++++
 106  5 files changed, 141 insertions(+), 0 deletions(-)
 107  create mode 100644 common/bootstage.c
 108  create mode 100644 include/bootstage.h
 109
 110 diff --git a/README b/README
 111 index 6f3748d..f9e4e65 100644
 112 --- a/README
 113 +++ b/README
 114 @@ -2026,6 +2026,17 @@ The following options need to be configured:
 115                 example, some LED's) on your board. At the moment,
 116                 the following checkpoints are implemented:
 117
 118 +- Time boot progress
 119 +               CONFIG_BOOTSTAGE
 120 +
 121 +               Define this option to enable microsecond boot stage timing
 122 +               on supported platforms. For this to work your platform
 123 +               needs to define a function timer_get_us() which returns the
 124 +               number of microseconds since reset. This would normally
 125 +               be done in your SOC or board timer.c file.
 126 +
 127 +               You can add calls to bootstage_mark() to set time markers.
 128 +
 129  - Standalone program support:
 130                 CONFIG_STANDALONE_LOAD_ADDR
 131
 132 diff --git a/MAINTAINERS b/MAINTAINERS
 133 index b167b028ec..beb7dc634f 100644
 134 --- a/MAINTAINERS
 135 +++ b/MAINTAINERS
 136 @@ -474,3 +474,8 @@ S:  Maintained
 137  T:     git git://git.denx.de/u-boot.git
 138  F:     *
 139  F:     */
 140 +
 141 +BOOTSTAGE
 142 +M:     Simon Glass <sjg@chromium.org>
 143 +L:     u-boot@lists.denx.de
 144 +F:     common/bootstage.c
 145 diff --git a/common/bootstage.c b/common/bootstage.c
 146 new file mode 100644
 147 index 0000000..2234c87
 148 --- /dev/null
 149 +++ b/common/bootstage.c
 150 @@ -0,0 +1,37 @@
 151 +/* SPDX-License-Identifier: GPL-2.0+ */
 152 +/*
 153 + * Copyright (c) 2011, Google Inc. All rights reserved.
 154 + *
 155 + */
 156 +
 157 +/*
 158 + * This module records the progress of boot and arbitrary commands, and
 159 + * permits accurate timestamping of each. The records can optionally be
 160 + * passed to kernel in the ATAGs
 161 + */
 162 +
 163 +#include <common.h>
 164 +
 165 +struct bootstage_record {
 166 +       u32 time_us;
 167 +       const char *name;
 168 +};
 169 +
 170 +static struct bootstage_record record[BOOTSTAGE_COUNT];
 171 +
 172 +u32 bootstage_mark(enum bootstage_id id, const char *name)
 173 +{
 174 +       struct bootstage_record *rec = &record[id];
 175 +
 176 +       /* Only record the first event for each */
 177 +%sif (!rec->name) {
 178 +               rec->time_us = (u32)timer_get_us();
 179 +               rec->name = name;
 180 +       }
 181 +       if (!rec->name &&
 182 +       %ssomething_else) {
 183 +               rec->time_us = (u32)timer_get_us();
 184 +               rec->name = name;
 185 +       }
 186 +%sreturn rec->time_us;
 187 +}
 188 --
 189 1.7.3.1
 190 '''
 191         signoff = 'Signed-off-by: Simon Glass <sjg@chromium.org>\n'
 192         tab = ' '
 193         indent = '    '
 194         if data_type == 'good':
 195             pass
 196         elif data_type == 'no-signoff':
 197             signoff = ''
 198         elif data_type == 'spaces':
 199             tab = '   '
 200         elif data_type == 'indent':
 201             indent = tab
 202         else:
 203             print('not implemented')
 204         return data % (signoff, tab, indent, tab)
 205
 206     def SetupData(self, data_type):
 207         inhandle, inname = tempfile.mkstemp()
 208         infd = os.fdopen(inhandle, 'w')
 209         data = self.GetData(data_type)
 210         infd.write(data)
 211         infd.close()
 212         return inname
 213
 214     def testGood(self):
 215         """Test checkpatch operation"""
 216         inf = self.SetupData('good')
 217         result = checkpatch.CheckPatch(inf)
 218         self.assertEqual(result.ok, True)
 219         self.assertEqual(result.problems, [])
 220         self.assertEqual(result.errors, 0)
 221         self.assertEqual(result.warnings, 0)
 222         self.assertEqual(result.checks, 0)
 223         self.assertEqual(result.lines, 62)
 224         os.remove(inf)
 225
 226     def testNoSignoff(self):
 227         inf = self.SetupData('no-signoff')
 228         result = checkpatch.CheckPatch(inf)
 229         self.assertEqual(result.ok, False)
 230         self.assertEqual(len(result.problems), 1)
 231         self.assertEqual(result.errors, 1)
 232         self.assertEqual(result.warnings, 0)
 233         self.assertEqual(result.checks, 0)
 234         self.assertEqual(result.lines, 62)
 235         os.remove(inf)
 236
 237     def testSpaces(self):
 238         inf = self.SetupData('spaces')
 239         result = checkpatch.CheckPatch(inf)
 240         self.assertEqual(result.ok, False)
 241         self.assertEqual(len(result.problems), 3)
 242         self.assertEqual(result.errors, 0)
 243         self.assertEqual(result.warnings, 3)
 244         self.assertEqual(result.checks, 0)
 245         self.assertEqual(result.lines, 62)
 246         os.remove(inf)
 247
 248     def testIndent(self):
 249         inf = self.SetupData('indent')
 250         result = checkpatch.CheckPatch(inf)
 251         self.assertEqual(result.ok, False)
 252         self.assertEqual(len(result.problems), 1)
 253         self.assertEqual(result.errors, 0)
 254         self.assertEqual(result.warnings, 0)
 255         self.assertEqual(result.checks, 1)
 256         self.assertEqual(result.lines, 62)
 257         os.remove(inf)
 258
 259
 260 if __name__ == "__main__":
 261     unittest.main()
 262     gitutil.RunTests()