build-sys: release++ (v2.31)

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.31-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: update sv.po (from translationproject.org)

po: update pt_BR.po (from translationproject.org)

po: update pl.po (from translationproject.org)

rfkill: fix description name typo

Commit 7d2a9960ad made gps to look like a GUID Partition Table.

Reviewed-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Sami Kerola <kerolasa@iki.fi>

blkid: improve man page wording

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: more info about ambivalent results to the man page

Signed-off-by: Karel Zak <kzak@redhat.com>

blkid: cleanup man page info about lsblk

Signed-off-by: Karel Zak <kzak@redhat.com>

zramctl: fix show all non-zero zram devices

Addresses: https://github.com/karelzak/util-linux/issues/521
Signed-off-by: Karel Zak <kzak@redhat.com>

zramctl: remove unused ZRAM_EMPTY and blank line

rfkill: fix typo [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: fix bitwise vs. logical typo [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

ipcs: fix memory leak [coverity scan]

It's not important, but let's keep static analyzes happy.

Signed-off-by: Karel Zak <kzak@redhat.com>

logger: keep header generators independent on connection

* avoid memory leaks
* don't use incomplete or header after free()

Signed-off-by: Karel Zak <kzak@redhat.com>

fincore: make sure mmap(NULL, ...) [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libsmartcols: (sample) cleanup line separator usage

* add comment to explain when nolinesep flag is necessary
* force to print \n before switch to the next line to support

  ./sample-scols-continuous > file

use case.

Addresses: https://github.com/ignatenkobrain/python-smartcols/issues/18
Signed-off-by: Karel Zak <kzak@redhat.com>

libsmartcols: (docs) add note about line separators

Signed-off-by: Karel Zak <kzak@redhat.com>

lslogins: fix possible memory leak [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libsmartcols: don't call free_buffer() for uninitialized variable [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: make sure we call stat() propely [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

libfdisk: (sun) make math more robust [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/pager: check open() return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/mbsedit: check wctomb() return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>

logger: allow to reconnect on initial failed connect too

The current code sets noact flag if unix socked connection failed. This is ugly.
We want to reconnect always in all cases (well, except --socket-error=on).

Signed-off-by: Karel Zak <kzak@redhat.com>

logger: add dummy fallback for OSX

Signed-off-by: Karel Zak <kzak@redhat.com>

logger: reconnect on failed send()

The libc syslog() reconnects on failed send(). We need the same thing
as logger(1) is expected as long time running tool. For example
recommended Apache configuration is:

ErrorLog "| /usr/bin/logger -t apache_error -p local6.debug"

The issue is that connection endpoint (e.g. syslogd) maybe restarted.
The simple way how to test is:

for i in $(seq 0 3600); do echo "This is message number $i"; sleep 1; done | logger --tcp --server 127.0.0.1 --port 514

and restart your syslog. The current implementation gets SIGPIPE or
write warning message, but it never reconnect.

Addresses: https://github.com/karelzak/util-linux/issues/363
Signed-off-by: Karel Zak <kzak@redhat.com>

Merge branch 'mount-typo' of https://github.com/Liam-Ryan/util-linux

* 'mount-typo' of https://github.com/Liam-Ryan/util-linux:
  Fixed typo in mount.8

setsid: document fork(2) usage

Addresses: https://github.com/karelzak/util-linux/issues/518
Signed-off-by: Karel Zak <kzak@redhat.com>

Fixed typo in mount.8

Signed-off-by: Liam Ryan <liamryandev@gmail.com>

agetty: fix /etc/os-release parsing

For example /etc/os-release:

VERSION="26 (Twenty Six)"
VERSION_ID=26

agetty for \S{VERSION} returns

_ID=26

because the parser does nor check for '=' after variable name.

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1498462
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: (TODO) make PMBR boot flag more user-friendly

Signed-off-by: Karel Zak <kzak@redhat.com>

losetup: fix conflicting types for ‘loopcxt_set_blocksize’

Reported-by: Lars Wendler <polynomial-c@gentoo.org>
Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: release++ (v2.31-rc2)

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.31-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

rfkill: support old "list" output

.. just because we want to be replacement for the original version.

Signed-off-by: Karel Zak <kzak@redhat.com>

rfkill: remove duplicate code

Signed-off-by: Karel Zak <kzak@redhat.com>

rfkill: refactor actions

* convert action string to ID and use switch()
* add note about default output to the man page

Signed-off-by: Karel Zak <kzak@redhat.com>

rfkill: improve default output

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add Atari PT to the TODO list

Addresses: https://github.com/karelzak/util-linux/issues/517
Signed-off-by: Karel Zak <kzak@redhat.com>

libmount: add human compatible message for EBADMSG errno

 mount: /media/sdb5: mount(2) system call failed: Bad message.

is really ugly for end users. It seems XFS, extN (etc) use EBADMSG for
bad checksums. For network or pseudo filesystems continue to use "Bad
message" error...

Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=1496764
Signed-off-by: Karel Zak <kzak@redhat.com>

Merge branch 'fix-python_libmount_get_propagation' of https://github.com/giuseppe/util-linux

* 'fix-python_libmount_get_propagation' of https://github.com/giuseppe/util-linux:
  libmount: fix Python get_propagation

Merge branch 'patch-1' of https://github.com/sgargel/util-linux

* 'patch-1' of https://github.com/sgargel/util-linux:
  Fix end translation

losetup: rename to --sector-size and LOG-SEC

Signed-off-by: Karel Zak <kzak@redhat.com>

lib/randutils: remove superfluous continue

Addresses: https://github.com/karelzak/util-linux/commit/fa949792072530b49ef5760d7ecd6d250c66e35f#commitcomment-24678670
Signed-off-by: Karel Zak <kzak@redhat.com>

Fix end translation

See also https://translate.google.it/#en/it/end

losetup: Add support for logical block size

Kernel since 4.14 supports setting of logical block size[1]. It allows to
create loop devices that report logical block size different from 512.

Add support for this feature to losetup.

References:
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/block/loop.c?id=89e4fdecb51cf5535867026274bc97de9480ade5

[kzak@redhat.com: - fix loopcxt_get_blocksize()
                  - remove lo_blocksize from loop_info64]

Signed-off-by: Stanislav Brabec <sbrabec@suse.cz>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add exec() exit codes to TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

cfdisk: cleanup die-on-signal code

Let's keep signal handler simple and don't cleanup terminal from the
handler.

Signed-off-by: Karel Zak <kzak@redhat.com>

cfdisk: make resize code more readable

Signed-off-by: Karel Zak <kzak@redhat.com>

setproctitle: fix out of boundary access

A program using setproctitle can trigger an out of boundary access
if an attacker was able to clear the environment before execution.

The check in setproctitle prevents overflows, but does not take into
account that the whole length of the arguments could be 1, which is
possible by supplying such a program name to execlp(3) or using a
symbolic link, e.g. argv[0] = "l", argv[1] = NULL.

Only login uses setproctitle, which is not affected by this
problem due to initializing the environment right before the call.

login: fix signal race

The functions warnx(3) and gettext(3) are not safe to use within signal
handlers and should be avoided. Preparing the message beforehand and
calling write(2) as well as calling _exit(2) solves the problem.

[kzak@redhat.com: - use program_invocation_short_name rather than argv[0],
                  - use ignore_result() to keep compiler happy]

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: add 2.30.2 to ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: release++ (v2.31-rc1)

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.31 release notes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: Fix translation in ja.po

English message and Japanese translation are unmatch.

Signed-off-by: Masanari Iida <standby24x7@gmail.com>

po:Fix a typo

Signed-off-by: Masanari Iida <standby24x7@gmail.com>

Merge branch '170915' of github.com:jwpi/util-linux

* '170915' of github.com:jwpi/util-linux:
  hwclock: make debug implicit for test mode.
  hwclock: exit bug fix and single test mode message

libmount: fix Python get_propagation

The current implementation would return always 0, as it is the return
code of mnt_fs_get_propagation.  Change the implementation to raise an
exception on an error and return the propagation flags otherwise.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>

hwclock: make debug implicit for test mode.

Calling --test without --debug is not useful, so
make it implicit.

Signed-off-by: J William Piggott <elseifthen@gmx.com>

hwclock: exit bug fix and single test mode message

Bug fix: hwclock returns success when saving /etc/adjtime fails.

Remove redundant test mode messages.

Signed-off-by: J William Piggott <elseifthen@gmx.com>

Docs: add hwclock 'highlights' v2.31-ReleaseNotes

Signed-off-by: J William Piggott <elseifthen@gmx.com>

Docs: grammar fixes for v2.31-ReleaseNotes

Signed-off-by: J William Piggott <elseifthen@gmx.com>

po: fix ipcrm translation error fr.po

Addresses: https://github.com/karelzak/util-linux/issues/512
Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update v2.31-ReleaseNotes

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: remove UUID v3 and v5 from TODO

Signed-off-by: Karel Zak <kzak@redhat.com>

docs: update AUTHORS file

Signed-off-by: Karel Zak <kzak@redhat.com>

po: merge changes

Signed-off-by: Karel Zak <kzak@redhat.com>

po: update pt_BR.po (from translationproject.org)

po: update fr.po (from translationproject.org)

po: update es.po (from translationproject.org)

po: update da.po (from translationproject.org)

po: update cs.po (from translationproject.org)

tests: update build-sys tests

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: fix non-blkid compilation

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: make rfkill optional (and enabled by default)

Signed-off-by: Karel Zak <kzak@redhat.com>

build-sys: add libtinfow check

It seems some systems differentiate between tinfo and tinfow. And it
seems that mix ncursesw and tinfo (wide vs. non-wide char) is problem
for the systems.

Note that for example Fedora have ncursesw as well as ncurses, but
only one tinfo library. So, we need fallback this scenario.

Reported-by: Stanislav Brabec <sbrabec@suse.cz>
Signed-off-by: Karel Zak <kzak@redhat.com>

su: (pty) improve SIGSTOP/SIGCONT semantic

We want to use waitpid() only when child is terminated or stopped to
pick up child status, otherwise PTY proxy has to be active. This is
difference between "su" and "su --pty". For "su" we keep parent all
time in waitpid().

It would be possible to use separate code based on signalfd_siginfo,
but it seems better to keep all this stuff on one place -- it  means
wait_for_child().

Signed-off-by: Karel Zak <kzak@redhat.com>

su: (pty) save child status

Signed-off-by: Karel Zak <kzak@redhat.com>

su: (pty) simplify stdin usage in poll()

Not sure why I have problem with this years ago for script(1), but it
seems .fd=-1 is really enough to the ignore the FD.

Reported-by: Vaclav Dolezal <vdolezal@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

script: simplify stdin usage in poll()

Signed-off-by: Karel Zak <kzak@redhat.com>

su: (pty) fix slave terminal attributes initialization

Reported-by: Vaclav Dolezal <vdolezal@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

su: (pty) fix child signal mask usage

The signal mask is used by pty_init_slave(), but it has never been
uninitialized before fork(), so child gets 0 as a mask :-(

Note that script(1) has no this issue because it opens signal-fd
before fork().

Reported-by: Vaclav Dolezal <vdolezal@redhat.com>
Signed-off-by: Karel Zak <kzak@redhat.com>

runuser: fix linking

Add conditional -lutil to runuser when needed to avoid linking error.

login-utils/su-common.o: In function `pty_create':
login-utils/su-common.c:269: undefined reference to `openpty'
login-utils/su-common.c:273: undefined reference to `openpty'

Signed-off-by: Sami Kerola <kerolasa@iki.fi>

su: fix non-pty compilation

Signed-off-by: Karel Zak <kzak@redhat.com>

su: enable TIOCSCTTY and minor changes

Signed-off-by: Karel Zak <kzak@redhat.com>

su: add more informartion to man page

Signed-off-by: Karel Zak <kzak@redhat.com>

su: add PTY support

Signed-off-by: Karel Zak <kzak@redhat.com>

su: add --pty option

Signed-off-by: Karel Zak <kzak@redhat.com>

su: move parent signals setup to separate function

Signed-off-by: Karel Zak <kzak@redhat.com>

su: make wait_for_child() usable in arbitrary situation

For example if called more than once; to keep PTY code simple and
robust.

Signed-off-by: Karel Zak <kzak@redhat.com>

su: keep old sigactions in control struct

Signed-off-by: Karel Zak <kzak@redhat.com>

su: fix refactoring bug in child PID usage

Fix child pid cleanup according to commit 0076012563ff34e294a6166d605118bcdd35f7e1.

Signed-off-by: Karel Zak <kzak@redhat.com>

su: add child to control struct

Signed-off-by: Karel Zak <kzak@redhat.com>

su: fix compiler warnings [-Wimplicit-fallthrough=]

Signed-off-by: Karel Zak <kzak@redhat.com>