]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_db: properly set dquot_buf when operating on dquot
authorEric Sandeen <sandeen@sandeen.net>
Thu, 8 Sep 2016 00:22:18 +0000 (10:22 +1000)
committerDave Chinner <david@fromorbit.com>
Thu, 8 Sep 2016 00:22:18 +0000 (10:22 +1000)
The earlier commit:

66a40d02 db: verify and calculate dquot CRCs

added a "dquot_buf" to the iocur to specify when we were operating
on a dquot and thus handle dquot CRC updates - but nothing ever
actually set dquot_buf to a non-zero value.

Without doing so, we don't recalculate the dquot crc when
changing contents of a dquot:

# xfs_db -x -c "dquot -u 500" -c "p crc" -c "write diskdq.bcount 2" \
    -c "p crc" crctestfile
crc = 0xfd293c68 (correct)
diskdq.bcount = 2
crc = 0xfd293c68 (correct)

[ the "(correct)" tag is another, different issue ]

# xfs_db -x -c "dquot -u 500" -c "p crc" crctestfile
Metadata CRC error detected at xfs_dquot block 0xd8/0x1000
crc = 0xfd293c68 (bad)

With this change, dquot CRCs are properly recalculated in write_cur.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
db/dquot.c

index 47740f0a679416e41b3cf0fa33d91047778b0f08..061eca5dfdf7e870203284957f832103d444bed3 100644 (file)
@@ -164,6 +164,7 @@ dquot_f(
        }
        set_cur(&typtab[TYP_DQBLK], XFS_FSB_TO_DADDR(mp, bm.startblock), blkbb,
                DB_RING_IGN, NULL);
+       iocur_top->dquot_buf = 1;
        off_cur(qoff * (int)sizeof(xfs_dqblk_t), sizeof(xfs_dqblk_t));
        ring_add();
        return 0;