]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: don't set XFS_BTCUR_BPRV_WASDEL in xfs_bunmapi
authorChristoph Hellwig <hch@lst.de>
Fri, 17 Nov 2017 04:08:59 +0000 (22:08 -0600)
committerEric Sandeen <sandeen@redhat.com>
Fri, 17 Nov 2017 04:08:59 +0000 (22:08 -0600)
Source kernel commit: b213d69293cf003e6f0c63adfee6fcc70e3afee6

The XFS_BTCUR_BPRV_WASDEL flag is supposed to indicate that we are
converting a delayed allocation to a real one, which isn't the case
in xfs_bunmapi.  Setting it could theoretically lead to misaccounting
here, but it's unlikely that we ever hit it in practice.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_bmap.c

index 836655707dfc2b543a665dfc1e71d84cb85a7828..ae36f7582a60caad9d586e26ff13b3d025400dda 100644 (file)
@@ -5714,11 +5714,7 @@ __xfs_bunmapi(
                                        XFS_QMOPT_RES_REGBLKS);
                        }
                        ip->i_delayed_blks -= del.br_blockcount;
-                       if (cur)
-                               cur->bc_private.b.flags |=
-                                       XFS_BTCUR_BPRV_WASDEL;
-               } else if (cur)
-                       cur->bc_private.b.flags &= ~XFS_BTCUR_BPRV_WASDEL;
+               }
 
                error = xfs_bmap_del_extent(ip, tp, &lastx, dfops, cur, &del,
                                &tmp_logflags, whichfork, flags);