]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
mkfs: sanitise ftype parameter values.
authorDave Chinner <dchinner@redhat.com>
Tue, 10 May 2016 07:16:06 +0000 (17:16 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 10 May 2016 07:16:06 +0000 (17:16 +1000)
Because passing "-n ftype=2" should fail.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Jan Tulak <jtulak@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
mkfs/xfs_mkfs.c

index 5527b872cb52bc5a31e80e665fc242b1e84574a4..4be14dace0f87ef636cc2ccf66595a1c8b9e4787 100644 (file)
@@ -1597,7 +1597,10 @@ main(
                                                reqval('n', nopts, N_FTYPE);
                                        if (nftype)
                                                respec('n', nopts, N_FTYPE);
-                                       dirftype = atoi(value);
+                                       c = atoi(value);
+                                       if (c < 0 || c > 1)
+                                               illegal(value, "n ftype");
+                                       dirftype = c;
                                        nftype = 1;
                                        break;
                                default: